From patchwork Wed Feb 5 04:58:19 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jayamohan Kallickal X-Patchwork-Id: 3584391 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: X-Original-To: patchwork-linux-pci@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 88B339F2E9 for ; Wed, 5 Feb 2014 04:58:39 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id B6FB42018E for ; Wed, 5 Feb 2014 04:58:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E4E062017B for ; Wed, 5 Feb 2014 04:58:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754572AbaBEE6W (ORCPT ); Tue, 4 Feb 2014 23:58:22 -0500 Received: from cmexedge2.ext.emulex.com ([138.239.224.100]:47668 "EHLO CMEXEDGE2.ext.emulex.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754479AbaBEE6V convert rfc822-to-8bit (ORCPT ); Tue, 4 Feb 2014 23:58:21 -0500 Received: from CMEXHTCAS2.ad.emulex.com (138.239.115.218) by CMEXEDGE2.ext.emulex.com (138.239.224.100) with Microsoft SMTP Server (TLS) id 14.3.174.1; Tue, 4 Feb 2014 20:59:03 -0800 Received: from CMEXMB1.ad.emulex.com ([169.254.1.79]) by CMEXHTCAS2.ad.emulex.com ([::1]) with mapi id 14.03.0174.001; Tue, 4 Feb 2014 20:58:20 -0800 From: Jayamohan Kallickal To: Alexander Gordeev , "linux-kernel@vger.kernel.org" CC: "linux-scsi@vger.kernel.org" , "linux-pci@vger.kernel.org" Subject: RE: [PATCH 01/22] be2iscsi: Use pci_enable_msix_range() Thread-Topic: [PATCH 01/22] be2iscsi: Use pci_enable_msix_range() Thread-Index: AQHPIZpqvGFpGDCHV0mMyOIzezFam5qmGHbA Date: Wed, 5 Feb 2014 04:58:19 +0000 Message-ID: <37724B2049F71D4C9B086F99DDB2DE112A8A6E19@CMEXMB1.ad.emulex.com> References: <34995adbde34985e99f01a04e34c03a4c9ad96dc.1391512266.git.agordeev@redhat.com> In-Reply-To: <34995adbde34985e99f01a04e34c03a4c9ad96dc.1391512266.git.agordeev@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [138.239.125.203] MIME-Version: 1.0 Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP -----Original Message----- From: Alexander Gordeev [mailto:agordeev@redhat.com] Sent: Tuesday, February 04, 2014 3:17 AM To: linux-kernel@vger.kernel.org Cc: Alexander Gordeev; Jayamohan Kallickal; linux-scsi@vger.kernel.org; linux-pci@vger.kernel.org Subject: [PATCH 01/22] be2iscsi: Use pci_enable_msix_range() As result of deprecation of MSI-X/MSI enablement functions pci_enable_msix() and pci_enable_msi_block() all drivers using these two interfaces need to be updated to use the new pci_enable_msi_range() and pci_enable_msix_range() interfaces. Signed-off-by: Alexander Gordeev Cc: Jayamohan Kallickal Cc: linux-scsi@vger.kernel.org Cc: linux-pci@vger.kernel.org --- drivers/scsi/be2iscsi/be_main.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) Looks OK to me Acked-by: Jayamohan Kallickal -- -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c index 1f37505..5878f3e 100644 --- a/drivers/scsi/be2iscsi/be_main.c +++ b/drivers/scsi/be2iscsi/be_main.c @@ -5284,9 +5284,9 @@ static void beiscsi_msix_enable(struct beiscsi_hba *phba) for (i = 0; i <= phba->num_cpus; i++) phba->msix_entries[i].entry = i; - status = pci_enable_msix(phba->pcidev, phba->msix_entries, - (phba->num_cpus + 1)); - if (!status) + status = pci_enable_msix_range(phba->pcidev, phba->msix_entries, + phba->num_cpus + 1, phba->num_cpus + 1); + if (status > 0) phba->msix_enabled = true; return;