From patchwork Sat Apr 18 08:43:46 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yinghai Lu X-Patchwork-Id: 18799 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n3I8i5iI008362 for ; Sat, 18 Apr 2009 08:44:05 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753253AbZDRIoD (ORCPT ); Sat, 18 Apr 2009 04:44:03 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752951AbZDRIoD (ORCPT ); Sat, 18 Apr 2009 04:44:03 -0400 Received: from hera.kernel.org ([140.211.167.34]:38527 "EHLO hera.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752814AbZDRIoB (ORCPT ); Sat, 18 Apr 2009 04:44:01 -0400 Received: from [192.168.101.7] (adsl-75-36-250-224.dsl.pltn13.sbcglobal.net [75.36.250.224]) (authenticated bits=0) by hera.kernel.org (8.14.2/8.13.8) with ESMTP id n3I8htPb011366 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 18 Apr 2009 08:43:56 GMT Message-ID: <49E992C2.4010707@kernel.org> Date: Sat, 18 Apr 2009 01:43:46 -0700 From: Yinghai Lu User-Agent: Thunderbird 2.0.0.19 (X11/20081227) MIME-Version: 1.0 To: Jesse Barnes , Matthew Wilcox , Ingo Molnar CC: linux-pci@vger.kernel.org, "linux-kernel@vger.kernel.org" Subject: [PATCH 1/3] x86/pci: fix -1 calling to e820_all_mapped with mmconfig X-Virus-Scanned: ClamAV 0.93.3/9254/Fri Apr 17 23:36:48 2009 on hera.kernel.org X-Virus-Status: Clean Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org e820_all_mapped need end is (addr + size) instead of (addr + size - 1) [Impact: fix -1 offset calling] Signed-off-by: Yinghai Lu Acked-by: Ingo Molnar --- arch/x86/pci/mmconfig-shared.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Index: linux-2.6/arch/x86/pci/mmconfig-shared.c =================================================================== --- linux-2.6.orig/arch/x86/pci/mmconfig-shared.c +++ linux-2.6/arch/x86/pci/mmconfig-shared.c @@ -375,7 +375,7 @@ static acpi_status __init check_mcfg_res if (!fixmem32) return AE_OK; if ((mcfg_res->start >= fixmem32->address) && - (mcfg_res->end < (fixmem32->address + + (mcfg_res->end <= (fixmem32->address + fixmem32->address_length))) { mcfg_res->flags = 1; return AE_CTRL_TERMINATE; @@ -392,7 +392,7 @@ static acpi_status __init check_mcfg_res return AE_OK; if ((mcfg_res->start >= address.minimum) && - (mcfg_res->end < (address.minimum + address.address_length))) { + (mcfg_res->end <= (address.minimum + address.address_length))) { mcfg_res->flags = 1; return AE_CTRL_TERMINATE; } @@ -439,7 +439,7 @@ static int __init is_mmconf_reserved(che u64 old_size = size; int valid = 0; - while (!is_reserved(addr, addr + size - 1, E820_RESERVED)) { + while (!is_reserved(addr, addr + size, E820_RESERVED)) { size >>= 1; if (size < (16UL<<20)) break;