| Message ID | 4A35B0C3.3070708@jp.fujitsu.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
* Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>: > The "owner" field in struct hotplug_slot_ops is initialized by PCI > hotplug core. So each hotplug controller driver doesn't need to > initialize it. Reviewed-by: Alex Chiang <achiang@hp.com> > Signed-off-by: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com> > > --- > drivers/pci/hotplug/acpiphp_core.c | 1 - > drivers/pci/hotplug/cpci_hotplug_core.c | 1 - > drivers/pci/hotplug/cpqphp_core.c | 1 - > drivers/pci/hotplug/ibmphp_core.c | 1 - > drivers/pci/hotplug/pciehp_core.c | 1 - > drivers/pci/hotplug/pcihp_skeleton.c | 1 - > drivers/pci/hotplug/rpaphp_core.c | 1 - > drivers/pci/hotplug/sgi_hotplug.c | 1 - > drivers/pci/hotplug/shpchp_core.c | 1 - > 9 files changed, 9 deletions(-) > > Index: 20090612/drivers/pci/hotplug/pciehp_core.c > =================================================================== > --- 20090612.orig/drivers/pci/hotplug/pciehp_core.c > +++ 20090612/drivers/pci/hotplug/pciehp_core.c > @@ -73,7 +73,6 @@ static int get_max_bus_speed (struct hot > static int get_cur_bus_speed (struct hotplug_slot *slot, enum pci_bus_speed *value); > > static struct hotplug_slot_ops pciehp_hotplug_slot_ops = { > - .owner = THIS_MODULE, > .set_attention_status = set_attention_status, > .enable_slot = enable_slot, > .disable_slot = disable_slot, > Index: 20090612/drivers/pci/hotplug/pcihp_skeleton.c > =================================================================== > --- 20090612.orig/drivers/pci/hotplug/pcihp_skeleton.c > +++ 20090612/drivers/pci/hotplug/pcihp_skeleton.c > @@ -82,7 +82,6 @@ static int get_latch_status (struct hotp > static int get_adapter_status (struct hotplug_slot *slot, u8 *value); > > static struct hotplug_slot_ops skel_hotplug_slot_ops = { > - .owner = THIS_MODULE, > .enable_slot = enable_slot, > .disable_slot = disable_slot, > .set_attention_status = set_attention_status, > Index: 20090612/drivers/pci/hotplug/shpchp_core.c > =================================================================== > --- 20090612.orig/drivers/pci/hotplug/shpchp_core.c > +++ 20090612/drivers/pci/hotplug/shpchp_core.c > @@ -69,7 +69,6 @@ static int get_max_bus_speed (struct hot > static int get_cur_bus_speed (struct hotplug_slot *slot, enum pci_bus_speed *value); > > static struct hotplug_slot_ops shpchp_hotplug_slot_ops = { > - .owner = THIS_MODULE, > .set_attention_status = set_attention_status, > .enable_slot = enable_slot, > .disable_slot = disable_slot, > Index: 20090612/drivers/pci/hotplug/cpci_hotplug_core.c > =================================================================== > --- 20090612.orig/drivers/pci/hotplug/cpci_hotplug_core.c > +++ 20090612/drivers/pci/hotplug/cpci_hotplug_core.c > @@ -72,7 +72,6 @@ static int get_adapter_status(struct hot > static int get_latch_status(struct hotplug_slot *slot, u8 * value); > > static struct hotplug_slot_ops cpci_hotplug_slot_ops = { > - .owner = THIS_MODULE, > .enable_slot = enable_slot, > .disable_slot = disable_slot, > .set_attention_status = set_attention_status, > Index: 20090612/drivers/pci/hotplug/cpqphp_core.c > =================================================================== > --- 20090612.orig/drivers/pci/hotplug/cpqphp_core.c > +++ 20090612/drivers/pci/hotplug/cpqphp_core.c > @@ -608,7 +608,6 @@ static int get_cur_bus_speed (struct hot > } > > static struct hotplug_slot_ops cpqphp_hotplug_slot_ops = { > - .owner = THIS_MODULE, > .set_attention_status = set_attention_status, > .enable_slot = process_SI, > .disable_slot = process_SS, > Index: 20090612/drivers/pci/hotplug/ibmphp_core.c > =================================================================== > --- 20090612.orig/drivers/pci/hotplug/ibmphp_core.c > +++ 20090612/drivers/pci/hotplug/ibmphp_core.c > @@ -1316,7 +1316,6 @@ error: > } > > struct hotplug_slot_ops ibmphp_hotplug_slot_ops = { > - .owner = THIS_MODULE, > .set_attention_status = set_attention_status, > .enable_slot = enable_slot, > .disable_slot = ibmphp_disable_slot, > Index: 20090612/drivers/pci/hotplug/rpaphp_core.c > =================================================================== > --- 20090612.orig/drivers/pci/hotplug/rpaphp_core.c > +++ 20090612/drivers/pci/hotplug/rpaphp_core.c > @@ -423,7 +423,6 @@ static int disable_slot(struct hotplug_s > } > > struct hotplug_slot_ops rpaphp_hotplug_slot_ops = { > - .owner = THIS_MODULE, > .enable_slot = enable_slot, > .disable_slot = disable_slot, > .set_attention_status = set_attention_status, > Index: 20090612/drivers/pci/hotplug/sgi_hotplug.c > =================================================================== > --- 20090612.orig/drivers/pci/hotplug/sgi_hotplug.c > +++ 20090612/drivers/pci/hotplug/sgi_hotplug.c > @@ -83,7 +83,6 @@ static int disable_slot(struct hotplug_s > static inline int get_power_status(struct hotplug_slot *slot, u8 *value); > > static struct hotplug_slot_ops sn_hotplug_slot_ops = { > - .owner = THIS_MODULE, > .enable_slot = enable_slot, > .disable_slot = disable_slot, > .get_power_status = get_power_status, > Index: 20090612/drivers/pci/hotplug/acpiphp_core.c > =================================================================== > --- 20090612.orig/drivers/pci/hotplug/acpiphp_core.c > +++ 20090612/drivers/pci/hotplug/acpiphp_core.c > @@ -77,7 +77,6 @@ static int get_latch_status (struct hotp > static int get_adapter_status (struct hotplug_slot *slot, u8 *value); > > static struct hotplug_slot_ops acpi_hotplug_slot_ops = { > - .owner = THIS_MODULE, > .enable_slot = enable_slot, > .disable_slot = disable_slot, > .set_attention_status = set_attention_status, > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-pci" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Index: 20090612/drivers/pci/hotplug/pciehp_core.c =================================================================== --- 20090612.orig/drivers/pci/hotplug/pciehp_core.c +++ 20090612/drivers/pci/hotplug/pciehp_core.c @@ -73,7 +73,6 @@ static int get_max_bus_speed (struct hot static int get_cur_bus_speed (struct hotplug_slot *slot, enum pci_bus_speed *value); static struct hotplug_slot_ops pciehp_hotplug_slot_ops = { - .owner = THIS_MODULE, .set_attention_status = set_attention_status, .enable_slot = enable_slot, .disable_slot = disable_slot, Index: 20090612/drivers/pci/hotplug/pcihp_skeleton.c =================================================================== --- 20090612.orig/drivers/pci/hotplug/pcihp_skeleton.c +++ 20090612/drivers/pci/hotplug/pcihp_skeleton.c @@ -82,7 +82,6 @@ static int get_latch_status (struct hotp static int get_adapter_status (struct hotplug_slot *slot, u8 *value); static struct hotplug_slot_ops skel_hotplug_slot_ops = { - .owner = THIS_MODULE, .enable_slot = enable_slot, .disable_slot = disable_slot, .set_attention_status = set_attention_status, Index: 20090612/drivers/pci/hotplug/shpchp_core.c =================================================================== --- 20090612.orig/drivers/pci/hotplug/shpchp_core.c +++ 20090612/drivers/pci/hotplug/shpchp_core.c @@ -69,7 +69,6 @@ static int get_max_bus_speed (struct hot static int get_cur_bus_speed (struct hotplug_slot *slot, enum pci_bus_speed *value); static struct hotplug_slot_ops shpchp_hotplug_slot_ops = { - .owner = THIS_MODULE, .set_attention_status = set_attention_status, .enable_slot = enable_slot, .disable_slot = disable_slot, Index: 20090612/drivers/pci/hotplug/cpci_hotplug_core.c =================================================================== --- 20090612.orig/drivers/pci/hotplug/cpci_hotplug_core.c +++ 20090612/drivers/pci/hotplug/cpci_hotplug_core.c @@ -72,7 +72,6 @@ static int get_adapter_status(struct hot static int get_latch_status(struct hotplug_slot *slot, u8 * value); static struct hotplug_slot_ops cpci_hotplug_slot_ops = { - .owner = THIS_MODULE, .enable_slot = enable_slot, .disable_slot = disable_slot, .set_attention_status = set_attention_status, Index: 20090612/drivers/pci/hotplug/cpqphp_core.c =================================================================== --- 20090612.orig/drivers/pci/hotplug/cpqphp_core.c +++ 20090612/drivers/pci/hotplug/cpqphp_core.c @@ -608,7 +608,6 @@ static int get_cur_bus_speed (struct hot } static struct hotplug_slot_ops cpqphp_hotplug_slot_ops = { - .owner = THIS_MODULE, .set_attention_status = set_attention_status, .enable_slot = process_SI, .disable_slot = process_SS, Index: 20090612/drivers/pci/hotplug/ibmphp_core.c =================================================================== --- 20090612.orig/drivers/pci/hotplug/ibmphp_core.c +++ 20090612/drivers/pci/hotplug/ibmphp_core.c @@ -1316,7 +1316,6 @@ error: } struct hotplug_slot_ops ibmphp_hotplug_slot_ops = { - .owner = THIS_MODULE, .set_attention_status = set_attention_status, .enable_slot = enable_slot, .disable_slot = ibmphp_disable_slot, Index: 20090612/drivers/pci/hotplug/rpaphp_core.c =================================================================== --- 20090612.orig/drivers/pci/hotplug/rpaphp_core.c +++ 20090612/drivers/pci/hotplug/rpaphp_core.c @@ -423,7 +423,6 @@ static int disable_slot(struct hotplug_s } struct hotplug_slot_ops rpaphp_hotplug_slot_ops = { - .owner = THIS_MODULE, .enable_slot = enable_slot, .disable_slot = disable_slot, .set_attention_status = set_attention_status, Index: 20090612/drivers/pci/hotplug/sgi_hotplug.c =================================================================== --- 20090612.orig/drivers/pci/hotplug/sgi_hotplug.c +++ 20090612/drivers/pci/hotplug/sgi_hotplug.c @@ -83,7 +83,6 @@ static int disable_slot(struct hotplug_s static inline int get_power_status(struct hotplug_slot *slot, u8 *value); static struct hotplug_slot_ops sn_hotplug_slot_ops = { - .owner = THIS_MODULE, .enable_slot = enable_slot, .disable_slot = disable_slot, .get_power_status = get_power_status, Index: 20090612/drivers/pci/hotplug/acpiphp_core.c =================================================================== --- 20090612.orig/drivers/pci/hotplug/acpiphp_core.c +++ 20090612/drivers/pci/hotplug/acpiphp_core.c @@ -77,7 +77,6 @@ static int get_latch_status (struct hotp static int get_adapter_status (struct hotplug_slot *slot, u8 *value); static struct hotplug_slot_ops acpi_hotplug_slot_ops = { - .owner = THIS_MODULE, .enable_slot = enable_slot, .disable_slot = disable_slot, .set_attention_status = set_attention_status,
The "owner" field in struct hotplug_slot_ops is initialized by PCI hotplug core. So each hotplug controller driver doesn't need to initialize it. Signed-off-by: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com> --- drivers/pci/hotplug/acpiphp_core.c | 1 - drivers/pci/hotplug/cpci_hotplug_core.c | 1 - drivers/pci/hotplug/cpqphp_core.c | 1 - drivers/pci/hotplug/ibmphp_core.c | 1 - drivers/pci/hotplug/pciehp_core.c | 1 - drivers/pci/hotplug/pcihp_skeleton.c | 1 - drivers/pci/hotplug/rpaphp_core.c | 1 - drivers/pci/hotplug/sgi_hotplug.c | 1 - drivers/pci/hotplug/shpchp_core.c | 1 - 9 files changed, 9 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html