From patchwork Sun Oct 11 10:06:05 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yinghai Lu X-Patchwork-Id: 52995 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n9BA9JWh027264 for ; Sun, 11 Oct 2009 10:09:19 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756046AbZJKKH2 (ORCPT ); Sun, 11 Oct 2009 06:07:28 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755587AbZJKKH2 (ORCPT ); Sun, 11 Oct 2009 06:07:28 -0400 Received: from hera.kernel.org ([140.211.167.34]:44006 "EHLO hera.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751831AbZJKKH1 (ORCPT ); Sun, 11 Oct 2009 06:07:27 -0400 Received: from [192.168.101.9] (adsl-75-36-254-77.dsl.pltn13.sbcglobal.net [75.36.254.77]) (authenticated bits=0) by hera.kernel.org (8.14.2/8.13.8) with ESMTP id n9BA6HuR009142 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 11 Oct 2009 10:06:21 GMT Message-ID: <4AD1AE0D.1030007@kernel.org> Date: Sun, 11 Oct 2009 03:06:05 -0700 From: Yinghai Lu User-Agent: Thunderbird 2.0.0.23 (X11/20090817) MIME-Version: 1.0 To: Brad Spengler , Jesse Barnes CC: "linux-kernel@vger.kernel.org" , "linux-pci@vger.kernel.org" , Ingo Molnar Subject: Re: Boot-time crash from "PCI/x86: detect host bridge config space size w/o using quirks" References: <20091011074531.GA12357@grsecurity.net> In-Reply-To: <20091011074531.GA12357@grsecurity.net> X-Virus-Scanned: ClamAV 0.93.3/9881/Sat Oct 10 09:21:35 2009 on hera.kernel.org X-Virus-Status: Clean Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c index 8105e32..4e6a896 100644 --- a/drivers/pci/probe.c +++ b/drivers/pci/probe.c @@ -903,10 +903,6 @@ int pci_cfg_space_size(struct pci_dev *dev) u32 status; u16 class; - class = dev->class >> 8; - if (class == PCI_CLASS_BRIDGE_HOST) - return pci_cfg_space_size_ext(dev); - pos = pci_find_capability(dev, PCI_CAP_ID_EXP); if (!pos) { pos = pci_find_capability(dev, PCI_CAP_ID_PCIX);