From patchwork Tue Dec 1 02:26:40 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yinghai Lu X-Patchwork-Id: 63832 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id nB12RcgU002735 for ; Tue, 1 Dec 2009 02:27:38 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752230AbZLAC1b (ORCPT ); Mon, 30 Nov 2009 21:27:31 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752196AbZLAC1b (ORCPT ); Mon, 30 Nov 2009 21:27:31 -0500 Received: from hera.kernel.org ([140.211.167.34]:39610 "EHLO hera.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751503AbZLAC1a (ORCPT ); Mon, 30 Nov 2009 21:27:30 -0500 Received: from [10.6.76.26] (sca-ea-fw-1.Sun.COM [192.18.43.225]) (authenticated bits=0) by hera.kernel.org (8.14.3/8.14.3) with ESMTP id nB12RVuv012778 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 1 Dec 2009 02:27:34 GMT Message-ID: <4B147EE0.8080209@kernel.org> Date: Mon, 30 Nov 2009 18:26:40 -0800 From: Yinghai Lu User-Agent: Thunderbird 2.0.0.23 (X11/20090817) MIME-Version: 1.0 To: Alex Williamson CC: jbarnes@virtuousgeek.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] PCI: Always set prefetchable base/limit upper32 registers References: <20091130212228.7555.43533.stgit@debian.lart> <4B143AE5.7040702@kernel.org> <1259617381.8949.281.camel@8530w.home> <4B143E83.6020105@kernel.org> <1259618496.8949.290.camel@8530w.home> <4B144346.50608@kernel.org> <1259619578.8949.295.camel@8530w.home> <4B1455FD.90002@kernel.org> <1259625224.8949.319.camel@8530w.home> <4B145C9D.70601@kernel.org> <1259632564.10482.10.camel@2710p.home> In-Reply-To: <1259632564.10482.10.camel@2710p.home> Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org Index: linux-2.6/drivers/pci/setup-bus.c =================================================================== --- linux-2.6.orig/drivers/pci/setup-bus.c +++ linux-2.6/drivers/pci/setup-bus.c @@ -397,10 +397,17 @@ static void pci_bridge_check_ranges(stru pci_write_config_dword(bridge, PCI_PREF_BASE_UPPER32, 0xffffffff); pci_read_config_dword(bridge, PCI_PREF_BASE_UPPER32, &tmp); - if (!tmp) + if (!tmp) { b_res[2].flags &= ~IORESOURCE_MEM_64; - pci_write_config_dword(bridge, PCI_PREF_BASE_UPPER32, - mem_base_hi); + dev_info(&bridge->dev, "%pR MEM_64 clearred\n", &b_res[2]); + /* not sure if we can clear it */ + pci_write_config_dword(bridge, PCI_PREF_BASE_UPPER32, + 0); + pci_write_config_dword(bridge, PCI_PREF_LIMIT_UPPER32, + 0); + } else + pci_write_config_dword(bridge, PCI_PREF_BASE_UPPER32, + mem_base_hi); } }