From patchwork Mon May 17 18:25:14 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Prarit Bhargava X-Patchwork-Id: 100175 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter.kernel.org (8.14.3/8.14.3) with ESMTP id o4HISn0V009586 for ; Mon, 17 May 2010 18:28:49 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753126Ab0EQS2s (ORCPT ); Mon, 17 May 2010 14:28:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33401 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752649Ab0EQS2s (ORCPT ); Mon, 17 May 2010 14:28:48 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o4HISj5E032484 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 17 May 2010 14:28:46 -0400 Received: from prarit.bos.redhat.com (prarit.bos.redhat.com [10.16.16.23]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o4HISja3008967; Mon, 17 May 2010 14:28:45 -0400 Message-ID: <4BF18A0A.3020802@redhat.com> Date: Mon, 17 May 2010 14:25:14 -0400 From: Prarit Bhargava User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.5) Gecko/20091210 Fedora/3.0-4.el6 Thunderbird/3.0 MIME-Version: 1.0 To: Randy Dunlap CC: linux-pci@vger.kernel.org, jbarnes@virtuousgeek.org Subject: Re: [PATCH]: Output FW warning in pci_read/write_vpd References: <20100517175830.17298.84619.sendpatchset@prarit.bos.redhat.com> <20100517110831.387ff3d8.randy.dunlap@oracle.com> In-Reply-To: <20100517110831.387ff3d8.randy.dunlap@oracle.com> X-Scanned-By: MIMEDefang 2.67 on 10.5.11.12 Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.3 (demeter.kernel.org [140.211.167.41]); Mon, 17 May 2010 18:28:49 +0000 (UTC) diff --git a/drivers/pci/access.c b/drivers/pci/access.c index 2f646fe..26e9c19 100644 --- a/drivers/pci/access.c +++ b/drivers/pci/access.c @@ -220,8 +220,13 @@ static int pci_vpd_pci22_wait(struct pci_dev *dev) return 0; } - if (time_after(jiffies, timeout)) + if (time_after(jiffies, timeout)) { + dev_printk(KERN_DEBUG, &dev->dev, + "vpd r/w failed. This is likely a firmware " + "bug on this device. Contact the card " + "vendor for a firmware update."); return -ETIMEDOUT; + } if (fatal_signal_pending(current)) return -EINTR; if (!cond_resched())