From patchwork Thu Jun 17 17:15:10 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Justin P. Mattock" X-Patchwork-Id: 106714 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter.kernel.org (8.14.3/8.14.3) with ESMTP id o5HHErdU018501 for ; Thu, 17 Jun 2010 17:14:54 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760376Ab0FQROx (ORCPT ); Thu, 17 Jun 2010 13:14:53 -0400 Received: from mail-pv0-f174.google.com ([74.125.83.174]:61052 "EHLO mail-pv0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751040Ab0FQROv (ORCPT ); Thu, 17 Jun 2010 13:14:51 -0400 Received: by pvg6 with SMTP id 6so71544pvg.19 for ; Thu, 17 Jun 2010 10:14:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:cc:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=2nkez+fNzkpPoU7f2iNiLbLC2VNNTtpctdxQ3jKvJ/Y=; b=gtv6DdpUN631kisfPDV/xqVF/lOcqHYRUryuLzGArD0mdCW9QujIfqFCG9lzROGstH nlbxXrmViVc3Jd25C45xqrZ1Ta67IFhfb2SmN98AQ98xXXr4gK2Bh5P2K28ZEwn30XdS jID34xk0t3xnn8457cwwaCfRUxwBM0jmqZKHY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; b=v30yXAd31lMMMgTclWS9/QznKaQ3U1skrJO4hy3KX1uz3eV4e/a/T8vWCLJjIp+SfT oSi2qFs7P2XOnoqD1M4yEU6aiyRKLAeez2IVoVAUZgaePQ3tRLz76U/HUTUgWx043jyl b8lW2YZD6vTLUDhq4UCtYsJdRJi3++39jzOLI= Received: by 10.115.21.20 with SMTP id y20mr8525891wai.84.1276794890852; Thu, 17 Jun 2010 10:14:50 -0700 (PDT) Received: from [10.0.0.92] ([76.91.45.220]) by mx.google.com with ESMTPS id c1sm97465235wam.19.2010.06.17.10.14.48 (version=SSLv3 cipher=RC4-MD5); Thu, 17 Jun 2010 10:14:49 -0700 (PDT) Message-ID: <4C1A581E.9050701@gmail.com> Date: Thu, 17 Jun 2010 10:15:10 -0700 From: "Justin P. Mattock" User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.4pre) Gecko/20091114 Lightning/1.0pre Thunderbird/3.0b4 MIME-Version: 1.0 To: Junchang Wang CC: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, linux-pci@vger.kernel.org, linux-scsi@vger.kernel.org Subject: Re: [PATCH 3/5]pci:bus.c Fix variable 'retval' set but not used References: <1276666434-11227-1-git-send-email-justinmattock@gmail.com> <1276666434-11227-4-git-send-email-justinmattock@gmail.com> <20100616060738.GA12461@host-a-229.ustcsz.edu.cn> In-Reply-To: <20100616060738.GA12461@host-a-229.ustcsz.edu.cn> Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.3 (demeter.kernel.org [140.211.167.41]); Thu, 17 Jun 2010 17:14:55 +0000 (UTC) diff --git a/drivers/pci/bus.c b/drivers/pci/bus.c index 628ea20..dba4c28 100644 --- a/drivers/pci/bus.c +++ b/drivers/pci/bus.c @@ -240,6 +240,9 @@ void pci_enable_bridges(struct pci_bus *bus) if (dev->subordinate) { if (!pci_is_enabled(dev)) { retval = pci_enable_device(dev); + if (retval < 0) { + dev_err(&dev->dev, "maybe something here explaining something...\n"); + } pci_set_master(dev); } pci_enable_bridges(dev->subordinate);