From patchwork Fri Jun 18 21:12:41 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Justin P. Mattock" X-Patchwork-Id: 106916 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter.kernel.org (8.14.3/8.14.3) with ESMTP id o5ILCjSt017864 for ; Fri, 18 Jun 2010 21:12:45 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752487Ab0FRVMo (ORCPT ); Fri, 18 Jun 2010 17:12:44 -0400 Received: from mail-pv0-f174.google.com ([74.125.83.174]:53215 "EHLO mail-pv0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752427Ab0FRVMn (ORCPT ); Fri, 18 Jun 2010 17:12:43 -0400 Received: by pvg6 with SMTP id 6so602309pvg.19 for ; Fri, 18 Jun 2010 14:12:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:cc:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=2+tAvEnjp0gcWE4o1rpt4r2AJ7hP/rNjEUFKpsWgllM=; b=VdU0kuEyPrQ8erg9rJgp3NeJDaWFAtBtlDsM/N/pmb1174NTQkUz0yjUCnMfee1+TP YiT6KsRVlri9qlwDE/mHgpVZS/MCXMJH5zRfxKut+hnw8mdMV182HxF7G+qB0A7ykqJi nsMt0Dzujv9VBbErOPOD2g3cGfOuAFi3YybzE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; b=W+hrk6W0Ivrada1GX+lf3YliQBhb1BbGYPUb6r5LYl7MFtSd1mtnEJixw96Ed+ExRs tJZQxEONEClLimFeQSjPh+2EGOzThK2j/Kt3c/Mp6S0tYIbYOSXVZoZYRUGGa/3HEIF7 bzlEjnwmcIr/fitAjDTUZD2DMBCZKxFjnH6f8= Received: by 10.142.66.13 with SMTP id o13mr1154203wfa.72.1276895562547; Fri, 18 Jun 2010 14:12:42 -0700 (PDT) Received: from [10.0.0.92] ([76.91.45.220]) by mx.google.com with ESMTPS id c14sm19571137waa.13.2010.06.18.14.12.40 (version=SSLv3 cipher=RC4-MD5); Fri, 18 Jun 2010 14:12:41 -0700 (PDT) Message-ID: <4C1BE149.9040001@gmail.com> Date: Fri, 18 Jun 2010 14:12:41 -0700 From: "Justin P. Mattock" User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.4pre) Gecko/20091114 Lightning/1.0pre Thunderbird/3.0b4 MIME-Version: 1.0 To: Jesse Barnes CC: Yinghai Lu , linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, linux-pci@vger.kernel.org, linux-scsi@vger.kernel.org Subject: Re: [PATCH 4/5]pci:setup_bus.c Fix warning: variable 'retval' set but not used References: <1276666434-11227-1-git-send-email-justinmattock@gmail.com> <1276666434-11227-5-git-send-email-justinmattock@gmail.com> <20100618102330.29eccb5b@virtuousgeek.org> <4C1BBF7D.8090904@kernel.org> <20100618124956.40c869a0@virtuousgeek.org> <4C1BD024.1030707@gmail.com> <20100618130538.0fc562ee@virtuousgeek.org> <4C1BD678.1020405@gmail.com> <20100618134622.7db9f913@virtuousgeek.org> In-Reply-To: <20100618134622.7db9f913@virtuousgeek.org> Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.3 (demeter.kernel.org [140.211.167.41]); Fri, 18 Jun 2010 21:12:45 +0000 (UTC) diff --git a/drivers/pci/setup-bus.c b/drivers/pci/setup-bus.c index 66cb8f4..2ab5f1e 100644 --- a/drivers/pci/setup-bus.c +++ b/drivers/pci/setup-bus.c @@ -919,6 +919,9 @@ again: enable_all: retval = pci_reenable_device(bridge); + if (retval) { + dev_err(&bridge->dev, "failed to re-enable device: %d\n", retval); + } pci_set_master(bridge); pci_enable_bridges(parent); }