From patchwork Sat May 14 02:03:48 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yinghai Lu X-Patchwork-Id: 784652 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id p4E244MI025389 for ; Sat, 14 May 2011 02:04:04 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756069Ab1ENCED (ORCPT ); Fri, 13 May 2011 22:04:03 -0400 Received: from rcsinet10.oracle.com ([148.87.113.121]:24551 "EHLO rcsinet10.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755794Ab1ENCEC (ORCPT ); Fri, 13 May 2011 22:04:02 -0400 Received: from rtcsinet22.oracle.com (rtcsinet22.oracle.com [66.248.204.30]) by rcsinet10.oracle.com (Switch-3.4.2/Switch-3.4.2) with ESMTP id p4E23uW5009238 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 14 May 2011 02:03:57 GMT Received: from acsmt358.oracle.com (acsmt358.oracle.com [141.146.40.158]) by rtcsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id p4E23sKm029167 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 14 May 2011 02:03:55 GMT Received: from abhmt014.oracle.com (abhmt014.oracle.com [141.146.116.23]) by acsmt358.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id p4E23mgU008820; Fri, 13 May 2011 21:03:48 -0500 Received: from linux-siqj.site (/75.36.244.210) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 13 May 2011 19:03:47 -0700 Message-ID: <4DCDE304.50801@kernel.org> Date: Fri, 13 May 2011 19:03:48 -0700 From: Yinghai Lu User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110414 SUSE/3.1.10 Thunderbird/3.1.10 MIME-Version: 1.0 To: Greg KH CC: Alex Chiang , Jesse Barnes , "linux-pci@vger.kernel.org" Subject: Re: [PATCH 2/3] pci: Kill rescan under /sys/.../pci/devices/... References: <4DBF35CB.5010600@kernel.org> <4DBF3AEA.6090500@kernel.org> <20110509135434.3990e58b@jbarnes-desktop> <20110513090508.GD22012@canonical.com> <20110513144355.GA13103@kroah.com> <20110513160413.GA32328@canonical.com> <20110513185940.GC4303@kroah.com> In-Reply-To: <20110513185940.GC4303@kroah.com> X-Source-IP: rtcsinet22.oracle.com [66.248.204.30] X-CT-RefId: str=0001.0A090204.4DCDE30E.005A,ss=1,fgs=0 Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Sat, 14 May 2011 02:04:04 +0000 (UTC) On 05/13/2011 11:59 AM, Greg KH wrote: > On Fri, May 13, 2011 at 10:04:15AM -0600, Alex Chiang wrote: >> * Greg KH : >>> On Fri, May 13, 2011 at 03:05:08AM -0600, Alex Chiang wrote: >>>> * Jesse Barnes : >>>>> Yinghai Lu wrote: >>>>>> >>>>>> So remove rescan for all pci devices. less confusing >>>>> >>>>> I'm reluctant to break an existing interface like this, even though >>>>> it's only in the "testing" section of the ABI. >>>>> >>>>> Alex, any comments? >>>> >>>> I think standard ABI deprecation practices should apply here. >>> >>> Ooh, I missed the fact that this series removed a sysfs file, you are >>> right, we can't do that. >>> >>> So no, don't delete this file, please fix any tools that might happen to >>> be using it, and then, in a year or so, we can revisit this to see if it >>> makes sense to remove it. >> >> I thought we had some "best practices" to do that, like printing >> out a big scary deprecation message when the file is accessed, >> and documenting it in Documentation/ABI somewhere. > > Printing out such a message would be good, that would allow you to catch > the tools that are doing it and change them. > > Documenting that the file is going away is for the > Documentation/feature_removal.txt file, not the ABI files. > > So that all sounds like a good idea. thought if it is with testing, we can remove it if need to. or like this ? --- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/Documentation/feature-removal-schedule.txt b/Documentation/feature-removal-schedule.txt index 4a9879b..2811a42 100644 --- a/Documentation/feature-removal-schedule.txt +++ b/Documentation/feature-removal-schedule.txt @@ -559,3 +559,14 @@ Why: These legacy callbacks should no longer be used as i2c-core offers Who: Jean Delvare ---------------------------- + +What: rescan in /sys/bus/pci/devices/.../ +When: June 2012 +Why: That is not right. the device is already there, there is no reason to rescan it. + We can not get increase resource for them. + Now We already have rescan for pci_bus. + So remove rescan for all pci devices. less confusing + Finally We remove devices, and rescan bus that there were on before. +Who: Yinghai Lu + +---------------------------