| Message ID | 7ea7f7d342f97c758949a17b870012f52ce5b3f5.1600767645.git.gustavo.pimentel@synopsys.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Lorenzo Pieralisi |
| Headers | show |
| Series | [-next] PCI: DWC: Fix cast truncates bits from constant value | expand |
[+cc Lorenzo] On Tue, Sep 22, 2020 at 11:59:10AM +0200, Gustavo Pimentel wrote: > Fixes warning given by executing "make C=2 drivers/pci/" > > Sparse output: > CHECK drivers/pci/controller/dwc/pcie-designware.c > drivers/pci/controller/dwc/pcie-designware.c:432:52: warning: > cast truncates bits from constant value (ffffffff7fffffff becomes > 7fffffff) > > Reported-by: Bjorn Helgaas <bhelgaas@google.com> > Cc: Joao Pinto <jpinto@synopsys.com> > Signed-off-by: Gustavo Pimentel <gustavo.pimentel@synopsys.com> Looks good to me; thanks for persevering with this. Hopefully Lorenzo will apply this and, in the process, adjust the subject line to match the history: PCI: dwc: ... > --- > drivers/pci/controller/dwc/pcie-designware.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/controller/dwc/pcie-designware.c b/drivers/pci/controller/dwc/pcie-designware.c > index 3c3a4d1..e7a41d9 100644 > --- a/drivers/pci/controller/dwc/pcie-designware.c > +++ b/drivers/pci/controller/dwc/pcie-designware.c > @@ -429,7 +429,7 @@ void dw_pcie_disable_atu(struct dw_pcie *pci, int index, > } > > dw_pcie_writel_dbi(pci, PCIE_ATU_VIEWPORT, region | index); > - dw_pcie_writel_dbi(pci, PCIE_ATU_CR2, (u32)~PCIE_ATU_ENABLE); > + dw_pcie_writel_dbi(pci, PCIE_ATU_CR2, ~(u32)PCIE_ATU_ENABLE); > } > > int dw_pcie_wait_for_link(struct dw_pcie *pci) > -- > 2.7.4 >
On Tue, Sep 22, 2020 at 11:57:55AM -0500, Bjorn Helgaas wrote: > [+cc Lorenzo] > > On Tue, Sep 22, 2020 at 11:59:10AM +0200, Gustavo Pimentel wrote: > > Fixes warning given by executing "make C=2 drivers/pci/" > > > > Sparse output: > > CHECK drivers/pci/controller/dwc/pcie-designware.c > > drivers/pci/controller/dwc/pcie-designware.c:432:52: warning: > > cast truncates bits from constant value (ffffffff7fffffff becomes > > 7fffffff) > > > > Reported-by: Bjorn Helgaas <bhelgaas@google.com> > > Cc: Joao Pinto <jpinto@synopsys.com> > > Signed-off-by: Gustavo Pimentel <gustavo.pimentel@synopsys.com> > > Looks good to me; thanks for persevering with this. > > Hopefully Lorenzo will apply this and, in the process, adjust the > subject line to match the history: > > PCI: dwc: ... Done, applied to pci/dwc, thanks. Lorenzo > > drivers/pci/controller/dwc/pcie-designware.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/pci/controller/dwc/pcie-designware.c b/drivers/pci/controller/dwc/pcie-designware.c > > index 3c3a4d1..e7a41d9 100644 > > --- a/drivers/pci/controller/dwc/pcie-designware.c > > +++ b/drivers/pci/controller/dwc/pcie-designware.c > > @@ -429,7 +429,7 @@ void dw_pcie_disable_atu(struct dw_pcie *pci, int index, > > } > > > > dw_pcie_writel_dbi(pci, PCIE_ATU_VIEWPORT, region | index); > > - dw_pcie_writel_dbi(pci, PCIE_ATU_CR2, (u32)~PCIE_ATU_ENABLE); > > + dw_pcie_writel_dbi(pci, PCIE_ATU_CR2, ~(u32)PCIE_ATU_ENABLE); > > } > > > > int dw_pcie_wait_for_link(struct dw_pcie *pci) > > -- > > 2.7.4 > >
diff --git a/drivers/pci/controller/dwc/pcie-designware.c b/drivers/pci/controller/dwc/pcie-designware.c index 3c3a4d1..e7a41d9 100644 --- a/drivers/pci/controller/dwc/pcie-designware.c +++ b/drivers/pci/controller/dwc/pcie-designware.c @@ -429,7 +429,7 @@ void dw_pcie_disable_atu(struct dw_pcie *pci, int index, } dw_pcie_writel_dbi(pci, PCIE_ATU_VIEWPORT, region | index); - dw_pcie_writel_dbi(pci, PCIE_ATU_CR2, (u32)~PCIE_ATU_ENABLE); + dw_pcie_writel_dbi(pci, PCIE_ATU_CR2, ~(u32)PCIE_ATU_ENABLE); } int dw_pcie_wait_for_link(struct dw_pcie *pci)
Fixes warning given by executing "make C=2 drivers/pci/" Sparse output: CHECK drivers/pci/controller/dwc/pcie-designware.c drivers/pci/controller/dwc/pcie-designware.c:432:52: warning: cast truncates bits from constant value (ffffffff7fffffff becomes 7fffffff) Reported-by: Bjorn Helgaas <bhelgaas@google.com> Cc: Joao Pinto <jpinto@synopsys.com> Signed-off-by: Gustavo Pimentel <gustavo.pimentel@synopsys.com> --- drivers/pci/controller/dwc/pcie-designware.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)