From patchwork Mon Mar 19 22:32:14 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Michael Ellerman X-Patchwork-Id: 10295693 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 6345860385 for ; Mon, 19 Mar 2018 22:36:06 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4D7EA2931A for ; Mon, 19 Mar 2018 22:36:06 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4214A29516; Mon, 19 Mar 2018 22:36:06 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 821682931A for ; Mon, 19 Mar 2018 22:36:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933693AbeCSWgD convert rfc822-to-8bit (ORCPT ); Mon, 19 Mar 2018 18:36:03 -0400 Received: from ozlabs.org ([103.22.144.67]:60773 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936569AbeCSWcS (ORCPT ); Mon, 19 Mar 2018 18:32:18 -0400 Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPSA id 404rR402tsz9sWB; Tue, 20 Mar 2018 09:32:15 +1100 (AEDT) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au From: Michael Ellerman To: Bjorn Helgaas , Christian Zigotzky Cc: Bjorn Helgaas , linux-pci@vger.kernel.org, Olof Johansson , linuxppc-dev Subject: Re: [PATCH 1/1] PCI set flag PCI_SCAN_ALL_PCIE_DEVS for P.A. Semi boards In-Reply-To: <20180319191310.GG77194@bhelgaas-glaptop.roam.corp.google.com> References: <4cfe3cc0-7fe3-9774-7d20-1b7fcb7aa910@xenosoft.de> <28b43e1a-3643-9edb-7123-be1cb0dc846a@xenosoft.de> <527175f7-8a13-37a1-9f0a-0b918aeebd64@xenosoft.de> <20171130224243.GB19640@bhelgaas-glaptop.roam.corp.google.com> <406ba7c4-7305-4069-227f-81afed202e47@xenosoft.de> <20171201232716.GA18780@bhelgaas-glaptop.roam.corp.google.com> <639e975f-1b3a-4f85-9a40-13fe2473fc28@xenosoft.de> <20180319191310.GG77194@bhelgaas-glaptop.roam.corp.google.com> Date: Tue, 20 Mar 2018 09:32:14 +1100 Message-ID: <87tvtbg0i9.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Bjorn Helgaas writes: > On Fri, Mar 16, 2018 at 01:55:36PM +0100, Christian Zigotzky wrote: >> Bjorn Helgaas created a patch for making PCI_SCAN_ALL_PCIE_DEVS work for >> Root Ports as well as Downstream. Previously PCI_SCAN_ALL_PCIE_DEVS (set by >> quirks or the "pci=pcie_scan_all" >> kernel parameter) only affected Switch Downstream Ports, not Root Ports. The >> problem is, that we have to add always the boot argument "pci=pcie_scan_all" >> for using Bjorn's improvements. Without the boot argument >> "pci=pcie_scan_all", the kernel doesn't boot on P.A. Semi boards with SB600 >> chipset (SB600 chipset is connected via PCIe x4 to the P.A. Semi’s >> PA6T-1682M System-on-a-Chip) because the kernel can't find any drives >> connected to the SB600 anymore. Olof Johansson has created a patch for >> executing "pci=pcie_scan_all" automatically on P.A. Semi boards. With his >> patch, we don't need to add 'pci=pcie_scan_all' to the kernel boot arguments >> anymore. > > The patch looks fine, but I need a signed-off-by line before I can apply > it. See https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst I'm happy to take it, I've been meaning to check if Olof sent a SOB in his original mail but haven't got to it. ... Yes, he did, see below. So I'll merge that, I'll add a Tested-by for you Christian. Christian please don't remove any of the tags when submitting other peoples' patches in future. cheers From a3b390277627b0342c8ccfc16e58679e0d8abdde Mon Sep 17 00:00:00 2001 From: Olof Johansson Date: Sat, 2 Dec 2017 14:56:36 -0800 Subject: [PATCH] powerpc/pasemi: set PCI_SCAN_ALL_PCI_DEVS Needed on Amiga X1000 with SB600. Reported-by: Christian Zigotzky Cc: Bjorn Helgaas Signed-off-by: Olof Johansson --- arch/powerpc/platforms/pasemi/pci.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/powerpc/platforms/pasemi/pci.c b/arch/powerpc/platforms/pasemi/pci.c index 5ff6108..ea54ed2 100644 --- a/arch/powerpc/platforms/pasemi/pci.c +++ b/arch/powerpc/platforms/pasemi/pci.c @@ -224,6 +224,8 @@ void __init pas_pci_init(void) return; } + pci_set_flag(PCI_SCAN_ALL_PCIE_DEVS): + for (np = NULL; (np = of_get_next_child(root, np)) != NULL;) if (np->name && !strcmp(np->name, "pxp") && !pas_add_bridge(np)) of_node_get(np);