From patchwork Fri Jul 11 00:44:07 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Tanmay Inamdar X-Patchwork-Id: 4529201 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: X-Original-To: patchwork-linux-pci@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 1ADADBEEAA for ; Fri, 11 Jul 2014 00:44:28 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 5F90B201F2 for ; Fri, 11 Jul 2014 00:44:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 56BE3201C0 for ; Fri, 11 Jul 2014 00:44:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751314AbaGKAoK (ORCPT ); Thu, 10 Jul 2014 20:44:10 -0400 Received: from exprod5og112.obsmtp.com ([64.18.0.24]:43007 "HELO exprod5og112.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1750927AbaGKAoJ convert rfc822-to-8bit (ORCPT ); Thu, 10 Jul 2014 20:44:09 -0400 Received: from mail-vc0-f173.google.com ([209.85.220.173]) (using TLSv1) by exprod5ob112.postini.com ([64.18.4.12]) with SMTP ID DSNKU78zWE4CqafuotOl1qFJn54X+AC4U1ru@postini.com; Thu, 10 Jul 2014 17:44:09 PDT Received: by mail-vc0-f173.google.com with SMTP id lf12so711414vcb.32 for ; Thu, 10 Jul 2014 17:44:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=QkoQ9W2lht/dc9rAlRU+tHKtn26O+i+arCwzy4h9f3U=; b=mhHXHXZ8fCd0ok0g6VSchMgMOTDCm5xX3PryJrhSGqIrxmkwHbT2XFuBKvOHJARh/8 7CDh1hUqqLjCh2/BtR/4VyDxiJVvYzoMZP+TZie5ZcSSpeiuAQqsbqmhTCG7cjt+OjGw MIQlrz39T42VP2IBFwNUce0iQkSdl+Hbf+SdcY2pD47UUMPmDGh1JSL5emNzqPF9QkGA SIrohMaziEixzrKcbJWBItmM2V7g5tvkKiYlcAN/fUkbqaCkLIwpaMCnsx6k1yp6u52x 1h8L2xgv/NFjBf6XhnOO1Wa11vliAP4uvaQhQFgVyQF6EPG1Rh3oIxG0Z9DRkdwdGrek ZwlA== X-Gm-Message-State: ALoCoQkzJ57fv/h5RiMrJ3BklYozfLSlynkXEuigno1nsKi8oZ2vXTk20P3zYBykazUOPZqFEubSXnjgGCg6LOYS3I1/uXmAOlCr0udCQFAhUoBZD7IFFAtKlXHtmkscoUeh7D4/GvWX X-Received: by 10.58.165.106 with SMTP id yx10mr49739575veb.17.1405039448180; Thu, 10 Jul 2014 17:44:08 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.58.165.106 with SMTP id yx10mr49739551veb.17.1405039447899; Thu, 10 Jul 2014 17:44:07 -0700 (PDT) Received: by 10.58.195.194 with HTTP; Thu, 10 Jul 2014 17:44:07 -0700 (PDT) In-Reply-To: <20140708171828.GM6501@e106497-lin.cambridge.arm.com> References: <1404240214-9804-1-git-send-email-Liviu.Dudau@arm.com> <20140708171828.GM6501@e106497-lin.cambridge.arm.com> Date: Thu, 10 Jul 2014 17:44:07 -0700 Message-ID: Subject: Re: [PATCH v8 0/9] Support for creating generic PCI host bridges from DT From: Tanmay Inamdar To: Liviu Dudau Cc: Rob Herring , linux-pci , Bjorn Helgaas , Catalin Marinas , Will Deacon , Benjamin Herrenschmidt , Arnd Bergmann , linaro-kernel , Grant Likely , Sinan Kaya , Jingoo Han , Kukjin Kim , Suravee Suthikulanit , Device Tree ML , LKML , LAKML Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi, On Tue, Jul 8, 2014 at 10:18 AM, Liviu Dudau wrote: > On Sun, Jul 06, 2014 at 04:23:43PM +0100, Rob Herring wrote: >> On Tue, Jul 1, 2014 at 1:43 PM, Liviu Dudau wrote: >> > This is my resurected attempt at adding support for generic PCI host >> > bridge controllers that make use of device tree information to >> > configure themselves. I've tagged it as v8 although the patches >> > have now been reshuffled in order to ease adoption so referring to >> > the older versions might be a bit of a hoop jumping exercise. >> > >> > Changes from v7: >> > - Reordered the patches so that fixes and non-controversial patches >> > from v7 can be accepted more easily. If agreed I can split the >> > series again into patches that can be upstreamed easily and ones >> > that still need discussion. >> > - Moved the of_create_host_bridge() function to drivers/of/of_pci.c >> > to better reflect its target use. >> > - Added the function to remap the bus I/O resources that used to be >> > provided in my arm64 patch series and (re)named it pci_remap_iospace() >> > - Removed error code checking from parsing and mapping of IRQ from DT >> > in recognition that some PCI devices will not have legacy IRQ mappings. >> > >> > v7 thread here with all the historic information: https://lkml.org/lkml/2014/3/14/279 >> >> Can you publish a branch for this series please. >> >> Rob >> > > Hi Rob, > > I have pushed a brach that matches my v8 patchset +1 obvious missing header include > here: http://www.linux-arm.org/git?p=linux-ld.git;a=shortlog;h=refs/heads/for-upstream/pci_v8 > I was still getting following compilation error after applying arm64 pci headers. Please let me know if I am missing something. linux-git/drivers/of/of_pci.c: In function ‘pci_host_bridge_of_get_ranges’: linux-git/drivers/of/of_pci.c:114:22: error: storage size of ‘range’ isn’t known struct of_pci_range range; ^ linux-git/drivers/of/of_pci.c:115:29: error: storage size of ‘parser’ isn’t known struct of_pci_range_parser parser; ^ linux-git/drivers/of/of_pci.c:121:2: error: implicit declaration of function ‘of_pci_range_parser_init’ [-Werror=implicit-function-declaration] err = of_pci_range_parser_init(&parser, dev); Below patch fixes the errors. > Best regards, > Liviu > > > -- > ==================== > | I would like to | > | fix the world, | > | but they're not | > | giving me the | > \ source code! / > --------------- > ¯\_(?)_/¯ > --- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/of/of_pci.c b/drivers/of/of_pci.c index 55d8320..da88dac 100644 --- a/drivers/of/of_pci.c +++ b/drivers/of/of_pci.c @@ -2,6 +2,7 @@ #include #include #include +#include static inline int __of_pci_pci_compare(struct device_node *node, unsigned int data)