From patchwork Mon Jul 14 05:01:53 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 4542521 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: X-Original-To: patchwork-linux-pci@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 1B3E79F295 for ; Mon, 14 Jul 2014 05:02:07 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 35F3F2014A for ; Mon, 14 Jul 2014 05:02:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 69CD120131 for ; Mon, 14 Jul 2014 05:02:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750974AbaGNFCC (ORCPT ); Mon, 14 Jul 2014 01:02:02 -0400 Received: from mail-oa0-f48.google.com ([209.85.219.48]:36305 "EHLO mail-oa0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752655AbaGNFBy (ORCPT ); Mon, 14 Jul 2014 01:01:54 -0400 Received: by mail-oa0-f48.google.com with SMTP id m1so3640311oag.21 for ; Sun, 13 Jul 2014 22:01:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=Rq5CcNLRhxSbgD/A93XDtKi3qbC76nH91P1xYOVpCfQ=; b=DejhiYz1WZt+fOIt6eiJgyl5d0iTci53oyhd/Avn9obkgkL8ChlQI71XMoFOVJzo4J Ea2JHPmkIfY3gmHAUh8DPBqc2SHpzbT0furYBQOXdaWvhRHN9/7LZmhBUfnsjB0MKTd7 SNHzqoywrBzv6mzD7+YjZnWDC4k7UgsX16VuJQz7cPkWl5sPLxaL7h+x66fhkhYa9+YY azdp8XxaUhzwPWFm/GxK9EbT5tWQPNToYBNdHw/WXJmWymjeUuzCRuRG27usFekLt6oV QjAj0L9F+1Z0vLDzoaYxZ712ctK3ht9G/XWiMP1+9U33cjNpVMi3QVHPFaqV5xh1iutr 54VA== X-Gm-Message-State: ALoCoQmJ4UHsoP5kNn071yCSmKxcvQoKh51937ywquSuYIbWr4u/VRotQnjvsWlsR/LnBvZBN6fr MIME-Version: 1.0 X-Received: by 10.60.23.65 with SMTP id k1mr12107827oef.20.1405314113783; Sun, 13 Jul 2014 22:01:53 -0700 (PDT) Received: by 10.182.233.166 with HTTP; Sun, 13 Jul 2014 22:01:53 -0700 (PDT) In-Reply-To: <20140710213937.GB15190@google.com> References: <9430e4b284928e4919297de5602e803d03f82d7b.1404976058.git.viresh.kumar@linaro.org> <20140710213937.GB15190@google.com> Date: Mon, 14 Jul 2014 10:31:53 +0530 Message-ID: Subject: Re: [PATCH V9 1/7] pcie: Add designware wrapper driver for SPEAr13xx From: Viresh Kumar To: Bjorn Helgaas Cc: Arnd Bergmann , "olof@lixom.net" , "linux-arm-kernel@lists.infradead.org" , spear-devel , Bartlomiej Zolnierkiewicz , Mark Nicholson , "linux-pci@vger.kernel.org" , Pratyush Anand , Mohit Kumar Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 11 July 2014 03:09, Bjorn Helgaas wrote: > I guess I'm obsessive, but I think it's nice when people run > "git log --oneline" on the file or directory they're changing, > and then follow the existing style. > > In this case, that would lead to a subject line like: > > PCI: spear: Add PCIe driver for ST Microelectronics SPEAr13xx > >> diff --git a/MAINTAINERS b/MAINTAINERS >> index 702ca10..443dd05 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -6820,6 +6820,12 @@ S: Maintained >> F: Documentation/devicetree/bindings/pci/host-generic-pci.txt >> F: drivers/pci/host/pci-host-generic.c >> >> +PCIE DRIVER FOR ST SPEAR13XX >> +M: Mohit Kumar >> +L: linux-pci@vger.kernel.org >> +S: Maintained >> +F: drivers/pci/host/pcie-spear13xx.c > > Wildcards work here, so you could follow the lead of IMX6, MVEBU, RCAR, > and DESIGNWARE and use: > > F: drivers/pci/host/*spear* > >> --- /dev/null >> +++ b/drivers/pci/host/pcie-spear13xx.c >> ... >> +#define PCI_CAP_ID_EXP_OFFSET 0x70 > > A nit, but I'd use a name like EXP_CAP_ID_OFFSET to make it > more clear that this is specific to SPEAr, not something from > the PCI specs. Hi Bjorn, So this is how the diff looks like over this patch: dev_err(pp->dev, "link already up\n"); And the subject looks like this now: PCI: spear: Add PCIe driver for ST Microelectronics SPEAr13xx I may skip sending a V10 for this and directly send a pull request as there aren't any significant changes suggested in V9. Thanks. --- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/MAINTAINERS b/MAINTAINERS index 443dd05..766948e 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -6824,7 +6824,7 @@ PCIE DRIVER FOR ST SPEAR13XX M: Mohit Kumar L: linux-pci@vger.kernel.org S: Maintained -F: drivers/pci/host/pcie-spear13xx.c +F: drivers/pci/host/*spear* PCMCIA SUBSYSTEM P: Linux PCMCIA Team diff --git a/drivers/pci/host/pcie-spear13xx.c b/drivers/pci/host/pcie-spear13xx.c index a6fc332..99738e4 100644 --- a/drivers/pci/host/pcie-spear13xx.c +++ b/drivers/pci/host/pcie-spear13xx.c @@ -139,7 +139,7 @@ struct pcie_app_reg { #define VEN_MSI_TC_MASK ((u32)0x7 << VEN_MSI_TC_ID) #define VEN_MSI_VECTOR_MASK ((u32)0x1F << VEN_MSI_VECTOR_ID) -#define PCI_CAP_ID_EXP_OFFSET 0x70 +#define EXP_CAP_ID_OFFSET 0x70 #define to_spear13xx_pcie(x) container_of(x, struct spear13xx_pcie, pp) @@ -149,7 +149,7 @@ static int spear13xx_pcie_establish_link(struct pcie_port *pp) int count = 0; struct spear13xx_pcie *spear13xx_pcie = to_spear13xx_pcie(pp); struct pcie_app_reg *app_reg = spear13xx_pcie->app_base; - u32 exp_cap_off = PCI_CAP_ID_EXP_OFFSET; + u32 exp_cap_off = EXP_CAP_ID_OFFSET; if (dw_pcie_link_up(pp)) {