From patchwork Sun Jul 20 11:59:48 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 4590751 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: X-Original-To: patchwork-linux-pci@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 1BFD79F295 for ; Sun, 20 Jul 2014 12:00:14 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 3AAFC20154 for ; Sun, 20 Jul 2014 12:00:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 318702013D for ; Sun, 20 Jul 2014 12:00:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752085AbaGTMAL (ORCPT ); Sun, 20 Jul 2014 08:00:11 -0400 Received: from mail-pa0-f54.google.com ([209.85.220.54]:52941 "EHLO mail-pa0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752008AbaGTMAK (ORCPT ); Sun, 20 Jul 2014 08:00:10 -0400 Received: by mail-pa0-f54.google.com with SMTP id fa1so8013337pad.41 for ; Sun, 20 Jul 2014 05:00:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=DRF8JgumIoeY5DUErnTFtTg55ZyEstGE4QUEV+L1lqw=; b=VouaZAh0zjS58OzBPzKjznwg7qYXSWZqVuWo+tr00T9SlqNka8CGHw2ISPXM+kuWrO Iab9GEmtdWlF2LUjYzXPUD4T/PFsYPdao9YELrcU/LW7XMpNb+MBa2BdMzNcBpDjZnBU IQkZMrxE7siIlEnQ5zH0y+zBmcpXyTA68ORc7TExZ5LL5Pu1T0kjHkz+hUwy99/VwUde uKkMaTBH17XVkdyEVaZ7ynmrE2zUAS3jua5i+REOqk6VWSiUuHYCDQ1geSBy6qwO1FxA k/k+x74kUw9T1P38hTzhISjANb4YER0KRNkdASVgLPp++KTyGJRj2fH/2vhR7zaTWNRf hafg== X-Gm-Message-State: ALoCoQmdG5cL/cwG2pm5Iz8uuTZCNLKPjByjBU4ytLcEgcoeyDsDbO2TWs7JmFFXKCIcdlqBaoDi X-Received: by 10.68.194.202 with SMTP id hy10mr7208433pbc.94.1405857609652; Sun, 20 Jul 2014 05:00:09 -0700 (PDT) Received: from localhost ([122.172.242.64]) by mx.google.com with ESMTPSA id qw8sm5089875pab.17.2014.07.20.05.00.05 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sun, 20 Jul 2014 05:00:09 -0700 (PDT) From: Viresh Kumar To: arnd@linaro.org, olof@lixom.net, arm@kernel.org Cc: linux-arm-kernel@lists.infradead.org, spear-devel@list.st.com, bhelgaas@google.com, linux-pci@vger.kernel.org, mohit.kumar@st.com, pratyush.anand@st.com, Viresh Kumar Subject: [PATCH 2/2] PCI: spear: Remove spear13xx_pcie_remove() Date: Sun, 20 Jul 2014 17:29:48 +0530 Message-Id: X-Mailer: git-send-email 2.0.0.rc2 In-Reply-To: <76576b662613369d0c71db30ceed4ed5ae1343d2.1405857442.git.viresh.kumar@linaro.org> References: <76576b662613369d0c71db30ceed4ed5ae1343d2.1405857442.git.viresh.kumar@linaro.org> In-Reply-To: <76576b662613369d0c71db30ceed4ed5ae1343d2.1405857442.git.viresh.kumar@linaro.org> References: <76576b662613369d0c71db30ceed4ed5ae1343d2.1405857442.git.viresh.kumar@linaro.org> Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Following compilation warning occurs when compiled with: CONFIG_DEBUG_SECTION_MISMATCH=y WARNING: vmlinux.o(.init.data+0x3338): Section mismatch in reference from the variable spear13xx_pcie_driver to the function .exit.text:spear13xx_pcie_remove() This driver isn't allowed to unload, and so doesn't have a *_exit() routine. But it still has spear13xx_pcie_remove() marked with __exit. As this driver can't unload, .remove() would never be called, right? So get rid of it. Fixes: 51b66a6 (PCI: spear: Add PCIe driver for ST Microelectronics SPEAr13xx) Signed-off-by: Viresh Kumar --- drivers/pci/host/pcie-spear13xx.c | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/drivers/pci/host/pcie-spear13xx.c b/drivers/pci/host/pcie-spear13xx.c index 67315ea..6dea9e4 100644 --- a/drivers/pci/host/pcie-spear13xx.c +++ b/drivers/pci/host/pcie-spear13xx.c @@ -365,17 +365,6 @@ static int __init spear13xx_pcie_probe(struct platform_device *pdev) return ret; } -static int __exit spear13xx_pcie_remove(struct platform_device *pdev) -{ - struct spear13xx_pcie *spear13xx_pcie = platform_get_drvdata(pdev); - - clk_disable_unprepare(spear13xx_pcie->clk); - - phy_exit(spear13xx_pcie->phy); - - return 0; -} - static const struct of_device_id spear13xx_pcie_of_match[] = { { .compatible = "st,spear1340-pcie", }, {}, @@ -384,7 +373,6 @@ MODULE_DEVICE_TABLE(of, spear13xx_pcie_of_match); static struct platform_driver spear13xx_pcie_driver __initdata = { .probe = spear13xx_pcie_probe, - .remove = spear13xx_pcie_remove, .driver = { .name = "spear-pcie", .owner = THIS_MODULE,