From patchwork Tue Oct 17 12:28:39 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Gleixner X-Patchwork-Id: 10011869 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id D4CEA601E7 for ; Tue, 17 Oct 2017 12:29:12 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C8B5C28857 for ; Tue, 17 Oct 2017 12:29:12 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id BA89F28883; Tue, 17 Oct 2017 12:29:12 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 52AB028857 for ; Tue, 17 Oct 2017 12:29:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761718AbdJQM2q (ORCPT ); Tue, 17 Oct 2017 08:28:46 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:57208 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761712AbdJQM2o (ORCPT ); Tue, 17 Oct 2017 08:28:44 -0400 Received: from hsi-kbw-5-158-153-52.hsi19.kabel-badenwuerttemberg.de ([5.158.153.52] helo=nanos) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1e4Qyv-000426-B0; Tue, 17 Oct 2017 14:28:25 +0200 Date: Tue, 17 Oct 2017 14:28:39 +0200 (CEST) From: Thomas Gleixner To: LKML cc: Dexuan Cui , x86@kernel.org, Bjorn Helgaas , Marc Zyngier , KY Srinivasan , Stephen Hemminger , linux-pci@vger.kernel.org, devel@linuxdriverproject.org, Josh Poulson , Haiyang Zhang , Simon Xiao , Saeed Mahameed , Mihai Costache , Jork Loeser Subject: Re: [patch 2/3] PCI/MSI: Set MSI_FLAG_MUST_REACTIVATE in core code In-Reply-To: <20171017075600.448649905@linutronix.de> Message-ID: References: <20171017075456.694047687@linutronix.de> <20171017075600.448649905@linutronix.de> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Tue, 17 Oct 2017, Thomas Gleixner wrote: > If interrupt reservation mode is enabled then the PCI/MSI interrupts must > be reactivated after early activation. > > Make sure that all callers of pci_msi_create_irq_domain() have the > MSI_FLAG_MUST_REACTIVATE set when reservation mode is enabled. > > Signed-off-by: Thomas Gleixner > --- > drivers/pci/msi.c | 2 ++ > 1 file changed, 2 insertions(+) > > --- a/drivers/pci/msi.c > +++ b/drivers/pci/msi.c > @@ -1441,6 +1441,8 @@ struct irq_domain *pci_msi_create_irq_do > pci_msi_domain_update_chip_ops(info); > > info->flags |= MSI_FLAG_ACTIVATE_EARLY; > + if (IS_ENABLED(CONFIG_GENERIC_IRQ_RESERVATION)) Bah. quilt refresh seems overrated. Correct patch below. Thanks, tglx 8<---------------- --- a/drivers/pci/msi.c +++ b/drivers/pci/msi.c @@ -1441,6 +1441,8 @@ struct irq_domain *pci_msi_create_irq_do pci_msi_domain_update_chip_ops(info); info->flags |= MSI_FLAG_ACTIVATE_EARLY; + if (IS_ENABLED(CONFIG_GENERIC_IRQ_RESERVATION_MODE)) + info->flags |= MSI_FLAG_MUST_REACTIVATE; domain = msi_create_irq_domain(fwnode, info, parent); if (!domain)