From patchwork Thu Sep 29 14:28:23 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sinan Kaya X-Patchwork-Id: 9356465 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 4E13C6077A for ; Thu, 29 Sep 2016 14:28:33 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3FE4F29AD3 for ; Thu, 29 Sep 2016 14:28:33 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3485E29ADA; Thu, 29 Sep 2016 14:28:33 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, T_TVD_MIME_EPI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E22CC29AD4 for ; Thu, 29 Sep 2016 14:28:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754376AbcI2O22 (ORCPT ); Thu, 29 Sep 2016 10:28:28 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:44053 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754028AbcI2O21 (ORCPT ); Thu, 29 Sep 2016 10:28:27 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id A203F61AC4; Thu, 29 Sep 2016 14:28:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1475159306; bh=9YmsrJLrZ1w7X29GWCvT/NWfqBe+HZpvAqmZ127Rq2M=; h=Subject:To:References:Cc:From:Date:In-Reply-To:From; b=Lncdym9hslgDj/qwlSwssEWuMG7wwOUGOhbvS27fMcqoWlssee9xNGackUeyorNP0 14pzb6Y5KdxYsuS9GjR3QvqRZdLR5ImXUkBGBYkMCml/icsn+iT84vXl+o74smxkV9 7Vvo8DTDzRfSFzjxACOPI37Qrg/egK14M/P3r/HQ= Received: from [10.228.68.92] (global_nat1_iad_fw.qualcomm.com [129.46.232.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: okaya@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 975BE61AC5; Thu, 29 Sep 2016 14:28:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1475159305; bh=9YmsrJLrZ1w7X29GWCvT/NWfqBe+HZpvAqmZ127Rq2M=; h=Subject:To:References:Cc:From:Date:In-Reply-To:From; b=loYj1+RpkKt1sPyh/EbDMYcp1aI1Z9vr98wKsJ7ssvybPgORYxMEovpadeVUfP0C6 fMexUENc489jh293d5tmGiQC8qXryJuhexwU9tpzazd61PHK8N/V9AZXnhi1XttI80 uSiLd49EgvX0BVP1cxIt0TioelWimuoFd/l6wQGQ= DMARC-Filter: OpenDMARC Filter v1.3.1 smtp.codeaurora.org 975BE61AC5 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=pass smtp.mailfrom=okaya@codeaurora.org Subject: Re: 4.7 regression: ACPI: No IRQ available for PCI Interrupt Link [LNKD]. Try pci=noacpi or acpi=off To: Ondrej Zary References: <201609251512.05657.linux@rainbow-software.org> <201609291110.50176.linux@rainbow-software.org> <131b4220b509ed95dfbb35a441ccbc2c@codeaurora.org> <201609291549.07784.linux@rainbow-software.org> Cc: "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org, Bjorn Helgaas , wim@djo.tudelft.nl, ravikanth.nalla@hpe.com From: Sinan Kaya Message-ID: Date: Thu, 29 Sep 2016 10:28:23 -0400 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <201609291549.07784.linux@rainbow-software.org> Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 9/29/2016 9:49 AM, Ondrej Zary wrote: >> Ok, since I have not seen the full boot log I am guessing that isa api >> > gets called before the link objects are initialized. > Netconsole did not work (probably because it crashes too early?) and I don't > have a null-modem cable. > Probably, this is telling me that using the link list to determine penalties for ISA penalties is a bad idea as the ISA API seems to be called from arbitrary contexts even before the ACPI Link objects are created. I was trying to reuse the PCI execution path for ISA interrupts using the last two patches. I dropped the first and last two patches and restored the penalty PCI penalty assignment for the active interrupt only if the interrupt is a ISA interrupt with a new patch. >> > Can you appply the first three only (0001, 0002 and 0003) to see if it >> > makes a difference? > It boots with first 3 patches only but the problem remains - see the attached > log. Let's see the new set. If this doesn't work, I'll have to provide you with another patch to get the penalty counts again. The original debug aids patch may not apply after these. diff --git a/drivers/acpi/pci_link.c b/drivers/acpi/pci_link.c index c983bf7..59326ac 100644 --- a/drivers/acpi/pci_link.c +++ b/drivers/acpi/pci_link.c @@ -870,9 +870,10 @@ static int __init acpi_irq_penalty_update(char *str, int used) */ void acpi_penalize_isa_irq(int irq, int active) { + int penalty = active ? PIRQ_PENALTY_ISA_USED : PIRQ_PENALTY_PCI_USING; + if ((irq >= 0) && (irq < ARRAY_SIZE(acpi_isa_irq_penalty))) - acpi_isa_irq_penalty[irq] = acpi_irq_get_penalty(irq) + - (active ? PIRQ_PENALTY_ISA_USED : PIRQ_PENALTY_PCI_USING); + acpi_isa_irq_penalty[irq] += penalty; } bool acpi_isa_irq_available(int irq)