From patchwork Thu Dec 2 08:02:30 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Zhu X-Patchwork-Id: 12651907 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E3D5AC433F5 for ; Thu, 2 Dec 2021 08:31:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:Subject:Cc:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=GpzHw03mBq8jDqOL0BILkeXfvudEJD2VECh0T1CCpNo=; b=oVeeKU470bgHU7 Qmrf52nD6vVIlVVIjUpzxt2Q6WXJTWGRm8fjzKV8I2WINt5ro+cohkPWsD3NkHZ72qX2FXOeW1IDT Bo6Cmehv3UNBDNZOX0TaHumi41o4GOmVEK0wllB42j5InfUqOLtfi8gJ60g2quE3LDWwjD3GKLERO 6uAR02b9wY6mCv0pheJnqOyFQ7rrOoL2nqUFGohBJADNZlrNTUQZbUesoaMsyKRTijgjUxEfVnB9p WWaR3JkXRaCC8RvUY/r3yZhLkQTqEihpB4VE0sLR9msyhCGAfPGzNy1SM3eo7Qzr6dK6wPjPA99uS vjOamjYDNlw6vlicOmMA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mshUh-00BNS7-3O; Thu, 02 Dec 2021 08:31:07 +0000 Received: from inva021.nxp.com ([92.121.34.21]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mshTu-00BN0j-W9; Thu, 02 Dec 2021 08:30:20 +0000 Received: from inva021.nxp.com (localhost [127.0.0.1]) by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id CA3ED201CD6; Thu, 2 Dec 2021 09:30:15 +0100 (CET) Received: from aprdc01srsp001v.ap-rdc01.nxp.com (aprdc01srsp001v.ap-rdc01.nxp.com [165.114.16.16]) by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id 35F01200222; Thu, 2 Dec 2021 09:30:15 +0100 (CET) Received: from localhost.localdomain (shlinux2.ap.freescale.net [10.192.224.44]) by aprdc01srsp001v.ap-rdc01.nxp.com (Postfix) with ESMTP id 0CBC3183AC96; Thu, 2 Dec 2021 16:30:12 +0800 (+08) From: Richard Zhu To: l.stach@pengutronix.de, bhelgaas@google.com, lorenzo.pieralisi@arm.com, marcel.ziswiler@toradex.com, tharvey@gateworks.com, kishon@ti.com, vkoul@kernel.org, robh@kernel.org, galak@kernel.crashing.org, shawnguo@kernel.org Cc: hongxing.zhu@nxp.com, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de, linux-imx@nxp.com Subject: [PATCH v7 0/8] Add the imx8m pcie phy driver and imx8mm pcie support Date: Thu, 2 Dec 2021 16:02:30 +0800 Message-Id: <1638432158-4119-1-git-send-email-hongxing.zhu@nxp.com> X-Mailer: git-send-email 2.7.4 X-Virus-Scanned: ClamAV using ClamSMTP X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211202_003019_355244_4BBDEB4D X-CRM114-Status: GOOD ( 17.18 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org Refer to the discussion [1] when try to enable i.MX8MM PCIe support, one standalone PCIe PHY driver should be seperated from i.MX PCIe driver when enable i.MX8MM PCIe support. This patch-set adds the standalone PCIe PHY driver suport[1-5], and i.MX8MM PCIe support[6-8] to have whole view to review this patch-set. The PCIe works on i.MX8MM EVK board based the the blkctrl power driver [2] and this patch-set. And tested by Tim and Marcel on the different reference clock modes boards. [1] https://patchwork.ozlabs.org/project/linux-pci/patch/20210510141509.929120-3-l.stach@pengutronix.de/ [2] https://patchwork.kernel.org/project/linux-arm-kernel/cover/20210910202640.980366-1-l.stach@pengutronix.de/ Main changes v6 --> v7: - Add "Reviewed-by: Rob Herring " into #2 patches. - Regarding Vinod's review comments do the following changes. - Don't build in the PHY driver in default. - Remove the extra blank line - Correct the license tag. Main changes v5 --> v6: - Add "Reviewed-by: Rob Herring " into #1 and #3 patches. - Merge Rob's review comments to the #2 patch. Main changes v4 --> v5: - Set the AUX_EN always 1b'1, thus it can fix the regression introduced in v4 series on Marcel's board. - Use the lower-case letter in the devicetreee refer to Marcel's comments. - Since the default value of the deemphasis parameters are zero, only set the deemphasis registers when the input paramters are none zero. Main changes v3 --> v4: - Update the yaml to fix syntax error, add maxitems and drop description of phy - Correct the clock name in PHY DT node. - Squash the EVK board relalted dts changes into one patch, and drop the useless dummy clock and gpio suffix in DT nodes. - Add board specific de-emphasis parameters as DT properties. Thus each board can specify its actual de-emphasis values. - Update the commit log of PHY driver. - Remove the useless codes from PCIe driver, since they are moved to PHY driver - After the discussion and verification of the CLKREQ# configurations with Tim, agree to add an optional boolean property "fsl,clkreq-unsupported", indicates the CLKREQ# signal is hooked or not in HW designs. - Add "Tested-by: Marcel Ziswiler " tag, since Marcel help to test the v3 patch-set. Main changes v2 --> v3: - Regarding Lucas' comments. - to have a whole view to review the patches, send out the i.MX8MM PCIe support too. - move the PHY related bits manipulations of the GPR/SRC to standalone PHY driver. - split the dts changes to SOC and board DT, and use the enum instead of raw value. - update the license of the dt-binding header file. Changes v1 --> v2: - Update the license of the dt-binding header file to make the license compatible with dts files. - Fix the dt_binding_check errors. Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml | 6 +++ Documentation/devicetree/bindings/phy/fsl,imx8-pcie-phy.yaml | 92 +++++++++++++++++++++++++++++++ arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi | 55 +++++++++++++++++++ arch/arm64/boot/dts/freescale/imx8mm.dtsi | 46 +++++++++++++++- drivers/pci/controller/dwc/pci-imx6.c | 83 +++++++++++++++++++++++++--- drivers/phy/freescale/Kconfig | 8 +++ drivers/phy/freescale/Makefile | 1 + drivers/phy/freescale/phy-fsl-imx8m-pcie.c | 236 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ include/dt-bindings/phy/phy-imx8-pcie.h | 14 +++++ 9 files changed, 532 insertions(+), 9 deletions(-) [PATCH v7 1/8] dt-bindings: phy: phy-imx8-pcie: Add binding for the [PATCH v7 2/8] dt-bindings: phy: Add imx8 pcie phy driver support [PATCH v7 3/8] dt-bindings: imx6q-pcie: Add PHY phandles and name [PATCH v7 4/8] arm64: dts: imx8mm: Add the pcie phy support [PATCH v7 5/8] phy: freescale: pcie: Initialize the imx8 pcie [PATCH v7 6/8] arm64: dts: imx8mm: Add the pcie support [PATCH v7 7/8] arm64: dts: imx8mm-evk: Add the pcie support on imx8mm [PATCH v7 8/8] PCI: imx: Add the imx8mm pcie support