From patchwork Thu Jul 14 12:43:03 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 12917864 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F2844C433EF for ; Thu, 14 Jul 2022 12:47:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=5bUPiRFD079i9Vr6+WEfHBFdRlkdXb0EFrC9LDmjYS8=; b=HZ57deXcpbYcSW V3te0A7bhm9ducxVeEGeTyjrsesK+7++7WALVY2QrEcqqnK2DX14EqiWpn60pMuurIGqtMyEMOe1K HC7aVqMAR/51epnl03/9SXEn5z61ozZsBH0/6wx2UE8dwY6ygLtMMTOk7ke6tl24RhmEri288wUbY GWiZKBaKu6hXVzBd6rABXRIe5zvLGNFyRRiqsErJRwuCrDtXytf0QkAR+cuQi7w1RPBf72lRbixuu Qj8aCRU08Fpj4Z6zLGql+EXSIwdKzr7YnzqUFxIH2MUjS2ZFfLdyIv+bUJmnOuVjsq9PKT3W2ejMw SqXvaYROiNpckbd1kgTw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oByFF-00ENF0-21; Thu, 14 Jul 2022 12:47:05 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oByCN-00EL5s-9g for linux-phy@lists.infradead.org; Thu, 14 Jul 2022 12:44:10 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D74ADB824D6; Thu, 14 Jul 2022 12:44:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 071EFC341C8; Thu, 14 Jul 2022 12:44:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657802644; bh=QHwAddHD+o4YxO5fPQSFi9XnW6UkKE5vsIk/KhPzzLA=; h=From:To:Cc:Subject:Date:From; b=Q9uRBvGUgpgtTAHKFRXMYMkj30Mqice1ld3NADNMzlptVtV737ILZ/ImXwVblxgIA rv+PPI5HaOxNhDgU8LV9DgZv1JGDm8rqgPulMslpPSKjep/29tsS6MHDYstp1U64ck N8M00Go1CsENReeNJNFE5iTh5JalID16eslk42C+i/qwuZy+TqKeg3Jno7g2aydOJo WuhkYplxSlfFaz/E4I50p2NjORflqgWeZ+NwF1H5ZhWwsGoZbxsxk0QO6YjHBCS23E CtRZ1B6kcJWqDstrTApqhI7TeB6sAF1Qkk3wvtGOvOxen7UV2XUdGOBfh5w3KwZdl4 ETCZxmLWrZ3Ow== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1oByCO-0007D5-M9; Thu, 14 Jul 2022 14:44:08 +0200 From: Johan Hovold To: Vinod Koul , Rob Herring , Krzysztof Kozlowski Cc: Andy Gross , Bjorn Andersson , Konrad Dybcio , Kishon Vijay Abraham I , Dmitry Baryshkov , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH v3 00/30] phy: qcom,qmp: fix dt-bindings and deprecate lane suffix Date: Thu, 14 Jul 2022 14:43:03 +0200 Message-Id: <20220714124333.27643-1-johan+linaro@kernel.org> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220714_054407_675476_57599BF9 X-CRM114-Status: GOOD ( 17.48 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org When adding support for SC8280XP to the QMP PHY driver I noticed that the PHY provider child node was not described by the current DT schema. The SC8280XP PHYs also need a second fixed-divider PIPE clock ("pipediv2") and I didn't want to have to add a bogus "lane" suffix to the clock name just to match the current "pipe0" name so I decided to deprecate the unnecessary suffix in the current binding instead. To be able to add the missing child-node schema and handle device specifics like additional PIPE clocks, it quickly became obvious that the binding needs to be split up. This series clean up and fixes some issue with the current schema before splitting it up in separate schemas for PCIe, UFS and USB and adding missing parts like the child PHY provider nodes. The MSM8996 PCIe PHY gets its own schema as this is the only non-combo PHY that actually provides more than one PHY per IP block. Note that the "lane" suffix is still unnecessary and misleading. The final patches add support for the updated binding to the (recently split up) PHY drivers. Included is also a related combo PHY cleanup. Johan Changes in v3 - rebase on linux-next which has a new binding for IPQ8074 - fix git-bisect breakage due to removal of an unused variable one patch too soon (Krzysztof) - replace one Fixes tag with reference in commit message (Krzysztof) - drop two redundant minItems (Krzysztof) - fix two Fixes tags that lacked the actual tag - add more ack and review tags from Krzysztof Changes in v2 - squash split + cleanup + example patches (Krzysztof) - deprecate clock-names instead of dropping suffix (Krzysztof) - deprecate reset-names instead of dropping suffix (Krzysztof) - flatten child reg if/then schemas (Krzysztof) - add back optional vddp-ref-clk to all bindings even though it likely only applies to MSM8996/98 UFS (Krzysztof) - add missing sc7180 schema to USB binding - misc clean ups - shorten or drop descriptions - drop quotes around $id and $schema (Krzysztof) - use maxItems with clock-output-names - combine two USB clock+reset schemas - add Reviewed-by/Acked-by tags Johan Hovold (30): dt-bindings: phy: qcom,qmp: fix bogus clock-cells property dt-bindings: phy: qcom,qmp: sort compatible strings dt-bindings: phy: qcom,qmp: drop redundant descriptions dt-bindings: phy: qcom,qmp: fix child node description dt-bindings: phy: qcom,qmp: clean up descriptions dt-bindings: phy: qcom,qmp: clean up example dt-bindings: phy: qcom,qmp: drop child-node comment dt-bindings: phy: add qcom,msm8996-qmp-pcie-phy schema dt-bindings: phy: qcom,msm8996-qmp-pcie: add missing child node schema dt-bindings: phy: qcom,msm8996-qmp-pcie: deprecate PIPE clock names dt-bindings: phy: qcom,msm8996-qmp-pcie: deprecate reset names dt-bindings: phy: add QMP PCIe PHY schema dt-bindings: phy: qcom,qmp-pcie: add missing child node schema dt-bindings: phy: qcom,qmp-pcie: deprecate PIPE clock name dt-bindings: phy: add QMP UFS PHY schema dt-bindings: phy: qcom,qmp-ufs: add missing SM8450 clock dt-bindings: phy: qcom,qmp-ufs: add missing SM8150 power domain dt-bindings: phy: qcom,qmp-ufs: add missing child node schema dt-bindings: phy: add QMP USB PHY schema dt-bindings: phy: qcom,qmp-usb: add missing child node schema dt-bindings: phy: qcom,qmp-usb: deprecate PIPE clock name dt-bindings: phy: qcom,qmp-usb: add missing qcom,sc7180-qmp-usb3-phy schema dt-bindings: phy: qcom,qmp-usb3-dp: fix bogus clock-cells property dt-bindings: phy: qcom,qmp-usb3-dp: deprecate USB PIPE clock name phy: qcom-qmp-pcie: drop pipe clock lane suffix phy: qcom-qmp-combo: drop unused lane reset phy: qcom-qmp-combo: drop pipe clock lane suffix phy: qcom-qmp-pcie-msm8996: drop pipe clock lane suffix phy: qcom-qmp-pcie-msm8996: drop reset lane suffix phy: qcom-qmp-usb: drop pipe clock lane suffix .../phy/qcom,msm8996-qmp-pcie-phy.yaml | 189 +++++++ .../bindings/phy/qcom,qmp-pcie-phy.yaml | 296 +++++++++++ .../devicetree/bindings/phy/qcom,qmp-phy.yaml | 502 ------------------ .../bindings/phy/qcom,qmp-ufs-phy.yaml | 239 +++++++++ .../bindings/phy/qcom,qmp-usb-phy.yaml | 385 ++++++++++++++ .../bindings/phy/qcom,qmp-usb3-dp-phy.yaml | 8 +- drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 6 +- .../phy/qualcomm/phy-qcom-qmp-pcie-msm8996.c | 8 +- drivers/phy/qualcomm/phy-qcom-qmp-pcie.c | 4 +- drivers/phy/qualcomm/phy-qcom-qmp-usb.c | 4 +- 10 files changed, 1115 insertions(+), 526 deletions(-) create mode 100644 Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-pcie-phy.yaml create mode 100644 Documentation/devicetree/bindings/phy/qcom,qmp-pcie-phy.yaml delete mode 100644 Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml create mode 100644 Documentation/devicetree/bindings/phy/qcom,qmp-ufs-phy.yaml create mode 100644 Documentation/devicetree/bindings/phy/qcom,qmp-usb-phy.yaml