[0/7] Use dev_err_probe() to simplify code

Message

Yuan Can Sept. 22, 2022, 11:12 a.m. UTC

This series simplify the error handling in probe function by
switching from dev_err() to dev_err_probe().

Yuan Can (7):
  phy: qcom-qmp-combo: Use dev_err_probe() to simplify code
  phy: qcom-qmp-pcie-msm8996: Use dev_err_probe() to simplify code
  phy: qcom-qmp-pcie: Use dev_err_probe() to simplify code
  phy: qcom-qmp-ufs: Use dev_err_probe() to simplify code
  phy: qcom-qmp-usb: Use dev_err_probe() to simplify code
  phy: qcom-qusb2: Use dev_err_probe() to simplify code
  phy: qcom-snps: Use dev_err_probe() to simplify code

 drivers/phy/qualcomm/phy-qcom-qmp-combo.c     | 21 +++++----------
 .../phy/qualcomm/phy-qcom-qmp-pcie-msm8996.c  |  9 +++----
 drivers/phy/qualcomm/phy-qcom-qmp-pcie.c      |  9 +++----
 drivers/phy/qualcomm/phy-qcom-qmp-ufs.c       |  9 +++----
 drivers/phy/qualcomm/phy-qcom-qmp-usb.c       |  9 +++----
 drivers/phy/qualcomm/phy-qcom-qusb2.c         | 27 +++++++------------
 drivers/phy/qualcomm/phy-qcom-snps-femto-v2.c | 18 +++++--------
 7 files changed, 34 insertions(+), 68 deletions(-)

Comments

Andrew Halaney Sept. 22, 2022, 2:26 p.m. UTC | #1

On Thu, Sep 22, 2022 at 11:12:21AM +0000, Yuan Can wrote:
> This series simplify the error handling in probe function by
> switching from dev_err() to dev_err_probe().
> 
> Yuan Can (7):
>   phy: qcom-qmp-combo: Use dev_err_probe() to simplify code
>   phy: qcom-qmp-pcie-msm8996: Use dev_err_probe() to simplify code
>   phy: qcom-qmp-pcie: Use dev_err_probe() to simplify code
>   phy: qcom-qmp-ufs: Use dev_err_probe() to simplify code
>   phy: qcom-qmp-usb: Use dev_err_probe() to simplify code
>   phy: qcom-qusb2: Use dev_err_probe() to simplify code
>   phy: qcom-snps: Use dev_err_probe() to simplify code
> 
>  drivers/phy/qualcomm/phy-qcom-qmp-combo.c     | 21 +++++----------
>  .../phy/qualcomm/phy-qcom-qmp-pcie-msm8996.c  |  9 +++----
>  drivers/phy/qualcomm/phy-qcom-qmp-pcie.c      |  9 +++----
>  drivers/phy/qualcomm/phy-qcom-qmp-ufs.c       |  9 +++----
>  drivers/phy/qualcomm/phy-qcom-qmp-usb.c       |  9 +++----
>  drivers/phy/qualcomm/phy-qcom-qusb2.c         | 27 +++++++------------
>  drivers/phy/qualcomm/phy-qcom-snps-femto-v2.c | 18 +++++--------
>  7 files changed, 34 insertions(+), 68 deletions(-)
> 
> -- 
> 2.17.1
> 

The whole series looks good to me:

Reviewed-by: Andrew Halaney <[e-mail]>

Vinod Koul Sept. 24, 2022, 6:38 a.m. UTC | #2

On 22-09-22, 11:12, Yuan Can wrote:
> This series simplify the error handling in probe function by
> switching from dev_err() to dev_err_probe().
> 
> Yuan Can (7):
>   phy: qcom-qmp-combo: Use dev_err_probe() to simplify code
>   phy: qcom-qmp-pcie-msm8996: Use dev_err_probe() to simplify code
>   phy: qcom-qmp-pcie: Use dev_err_probe() to simplify code
>   phy: qcom-qmp-ufs: Use dev_err_probe() to simplify code
>   phy: qcom-qmp-usb: Use dev_err_probe() to simplify code
>   phy: qcom-qusb2: Use dev_err_probe() to simplify code
>   phy: qcom-snps: Use dev_err_probe() to simplify code

phy: qcom-snps: Use dev_err_probe() to simplify code
phy: qcom-qusb2: Use dev_err_probe() to simplify code
phy: qcom-qmp-pcie: Use dev_err_probe() to simplify code

Applied these three, rest have conflicts please rebase and resend with
acks collected