| Message ID | 20240412125818.17052-1-cassel@kernel.org |
|---|---|
| Headers | show |
| Series | rockchip pcie3-phy separate refclk support | expand |
On Fri, 12 Apr 2024 14:58:14 +0200, Niklas Cassel wrote: > This series is based on: linux-phy phy/next > > Hello all, > > The rockchip,pcie3-phy PHY in rk3588 is by default configured to run in > "common reference clock" mode. (Which is a sensible default, as the most > commonly used clock configuration is "common reference clock".) > > [...] Applied, thanks! [1/2] dt-bindings: phy: rockchip,pcie3-phy: add rockchip,rx-common-refclk-mode commit: 46492d10067660785a09db4ce9244545126a17b8 [2/2] phy: rockchip-snps-pcie3: add support for rockchip,rx-common-refclk-mode commit: a1fe1eca0d8be69ccc1f3d615e5a529df1c82e66 Best regards,
This series is based on: linux-phy phy/next Hello all, The rockchip,pcie3-phy PHY in rk3588 is by default configured to run in "common reference clock" mode. (Which is a sensible default, as the most commonly used clock configuration is "common reference clock".) However, PCIe also defines two other configurations where the Root Complex and Endpoint uses separate reference clocks: SRNS and SRIS. Having the Root Complex PHY configured in "common reference clock mode" while having an Endpoint connected which is supplying its own reference clock (i.e. SRNS or SRIS configuration), will either result in the link training failing, or a highly unstable link that continuously jumps between link states L0 and recovery. Add a rockchip specific device tree property that can be added to the rk3588 Root Complex device tree PHY node, if the connected Endpoint device is using a separate refererence clock. This way we will get a stable link when using an Endpoint configured in SRNS or SRIS mode. Kind regards, Niklas Changes since V1: -Picked up tags -Rebased on phy/next Niklas Cassel (2): dt-bindings: phy: rockchip,pcie3-phy: add rockchip,rx-common-refclk-mode phy: rockchip-snps-pcie3: add support for rockchip,rx-common-refclk-mode .../bindings/phy/rockchip,pcie3-phy.yaml | 10 +++++ .../phy/rockchip/phy-rockchip-snps-pcie3.c | 37 +++++++++++++++++++ 2 files changed, 47 insertions(+)