mbox series

[v5,0/2] Add JH7110 MIPI DPHY TX support

Message ID 20240418035020.47876-1-shengyang.chen@starfivetech.com
Headers show
Series Add JH7110 MIPI DPHY TX support | expand

Message

Shengyang Chen April 18, 2024, 3:50 a.m. UTC 
This patchset adds mipi dphy tx support for the StarFive JH7110 SoC.
It is used to transfer DSI data. The series has been tested on
the VisionFive 2 board.


change since v4:
- Rebased on tag v6.9-rc4.

patch 2:
-Drop shift macro definitions.
-Drop useless member variables of config array.
-Drop stf_dphy_set_reg() and  stf_dphy_get_reg().
-Add readl_poll_timeout_atomic() for delay in stf_dphy_hw_reset().
-Rewrite register configure logic with FIELD_PREP()/FIELD_GET() and writel()/readl().

v4: https://patchwork.kernel.org/project/linux-phy/cover/20240301012406.92589-1-shengyang.chen@starfivetech.com/


change since v3:
- Rebased on tag v6.8-rc6.

patch 2:
- Lower case for hex value.
- Replace bit shifts operation with macro definitions.
- Drop delay in stf_dphy_hw_reset().
- Change variable declarations order in stf_dphy_configure().

v3: https://patchwork.kernel.org/project/linux-phy/cover/20240206061921.107372-1-shengyang.chen@starfivetech.com/


change since v2:
- Rebased on tag v6.8-rc3.

patch 2:
- Drop regulator operation.

v2: https://patchwork.kernel.org/project/linux-phy/cover/20240109071246.24065-1-shengyang.chen@starfivetech.com/


changes since v1:
- Rebased on tag v6.7.

patch 1:
- Drop 'dphy_'prefix.
- Drop DSI reset.
- Drop unnecessary resets.


patch 2:
- Changed the commit message.
- Use dev_err_probe() and PTR_ERR() in probing.
- Drop DSI reset operation.
- Drop unnecessary resets operation.
- Add configs in array for full support of the module
- Changed 'void *io_addr' to 'void __iomem *io_addr'.

v1: https://patchwork.kernel.org/project/linux-phy/cover/20231117130421.79261-1-shengyang.chen@starfivetech.com/

Shengyang Chen (2):
  dt-bindings: phy: Add starfive,jh7110-dphy-tx
  phy: starfive: Add mipi dphy tx support

 .../bindings/phy/starfive,jh7110-dphy-tx.yaml |  68 +++
 MAINTAINERS                                   |   7 +
 drivers/phy/starfive/Kconfig                  |  10 +
 drivers/phy/starfive/Makefile                 |   1 +
 drivers/phy/starfive/phy-jh7110-dphy-tx.c     | 459 ++++++++++++++++++
 5 files changed, 545 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/phy/starfive,jh7110-dphy-tx.yaml
 create mode 100644 drivers/phy/starfive/phy-jh7110-dphy-tx.c

Comments

Shengyang Chen May 13, 2024, 8:13 a.m. UTC | #1 
> This patchset adds mipi dphy tx support for the StarFive JH7110 SoC.
> It is used to transfer DSI data. The series has been tested on the VisionFive 2
> board.
> 
> 

Hi, Vinod and Kishon

Could you please help to review and give me some suggestions
for this patch series? Thank you for your time.

Best regards,
Shengyang
Vinod Koul June 15, 2024, 6:52 p.m. UTC | #2 
On Thu, 18 Apr 2024 11:50:18 +0800, Shengyang Chen wrote:
> This patchset adds mipi dphy tx support for the StarFive JH7110 SoC.
> It is used to transfer DSI data. The series has been tested on
> the VisionFive 2 board.
> 
> 
> change since v4:
> - Rebased on tag v6.9-rc4.
> 
> [...]

Applied, thanks!

[1/2] dt-bindings: phy: Add starfive,jh7110-dphy-tx
      commit: e4a8e87250fc2c1ed2aec5d1e8521dc7d799ea77
[2/2] phy: starfive: Add mipi dphy tx support
      commit: d3ab7955330843699cdcc413edd7993923e6c016

Best regards,