mbox series

[v3,0/3] Add support for USB controllers on QCS615

Message ID 20241224084621.4139021-1-krishna.kurapati@oss.qualcomm.com
Headers show
Series Add support for USB controllers on QCS615 | expand

Message

Krishna Kurapati Dec. 24, 2024, 8:46 a.m. UTC 
This series aims at enabling USB on QCS615 which has 2 USB controllers.
The primary controller is SuperSpeed capable and secondary one is
High Speed only capable. The High Speed Phy is a QUSB2 phy and the
SuperSpeed Phy is a QMP Uni Phy which supports non-concurrent DP.

Link to v1:
https://lore.kernel.org/all/20241014084432.3310114-1-quic_kriskura@quicinc.com/

Link to v2:
https://lore.kernel.org/all/20241017130701.3301785-1-quic_kriskura@quicinc.com/

All the patches are acked. But some are merged and some don't apply clean.

Phy bindings have been acked on v1 and have been merged from v1.

The v2 DWC3 binding patch has been acked but conflicts with sar2130 code
and hence v2-patch-1 doesn't apply cleanly.

The QUSB2 phy driver changes in v2 conflict with IPQ changes that went in
recently and hence v2-patch-4 doesn't apply cleanly.

Changes in v3:
Rebase on top of latest linux next to avoid conflicts.
Updated mail ID from quicinc to OSS. So changed the SOBs and retained the
ACKs since the author is still the same.
Updated cover letter heading since the changes are for both ports and DT
for first port is merged and second port is ACKed.

Changes in v2:
Addressed comments in v1 by using lowercase for reg values.
Removed explicitly setting of struct params to false (as they are
already false).

Krishna Kurapati (3):
  dt-bindings: usb: qcom,dwc3: Add QCS615 to USB DWC3 bindings
  phy: qcom-qusb2: Add support for QCS615
  phy: qcom: qmp-usbc: Add qmp configuration for QCS615

 .../devicetree/bindings/usb/qcom,dwc3.yaml    |  3 +++
 drivers/phy/qualcomm/phy-qcom-qmp-usbc.c      |  3 +++
 drivers/phy/qualcomm/phy-qcom-qusb2.c         | 27 +++++++++++++++++++
 3 files changed, 33 insertions(+)

Comments

Vinod Koul Dec. 24, 2024, 3:25 p.m. UTC | #1 
On Tue, 24 Dec 2024 14:16:18 +0530, Krishna Kurapati wrote:
> This series aims at enabling USB on QCS615 which has 2 USB controllers.
> The primary controller is SuperSpeed capable and secondary one is
> High Speed only capable. The High Speed Phy is a QUSB2 phy and the
> SuperSpeed Phy is a QMP Uni Phy which supports non-concurrent DP.
> 
> Link to v1:
> https://lore.kernel.org/all/20241014084432.3310114-1-quic_kriskura@quicinc.com/
> 
> [...]

Applied, thanks!

[2/3] phy: qcom-qusb2: Add support for QCS615
      commit: 8adbf20e05025f588d68fb5b0fbbdab4e9a6f97e

Best regards,
Dmitry Baryshkov Dec. 24, 2024, 3:38 p.m. UTC | #2 
On Tue, Dec 24, 2024 at 08:55:18PM +0530, Vinod Koul wrote:
> 
> On Tue, 24 Dec 2024 14:16:18 +0530, Krishna Kurapati wrote:
> > This series aims at enabling USB on QCS615 which has 2 USB controllers.
> > The primary controller is SuperSpeed capable and secondary one is
> > High Speed only capable. The High Speed Phy is a QUSB2 phy and the
> > SuperSpeed Phy is a QMP Uni Phy which supports non-concurrent DP.
> > 
> > Link to v1:
> > https://lore.kernel.org/all/20241014084432.3310114-1-quic_kriskura@quicinc.com/
> > 
> > [...]
> 
> Applied, thanks!
> 
> [2/3] phy: qcom-qusb2: Add support for QCS615
>       commit: 8adbf20e05025f588d68fb5b0fbbdab4e9a6f97e

Is there any issue with the two remaining patches?
Vinod Koul Dec. 24, 2024, 7:19 p.m. UTC | #3 
On 24-12-24, 17:38, Dmitry Baryshkov wrote:
> On Tue, Dec 24, 2024 at 08:55:18PM +0530, Vinod Koul wrote:
> > 
> > On Tue, 24 Dec 2024 14:16:18 +0530, Krishna Kurapati wrote:
> > > This series aims at enabling USB on QCS615 which has 2 USB controllers.
> > > The primary controller is SuperSpeed capable and secondary one is
> > > High Speed only capable. The High Speed Phy is a QUSB2 phy and the
> > > SuperSpeed Phy is a QMP Uni Phy which supports non-concurrent DP.
> > > 
> > > Link to v1:
> > > https://lore.kernel.org/all/20241014084432.3310114-1-quic_kriskura@quicinc.com/
> > > 
> > > [...]
> > 
> > Applied, thanks!
> > 
> > [2/3] phy: qcom-qusb2: Add support for QCS615
> >       commit: 8adbf20e05025f588d68fb5b0fbbdab4e9a6f97e
> 
> Is there any issue with the two remaining patches?

Something wrong with b4... I have applied 2 & 3
Patch 1 should go thru USB tree
Dmitry Baryshkov Dec. 24, 2024, 7:33 p.m. UTC | #4 
On Wed, Dec 25, 2024 at 12:49:07AM +0530, Vinod Koul wrote:
> On 24-12-24, 17:38, Dmitry Baryshkov wrote:
> > On Tue, Dec 24, 2024 at 08:55:18PM +0530, Vinod Koul wrote:
> > > 
> > > On Tue, 24 Dec 2024 14:16:18 +0530, Krishna Kurapati wrote:
> > > > This series aims at enabling USB on QCS615 which has 2 USB controllers.
> > > > The primary controller is SuperSpeed capable and secondary one is
> > > > High Speed only capable. The High Speed Phy is a QUSB2 phy and the
> > > > SuperSpeed Phy is a QMP Uni Phy which supports non-concurrent DP.
> > > > 
> > > > Link to v1:
> > > > https://lore.kernel.org/all/20241014084432.3310114-1-quic_kriskura@quicinc.com/
> > > > 
> > > > [...]
> > > 
> > > Applied, thanks!
> > > 
> > > [2/3] phy: qcom-qusb2: Add support for QCS615
> > >       commit: 8adbf20e05025f588d68fb5b0fbbdab4e9a6f97e
> > 
> > Is there any issue with the two remaining patches?
> 
> Something wrong with b4... I have applied 2 & 3
> Patch 1 should go thru USB tree

Hmm, strange. But then, please excuse my ignorance, do we have bindings
for these two patches?
Vinod Koul Dec. 24, 2024, 7:42 p.m. UTC | #5 
On 24-12-24, 21:33, Dmitry Baryshkov wrote:
> On Wed, Dec 25, 2024 at 12:49:07AM +0530, Vinod Koul wrote:
> > On 24-12-24, 17:38, Dmitry Baryshkov wrote:
> > > On Tue, Dec 24, 2024 at 08:55:18PM +0530, Vinod Koul wrote:
> > > > 
> > > > On Tue, 24 Dec 2024 14:16:18 +0530, Krishna Kurapati wrote:
> > > > > This series aims at enabling USB on QCS615 which has 2 USB controllers.
> > > > > The primary controller is SuperSpeed capable and secondary one is
> > > > > High Speed only capable. The High Speed Phy is a QUSB2 phy and the
> > > > > SuperSpeed Phy is a QMP Uni Phy which supports non-concurrent DP.
> > > > > 
> > > > > Link to v1:
> > > > > https://lore.kernel.org/all/20241014084432.3310114-1-quic_kriskura@quicinc.com/
> > > > > 
> > > > > [...]
> > > > 
> > > > Applied, thanks!
> > > > 
> > > > [2/3] phy: qcom-qusb2: Add support for QCS615
> > > >       commit: 8adbf20e05025f588d68fb5b0fbbdab4e9a6f97e
> > > 
> > > Is there any issue with the two remaining patches?
> > 
> > Something wrong with b4... I have applied 2 & 3
> > Patch 1 should go thru USB tree
> 
> Hmm, strange. But then, please excuse my ignorance, do we have bindings
> for these two patches?

I see to have missed one!

This one is documented see:
d146d384222e dt-bindings: phy: qcom,qusb2: Add bindings for QCS615

but, the third patch is sadly not... I am dropping the third patch
Krishna Kurapati Dec. 25, 2024, 8:31 a.m. UTC | #6 
On 12/25/2024 1:12 AM, Vinod Koul wrote:
> On 24-12-24, 21:33, Dmitry Baryshkov wrote:
>> On Wed, Dec 25, 2024 at 12:49:07AM +0530, Vinod Koul wrote:
>>> On 24-12-24, 17:38, Dmitry Baryshkov wrote:
>>>> On Tue, Dec 24, 2024 at 08:55:18PM +0530, Vinod Koul wrote:
>>>>>
>>>>> On Tue, 24 Dec 2024 14:16:18 +0530, Krishna Kurapati wrote:
>>>>>> This series aims at enabling USB on QCS615 which has 2 USB controllers.
>>>>>> The primary controller is SuperSpeed capable and secondary one is
>>>>>> High Speed only capable. The High Speed Phy is a QUSB2 phy and the
>>>>>> SuperSpeed Phy is a QMP Uni Phy which supports non-concurrent DP.
>>>>>>
>>>>>> Link to v1:
>>>>>> https://lore.kernel.org/all/20241014084432.3310114-1-quic_kriskura@quicinc.com/
>>>>>>
>>>>>> [...]
>>>>>
>>>>> Applied, thanks!
>>>>>
>>>>> [2/3] phy: qcom-qusb2: Add support for QCS615
>>>>>        commit: 8adbf20e05025f588d68fb5b0fbbdab4e9a6f97ecommit e1b2772ea957c91694aa91b90e4c0a1d7b0fb144
Author: Krishna Kurapati <quic_kriskura@quicinc.com>
Date:   Mon Oct 14 14:14:30 2024 +0530

     dt-bindings: phy: qcom,msm8998-qmp-usb3-phy: Add support for QCS615


>>>>
>>>> Is there any issue with the two remaining patches?
>>>
>>> Something wrong with b4... I have applied 2 & 3
>>> Patch 1 should go thru USB tree
>>
>> Hmm, strange. But then, please excuse my ignorance, do we have bindings
>> for these two patches?
> 
> I see to have missed one!
> 
> This one is documented see:
> d146d384222e dt-bindings: phy: qcom,qusb2: Add bindings for QCS615
> 
> but, the third patch is sadly not... I am dropping the third patch
> 

Hi Dmitry, Vinod,

  I see the bindings for QMP PHY in linux next as follows:

commit e1b2772ea957c91694aa91b90e4c0a1d7b0fb144
Author: Krishna Kurapati <quic_kriskura@quicinc.com>
Date:   Mon Oct 14 14:14:30 2024 +0530

     dt-bindings: phy: qcom,msm8998-qmp-usb3-phy: Add support for QCS615

As mentioned in the cover letter, the bindings of phy have been merged 
from v1.

Regards,
Krishna,
Krishna Kurapati Jan. 23, 2025, 7 a.m. UTC | #7 
On 12/25/2024 2:01 PM, Krishna Kurapati wrote:
> 
> 
> On 12/25/2024 1:12 AM, Vinod Koul wrote:
>> On 24-12-24, 21:33, Dmitry Baryshkov wrote:
>>> On Wed, Dec 25, 2024 at 12:49:07AM +0530, Vinod Koul wrote:
>>>> On 24-12-24, 17:38, Dmitry Baryshkov wrote:
>>>>> On Tue, Dec 24, 2024 at 08:55:18PM +0530, Vinod Koul wrote:
>>>>>>
>>>>>> On Tue, 24 Dec 2024 14:16:18 +0530, Krishna Kurapati wrote:
>>>>>>> This series aims at enabling USB on QCS615 which has 2 USB 
>>>>>>> controllers.
>>>>>>> The primary controller is SuperSpeed capable and secondary one is
>>>>>>> High Speed only capable. The High Speed Phy is a QUSB2 phy and the
>>>>>>> SuperSpeed Phy is a QMP Uni Phy which supports non-concurrent DP.
>>>>>>>
>>>>>>> Link to v1:
>>>>>>> https://lore.kernel.org/all/20241014084432.3310114-1-quic_kriskura@quicinc.com/
>>>>>>>
>>>>>>> [...]
>>>>>>
>>>>>> Applied, thanks!
>>>>>>
>>>>>> [2/3] phy: qcom-qusb2: Add support for QCS615
>>>>>>        commit: 8adbf20e05025f588d68fb5b0fbbdab4e9a6f97ecommit 
>>>>>> e1b2772ea957c91694aa91b90e4c0a1d7b0fb144
> Author: Krishna Kurapati <quic_kriskura@quicinc.com>
> Date:   Mon Oct 14 14:14:30 2024 +0530
> 
>      dt-bindings: phy: qcom,msm8998-qmp-usb3-phy: Add support for QCS615
> 
> 
>>>>>
>>>>> Is there any issue with the two remaining patches?
>>>>
>>>> Something wrong with b4... I have applied 2 & 3
>>>> Patch 1 should go thru USB tree
>>>
>>> Hmm, strange. But then, please excuse my ignorance, do we have bindings
>>> for these two patches?
>>
>> I see to have missed one!
>>
>> This one is documented see:
>> d146d384222e dt-bindings: phy: qcom,qusb2: Add bindings for QCS615
>>
>> but, the third patch is sadly not... I am dropping the third patch
>>
> 
> Hi Dmitry, Vinod,
> 
>   I see the bindings for QMP PHY in linux next as follows:
> 
> commit e1b2772ea957c91694aa91b90e4c0a1d7b0fb144
> Author: Krishna Kurapati <quic_kriskura@quicinc.com>
> Date:   Mon Oct 14 14:14:30 2024 +0530
> 
>      dt-bindings: phy: qcom,msm8998-qmp-usb3-phy: Add support for QCS615
> 
> As mentioned in the cover letter, the bindings of phy have been merged 
> from v1.

Hi Vinod,

  Can you help in taking in the patch-3. As mentioned in previous mail, 
the bindings are merged and present in linux-next.

Regards,
Krishna,
Dmitry Baryshkov Jan. 23, 2025, 7:23 a.m. UTC | #8 
On Thu, 23 Jan 2025 at 09:00, Krishna Kurapati
<krishna.kurapati@oss.qualcomm.com> wrote:
>
>
>
> On 12/25/2024 2:01 PM, Krishna Kurapati wrote:
> >
> >
> > On 12/25/2024 1:12 AM, Vinod Koul wrote:
> >> On 24-12-24, 21:33, Dmitry Baryshkov wrote:
> >>> On Wed, Dec 25, 2024 at 12:49:07AM +0530, Vinod Koul wrote:
> >>>> On 24-12-24, 17:38, Dmitry Baryshkov wrote:
> >>>>> On Tue, Dec 24, 2024 at 08:55:18PM +0530, Vinod Koul wrote:
> >>>>>>
> >>>>>> On Tue, 24 Dec 2024 14:16:18 +0530, Krishna Kurapati wrote:
> >>>>>>> This series aims at enabling USB on QCS615 which has 2 USB
> >>>>>>> controllers.
> >>>>>>> The primary controller is SuperSpeed capable and secondary one is
> >>>>>>> High Speed only capable. The High Speed Phy is a QUSB2 phy and the
> >>>>>>> SuperSpeed Phy is a QMP Uni Phy which supports non-concurrent DP.
> >>>>>>>
> >>>>>>> Link to v1:
> >>>>>>> https://lore.kernel.org/all/20241014084432.3310114-1-quic_kriskura@quicinc.com/
> >>>>>>>
> >>>>>>> [...]
> >>>>>>
> >>>>>> Applied, thanks!
> >>>>>>
> >>>>>> [2/3] phy: qcom-qusb2: Add support for QCS615
> >>>>>>        commit: 8adbf20e05025f588d68fb5b0fbbdab4e9a6f97ecommit
> >>>>>> e1b2772ea957c91694aa91b90e4c0a1d7b0fb144
> > Author: Krishna Kurapati <quic_kriskura@quicinc.com>
> > Date:   Mon Oct 14 14:14:30 2024 +0530
> >
> >      dt-bindings: phy: qcom,msm8998-qmp-usb3-phy: Add support for QCS615
> >
> >
> >>>>>
> >>>>> Is there any issue with the two remaining patches?
> >>>>
> >>>> Something wrong with b4... I have applied 2 & 3
> >>>> Patch 1 should go thru USB tree
> >>>
> >>> Hmm, strange. But then, please excuse my ignorance, do we have bindings
> >>> for these two patches?
> >>
> >> I see to have missed one!
> >>
> >> This one is documented see:
> >> d146d384222e dt-bindings: phy: qcom,qusb2: Add bindings for QCS615
> >>
> >> but, the third patch is sadly not... I am dropping the third patch
> >>
> >
> > Hi Dmitry, Vinod,
> >
> >   I see the bindings for QMP PHY in linux next as follows:
> >
> > commit e1b2772ea957c91694aa91b90e4c0a1d7b0fb144
> > Author: Krishna Kurapati <quic_kriskura@quicinc.com>
> > Date:   Mon Oct 14 14:14:30 2024 +0530
> >
> >      dt-bindings: phy: qcom,msm8998-qmp-usb3-phy: Add support for QCS615
> >
> > As mentioned in the cover letter, the bindings of phy have been merged
> > from v1.
>
> Hi Vinod,
>
>   Can you help in taking in the patch-3. As mentioned in previous mail,
> the bindings are merged and present in linux-next.

We are currently in the merge window, no new patches can be accepted.
Vinod Koul Feb. 14, 2025, 12:30 p.m. UTC | #9 
On 23-01-25, 09:23, Dmitry Baryshkov wrote:
> On Thu, 23 Jan 2025 at 09:00, Krishna Kurapati
> <krishna.kurapati@oss.qualcomm.com> wrote:

> > > As mentioned in the cover letter, the bindings of phy have been merged
> > > from v1.
> >
> > Hi Vinod,
> >
> >   Can you help in taking in the patch-3. As mentioned in previous mail,
> > the bindings are merged and present in linux-next.

Can you pls post it after rebasing