| Message ID | 0c7116ca03997fff04faf59fdcd4c97820685b64.1737118595.git.geert+renesas@glider.be |
|---|---|
| State | Superseded |
| Headers | show |
| Series | LAN966x PCIe endpoint cleanups | expand |
Hi Geert, On Fri, 17 Jan 2025 14:04:38 +0100 Geert Uytterhoeven <geert+renesas@glider.be> wrote: > The Microchip LAN966X SerDes PHY is only present on Microchip LAN966x > SoCs. However, when used as a PCI endpoint, all peripherals of the > LAN966x SoC can be accessed by the PCI host. Hence add dependencies on ^^ Two spaces > SOC_LAN966 and MFD_LAN966X_PCI, to prevent asking the user about this s/MFD_LAN966X_PCI/MCHP_LAN966X_PCI/ > driver when configuring a kernel without Microchip LAN966x SoC and PCIe > support. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> With those minor things fixed, Acked-by: Herve Codina <herve.codina@bootlin.com> Best regards, Hervé
Hi Hervé, On Mon, Jan 20, 2025 at 9:07 AM Herve Codina <herve.codina@bootlin.com> wrote: > On Fri, 17 Jan 2025 14:04:38 +0100 > Geert Uytterhoeven <geert+renesas@glider.be> wrote: > > The Microchip LAN966X SerDes PHY is only present on Microchip LAN966x > > SoCs. However, when used as a PCI endpoint, all peripherals of the > > LAN966x SoC can be accessed by the PCI host. Hence add dependencies on > ^^ Two spaces That's intentional: more space after a period terminating a sentence... > > SOC_LAN966 and MFD_LAN966X_PCI, to prevent asking the user about this > > s/MFD_LAN966X_PCI/MCHP_LAN966X_PCI/ Bummer, how did I miss that? > > driver when configuring a kernel without Microchip LAN966x SoC and PCIe > > support. > > > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > > With those minor things fixed, > > Acked-by: Herve Codina <herve.codina@bootlin.com> Thanks! Gr{oetje,eeting}s, Geert
diff --git a/drivers/phy/microchip/Kconfig b/drivers/phy/microchip/Kconfig index 38039ed0754c6548..2f0045e874ac81ad 100644 --- a/drivers/phy/microchip/Kconfig +++ b/drivers/phy/microchip/Kconfig @@ -15,6 +15,7 @@ config PHY_SPARX5_SERDES config PHY_LAN966X_SERDES tristate "SerDes PHY driver for Microchip LAN966X" select GENERIC_PHY + depends on SOC_LAN966 || MCHP_LAN966X_PCI || COMPILE_TEST depends on OF depends on MFD_SYSCON help
The Microchip LAN966X SerDes PHY is only present on Microchip LAN966x SoCs. However, when used as a PCI endpoint, all peripherals of the LAN966x SoC can be accessed by the PCI host. Hence add dependencies on SOC_LAN966 and MFD_LAN966X_PCI, to prevent asking the user about this driver when configuring a kernel without Microchip LAN966x SoC and PCIe support. Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- v2: - New. --- drivers/phy/microchip/Kconfig | 1 + 1 file changed, 1 insertion(+)