| Message ID | 1621939832-65535-1-git-send-email-yang.lee@linux.alibaba.com |
|---|---|
| State | Accepted |
| Commit | b8203ec7f58ae925e10fadd3d136073ae7503a6e |
| Headers | show |
| Series | phy: ti: Fix an error code in wiz_probe() | expand |
On 25-05-21, 18:50, Yang Li wrote: > When the code execute this if statement, the value of ret is 0. > However, we can see from the dev_err() log that the value of > ret should be -EINVAL. > > Clean up smatch warning: > > drivers/phy/ti/phy-j721e-wiz.c:1216 wiz_probe() warn: missing error code > 'ret' Single line is fine for this > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Fixes: 'commit c9f9eba06629 ("phy: ti: j721e-wiz: Manage > typec-gpio-dir")' Please dont split to two lines for fixes tag > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> I have fixed while applying so Applied, thanks > --- > drivers/phy/ti/phy-j721e-wiz.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/phy/ti/phy-j721e-wiz.c b/drivers/phy/ti/phy-j721e-wiz.c > index 9eb6d37..126f5b8 100644 > --- a/drivers/phy/ti/phy-j721e-wiz.c > +++ b/drivers/phy/ti/phy-j721e-wiz.c > @@ -1212,6 +1212,7 @@ static int wiz_probe(struct platform_device *pdev) > > if (wiz->typec_dir_delay < WIZ_TYPEC_DIR_DEBOUNCE_MIN || > wiz->typec_dir_delay > WIZ_TYPEC_DIR_DEBOUNCE_MAX) { > + ret = -EINVAL; > dev_err(dev, "Invalid typec-dir-debounce property\n"); > goto err_addr_to_resource; > } > -- > 1.8.3.1
diff --git a/drivers/phy/ti/phy-j721e-wiz.c b/drivers/phy/ti/phy-j721e-wiz.c index 9eb6d37..126f5b8 100644 --- a/drivers/phy/ti/phy-j721e-wiz.c +++ b/drivers/phy/ti/phy-j721e-wiz.c @@ -1212,6 +1212,7 @@ static int wiz_probe(struct platform_device *pdev) if (wiz->typec_dir_delay < WIZ_TYPEC_DIR_DEBOUNCE_MIN || wiz->typec_dir_delay > WIZ_TYPEC_DIR_DEBOUNCE_MAX) { + ret = -EINVAL; dev_err(dev, "Invalid typec-dir-debounce property\n"); goto err_addr_to_resource; }
When the code execute this if statement, the value of ret is 0. However, we can see from the dev_err() log that the value of ret should be -EINVAL. Clean up smatch warning: drivers/phy/ti/phy-j721e-wiz.c:1216 wiz_probe() warn: missing error code 'ret' Reported-by: Abaci Robot <abaci@linux.alibaba.com> Fixes: 'commit c9f9eba06629 ("phy: ti: j721e-wiz: Manage typec-gpio-dir")' Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> --- drivers/phy/ti/phy-j721e-wiz.c | 1 + 1 file changed, 1 insertion(+)