| Message ID | 1637822289-24534-1-git-send-email-zou_wei@huawei.com |
|---|---|
| State | Accepted |
| Commit | b2b56de9faaf19c829ede5cf56918b3793219971 |
| Headers | show |
| Series | [-next] phy: intel: Remove redundant dev_err call in thunderbay_emmc_phy_probe() | expand |
On 25-11-21, 14:38, Zou Wei wrote: > There is a error message within devm_ioremap_resource > already, so remove the dev_err call to avoid redundant > error message. Applied, thanks
diff --git a/drivers/phy/intel/phy-intel-thunderbay-emmc.c b/drivers/phy/intel/phy-intel-thunderbay-emmc.c index 2d6ea84..593f697 100644 --- a/drivers/phy/intel/phy-intel-thunderbay-emmc.c +++ b/drivers/phy/intel/phy-intel-thunderbay-emmc.c @@ -472,10 +472,8 @@ static int thunderbay_emmc_phy_probe(struct platform_device *pdev) res = platform_get_resource(pdev, IORESOURCE_MEM, 0); tbh_phy->reg_base = devm_ioremap_resource(&pdev->dev, res); - if (IS_ERR(tbh_phy->reg_base)) { - dev_err(&pdev->dev, "region map failed\n"); + if (IS_ERR(tbh_phy->reg_base)) return PTR_ERR(tbh_phy->reg_base); - } tbh_phy->phy_power_sts = PHY_UNINITIALIZED; id = of_match_node(thunderbay_emmc_phy_of_match, pdev->dev.of_node);
There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Zou Wei <zou_wei@huawei.com> --- drivers/phy/intel/phy-intel-thunderbay-emmc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)