diff mbox series

[-next] phy: marvell: phy-mvebu-cp11i-utmi needs USB_COMMON

Message ID 20210401210045.23525-1-rdunlap@infradead.org
State Accepted
Commit 183bf0917e491e83881ccf6fb7d3df0aa843b756
Headers show
Series [-next] phy: marvell: phy-mvebu-cp11i-utmi needs USB_COMMON | expand

Commit Message

Randy Dunlap April 1, 2021, 9 p.m. UTC
When USB and USB_COMMON are not enabled, phy-mvebu-cp110-utmi
suffers a build error due to a missing interface that is provided
by CONFIG_USB_COMMON, so make the driver depend on USB_COMMON.

ld: drivers/phy/marvell/phy-mvebu-cp110-utmi.o: in function `mvebu_cp110_utmi_phy_probe':
phy-mvebu-cp110-utmi.c:(.text+0x152): undefined reference to `of_usb_get_dr_mode_by_phy'

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Kostya Porotchkin <kostap@marvell.com>
Cc: Kishon Vijay Abraham I <kishon@ti.com>
Cc: Vinod Koul <vkoul@kernel.org>
Cc: linux-phy@lists.infradead.org
---
 drivers/phy/marvell/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Vinod Koul April 6, 2021, 5:04 a.m. UTC | #1
On 01-04-21, 14:00, Randy Dunlap wrote:
> When USB and USB_COMMON are not enabled, phy-mvebu-cp110-utmi
> suffers a build error due to a missing interface that is provided
> by CONFIG_USB_COMMON, so make the driver depend on USB_COMMON.
> 
> ld: drivers/phy/marvell/phy-mvebu-cp110-utmi.o: in function `mvebu_cp110_utmi_phy_probe':
> phy-mvebu-cp110-utmi.c:(.text+0x152): undefined reference to `of_usb_get_dr_mode_by_phy'

Applied, thanks
diff mbox series

Patch

--- linux-next-20210331.orig/drivers/phy/marvell/Kconfig
+++ linux-next-20210331/drivers/phy/marvell/Kconfig
@@ -70,7 +70,7 @@  config PHY_MVEBU_CP110_COMPHY
 config PHY_MVEBU_CP110_UTMI
 	tristate "Marvell CP110 UTMI driver"
 	depends on ARCH_MVEBU || COMPILE_TEST
-	depends on OF
+	depends on OF && USB_COMMON
 	select GENERIC_PHY
 	help
 	  Enable this to support Marvell CP110 UTMI PHY driver.