| Message ID | 20210408012829.432938-1-liushixin2@huawei.com |
|---|---|
| State | Accepted |
| Commit | e41769df343fa0ad30a5b1d22652c2e2b02a5f74 |
| Headers | show |
| Series | [-next] phy: ti: j721e-wiz: Add missing include linux/slab.h | expand |
On 08-04-21, 09:28, Shixin Liu wrote: > When compiling with CONFIG_PHY_J721E_WIZ, Hulk Robot reported: > > drivers/phy/ti/phy-j721e-wiz.c: In function ‘wiz_mux_clk_register’: > drivers/phy/ti/phy-j721e-wiz.c:659:17: error: implicit declaration of function ‘kzalloc’; did you mean ‘vzalloc’? [-Werror=implicit-function-declaration] > 659 | parent_names = kzalloc((sizeof(char *) * num_parents), GFP_KERNEL); > | ^~~~~~~ > | vzalloc > drivers/phy/ti/phy-j721e-wiz.c:659:15: warning: assignment to ‘const char **’ from ‘int’ makes pointer from integer without a cast [-Wint-conversion] > 659 | parent_names = kzalloc((sizeof(char *) * num_parents), GFP_KERNEL); > | ^ > drivers/phy/ti/phy-j721e-wiz.c:697:2: error: implicit declaration of function ‘kfree’; did you mean ‘vfree’? [-Werror=implicit-function-declaration] > 697 | kfree(parent_names); > | ^~~~~ > | vfre Applied, thanks
diff --git a/drivers/phy/ti/phy-j721e-wiz.c b/drivers/phy/ti/phy-j721e-wiz.c index 2b354680a272..ab28fb2e01db 100644 --- a/drivers/phy/ti/phy-j721e-wiz.c +++ b/drivers/phy/ti/phy-j721e-wiz.c @@ -8,6 +8,7 @@ #include <dt-bindings/phy/phy.h> #include <dt-bindings/phy/phy-ti.h> +#include <linux/slab.h> #include <linux/clk.h> #include <linux/clk-provider.h> #include <linux/gpio.h>
When compiling with CONFIG_PHY_J721E_WIZ, Hulk Robot reported: drivers/phy/ti/phy-j721e-wiz.c: In function ‘wiz_mux_clk_register’: drivers/phy/ti/phy-j721e-wiz.c:659:17: error: implicit declaration of function ‘kzalloc’; did you mean ‘vzalloc’? [-Werror=implicit-function-declaration] 659 | parent_names = kzalloc((sizeof(char *) * num_parents), GFP_KERNEL); | ^~~~~~~ | vzalloc drivers/phy/ti/phy-j721e-wiz.c:659:15: warning: assignment to ‘const char **’ from ‘int’ makes pointer from integer without a cast [-Wint-conversion] 659 | parent_names = kzalloc((sizeof(char *) * num_parents), GFP_KERNEL); | ^ drivers/phy/ti/phy-j721e-wiz.c:697:2: error: implicit declaration of function ‘kfree’; did you mean ‘vfree’? [-Werror=implicit-function-declaration] 697 | kfree(parent_names); | ^~~~~ | vfre Fixes: 040cbe768731 ("phy: ti: j721e-wiz: Model the internal clocks without device tree input") Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Shixin Liu <liushixin2@huawei.com> --- drivers/phy/ti/phy-j721e-wiz.c | 1 + 1 file changed, 1 insertion(+)