diff mbox series

[v6,1/5] Documentation/bindings: phy: update references to cp11x

Message ID 20210708112528.3254-2-kostap@marvell.com
State Superseded
Headers show
Series DTS updates for Marvell Armada CN913x platforms | expand

Commit Message

Kostya Porotchkin July 8, 2021, 11:25 a.m. UTC
From: Grzegorz Jaszczyk <jaz@semihalf.com>

The cp11x references in dts has changed, reflect it in comphy
documentation.

Signed-off-by: Grzegorz Jaszczyk <jaz@semihalf.com>
Signed-off-by: Konstantin Porotchkin <kostap@marvell.com>
---
 Documentation/devicetree/bindings/phy/phy-mvebu-comphy.txt | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

Comments

Russell King (Oracle) July 8, 2021, 11:31 a.m. UTC | #1
On Thu, Jul 08, 2021 at 02:25:24PM +0300, kostap@marvell.com wrote:
> From: Grzegorz Jaszczyk <jaz@semihalf.com>
> 
> The cp11x references in dts has changed, reflect it in comphy
> documentation.
> 
> Signed-off-by: Grzegorz Jaszczyk <jaz@semihalf.com>
> Signed-off-by: Konstantin Porotchkin <kostap@marvell.com>

I don't think it's really necessary to reflect the syntactic sugar
that gets used to cope with the fact we have two CP11x dies in the
DT examples. They are exactly that - an example of the usage. They
don't need to reflect reality.
Kostya Porotchkin July 8, 2021, 11:40 a.m. UTC | #2
Hi, Russell,

No problem, we can drop it. This patch is not an absolutely necessary one.
We just tried to keep the documentation clean.

Regards
Kosta

> -----Original Message-----
> From: Russell King <linux@armlinux.org.uk>
> Sent: Thursday, July 8, 2021 14:31
> To: Kostya Porotchkin <kostap@marvell.com>
> Cc: miquel.raynal@bootlin.com; kishon@ti.com; vkoul@kernel.org;
> robh+dt@kernel.org; andrew@lunn.ch; gregory.clement@bootlin.com;
> sebastian.hesselbarth@gmail.com; vladimir.vid@sartura.hr;
> luka.kovacic@sartura.hr; linux-phy@lists.infradead.org;
> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; linux-arm-
> kernel@lists.infradead.org; mw@semihalf.com; jaz@semihalf.com; Nadav
> Haklai <nadavh@marvell.com>; Stefan Chulski <stefanc@marvell.com>; Ben
> Peled <bpeled@marvell.com>
> Subject: [EXT] Re: [PATCH v6 1/5] Documentation/bindings: phy: update
> references to cp11x
> 
> External Email
> 
> ----------------------------------------------------------------------
> On Thu, Jul 08, 2021 at 02:25:24PM +0300, kostap@marvell.com wrote:
> > From: Grzegorz Jaszczyk <jaz@semihalf.com>
> >
> > The cp11x references in dts has changed, reflect it in comphy
> > documentation.
> >
> > Signed-off-by: Grzegorz Jaszczyk <jaz@semihalf.com>
> > Signed-off-by: Konstantin Porotchkin <kostap@marvell.com>
> 
> I don't think it's really necessary to reflect the syntactic sugar that gets used
> to cope with the fact we have two CP11x dies in the DT examples. They are
> exactly that - an example of the usage. They don't need to reflect reality.
> 
> --
> RMK's Patch system: https://urldefense.proofpoint.com/v2/url?u=https-
> 3A__www.armlinux.org.uk_developer_patches_&d=DwIBAg&c=nKjWec2b6R0
> mOyPaz7xtfQ&r=-
> N9sN4p5NSr0JGQoQ_2UCOgAqajG99W1EbSOww0WU8o&m=8YiUSNpFqlwKlD
> nf3QTGe2_zTXQ_qyiXoSj1RIkXuY4&s=JjkSKqB5ZgxxFXzzx098Zw9w2NT28SuQC
> KUItzqNpv4&e=
> FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/phy/phy-mvebu-comphy.txt b/Documentation/devicetree/bindings/phy/phy-mvebu-comphy.txt
index 8c60e6985950..5ffd0f55d010 100644
--- a/Documentation/devicetree/bindings/phy/phy-mvebu-comphy.txt
+++ b/Documentation/devicetree/bindings/phy/phy-mvebu-comphy.txt
@@ -42,22 +42,22 @@  Required properties (child nodes):
 
 Examples:
 
-	cpm_comphy: phy@120000 {
+	CP11X_LABEL(comphy): phy@120000 {
 		compatible = "marvell,comphy-cp110";
 		reg = <0x120000 0x6000>;
-		marvell,system-controller = <&cpm_syscon0>;
-		clocks = <&CP110_LABEL(clk) 1 5>, <&CP110_LABEL(clk) 1 6>,
-			 <&CP110_LABEL(clk) 1 18>;
+		marvell,system-controller = <&CP11X_LABEL(syscon0)>;
+		clocks = <&CP11X_LABEL(clk) 1 5>, <&CP11X_LABEL(clk) 1 6>,
+			 <&CP11X_LABEL(clk) 1 18>;
 		clock-names = "mg_clk", "mg_core_clk", "axi_clk";
 		#address-cells = <1>;
 		#size-cells = <0>;
 
-		cpm_comphy0: phy@0 {
+		CP11X_LABEL(comphy0): phy@0 {
 			reg = <0>;
 			#phy-cells = <1>;
 		};
 
-		cpm_comphy1: phy@1 {
+		CP11X_LABEL(comphy1): phy@1 {
 			reg = <1>;
 			#phy-cells = <1>;
 		};