| Message ID | 20210716103651.1455-3-linux.amoon@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Meson-8b and Meson-gxbb Fix some missing code | expand |
Hi Anand, On Fri, Jul 16, 2021 at 12:38 PM Anand Moon <linux.amoon@gmail.com> wrote: > > Fix the chip enable signal changing from Active High to Active Low > to enable input power to USB power. Also updated signal name as per > the shematics. typo: shematics -> schematics > > Fixes: 5a0803bd5ae2 ("ARM64: dts: meson-gxbb-odroidc2: Enable USB Nodes") > > Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com> I don't have an Odroid-C2 so I will not be able to review this as well as the Odroid-C1 patch. My suggestion is that we discuss the Odroid-C1 patch first as that's some hardware that we both have. Once I understand how the Odroid-C1 patch works I can at least give my Acked-by on the Odroid-C2 change. Best regards, Martin
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts index 201596247fd9..3f4f16a5dedd 100644 --- a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts @@ -38,12 +38,11 @@ usb_otg_pwr: regulator-usb-pwrs { regulator-max-microvolt = <5000000>; /* - * signal name from schematics: PWREN + * signal name from schematics: PWREN - GPIOAO.BIT5 */ - gpio = <&gpio_ao GPIOAO_5 GPIO_ACTIVE_HIGH>; - enable-active-high; + gpios = <&gpio_ao GPIOAO_5 GPIO_ACTIVE_LOW>; /* - * signal name from schematics: USB_POWER + * signal name from schematics: USB_POWER - P5V0 */ vin-supply = <&p5v0>; };
Fix the chip enable signal changing from Active High to Active Low to enable input power to USB power. Also updated signal name as per the shematics. Fixes: 5a0803bd5ae2 ("ARM64: dts: meson-gxbb-odroidc2: Enable USB Nodes") Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com> Signed-off-by: Anand Moon <linux.amoon@gmail.com> --- New patch in this series --- arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)