| Message ID | 20210817041548.1276-5-linux.amoon@gmail.com |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | Meson-8b and Meson-gxbb Fix some missing code | expand |
Hi Anand, On Tue, Aug 17, 2021 at 6:18 AM Anand Moon <linux.amoon@gmail.com> wrote: > > Use vbus-supply instead of phy-supply as power source for dwc2 > nodes. Drop vbus-supply for usb0 node, as it will handle later. This is more of a question than a review comment: Do you think that the USB power setup on Odroid-C1 and Odroid-C2 is different or the same? On Odroid-C1 we know that only the PWREN signal which goes to the Micro-USB connector is configurable while VBUS for the USB host ports is always enabled. > Fixes: e841ec956e53 ("ARM64: dts: meson-gxbb-odroidc2: > fix usb1 power supply") > most Linux commits which I have seen don't use a blank line here Also I think it's recommended not to break the "Fixes" tag into multiple lines, even if the text is long see [0] for example Best regards, Martin [0] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=425bec0032f59eeee12520085cd054fac09cc66e
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts index 3f4f16a5dedd..01bbfc4c091e 100644 --- a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts @@ -400,12 +400,10 @@ &uart_AO { &usb0_phy { status = "disabled"; - phy-supply = <&usb_otg_pwr>; }; &usb1_phy { status = "okay"; - phy-supply = <&usb_otg_pwr>; }; &usb0 { @@ -414,4 +412,5 @@ &usb0 { &usb1 { status = "okay"; + vbus-supply = <&usb_otg_pwr>; };
Use vbus-supply instead of phy-supply as power source for dwc2 nodes. Drop vbus-supply for usb0 node, as it will handle later. Fixes: e841ec956e53 ("ARM64: dts: meson-gxbb-odroidc2: fix usb1 power supply") Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com> Signed-off-by: Anand Moon <linux.amoon@gmail.com> --- New patch in this series. --- arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)