| Message ID | 20210927044824.30246-2-shawn.guo@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add missing vdd-supply for QUSB2 PHY | expand |
On Mon, 27 Sep 2021 12:48:22 +0800, Shawn Guo wrote: > Besides vdda-pll and vdda-phy-dpdm, vdd-supply is a required supply for > PHY digital circuit operation. Add it for correctness and completeness. > > Signed-off-by: Shawn Guo <shawn.guo@linaro.org> > --- > Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,qusb2-phy.example.dt.yaml: phy@7411000: 'vdd-supply' does not match any of the regexes: 'pinctrl-[0-9]+' From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/1533177 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
On Mon, Sep 27, 2021 at 12:48:22PM +0800, Shawn Guo wrote: > Besides vdda-pll and vdda-phy-dpdm, vdd-supply is a required supply for > PHY digital circuit operation. Add it for correctness and completeness. > > Signed-off-by: Shawn Guo <shawn.guo@linaro.org> > --- > Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml > index 48ae604b2194..96e31f582fc9 100644 > --- a/Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml > +++ b/Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml > @@ -51,6 +51,10 @@ properties: > - const: ref > - const: iface > > + vdda-supply: Oops, it should be `vdd-supply`. Will fix it in v2. Shawn > + description: > + Phandle to 0.9V regulator supply to PHY digital circuit. > + > vdda-pll-supply: > description: > Phandle to 1.8V regulator supply to PHY refclk pll block. > @@ -157,6 +161,7 @@ required: > - "#phy-cells" > - clocks > - clock-names > + - vdd-supply > - vdda-pll-supply > - vdda-phy-dpdm-supply > - resets > @@ -175,6 +180,7 @@ examples: > <&gcc GCC_RX1_USB2_CLKREF_CLK>; > clock-names = "cfg_ahb", "ref"; > > + vdd-supply = <&pm8994_l28>; > vdda-pll-supply = <&pm8994_l12>; > vdda-phy-dpdm-supply = <&pm8994_l24>; > > -- > 2.17.1 >
diff --git a/Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml index 48ae604b2194..96e31f582fc9 100644 --- a/Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml @@ -51,6 +51,10 @@ properties: - const: ref - const: iface + vdda-supply: + description: + Phandle to 0.9V regulator supply to PHY digital circuit. + vdda-pll-supply: description: Phandle to 1.8V regulator supply to PHY refclk pll block. @@ -157,6 +161,7 @@ required: - "#phy-cells" - clocks - clock-names + - vdd-supply - vdda-pll-supply - vdda-phy-dpdm-supply - resets @@ -175,6 +180,7 @@ examples: <&gcc GCC_RX1_USB2_CLKREF_CLK>; clock-names = "cfg_ahb", "ref"; + vdd-supply = <&pm8994_l28>; vdda-pll-supply = <&pm8994_l12>; vdda-phy-dpdm-supply = <&pm8994_l24>;
Besides vdda-pll and vdda-phy-dpdm, vdd-supply is a required supply for PHY digital circuit operation. Add it for correctness and completeness. Signed-off-by: Shawn Guo <shawn.guo@linaro.org> --- Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml | 6 ++++++ 1 file changed, 6 insertions(+)