diff mbox series

[02/10] dt-bindings: phy: qcom, qmp: IPQ6018 and IPQ8074 PCIe PHY require no supply

Message ID 20210929034253.24570-3-shawn.guo@linaro.org
State Not Applicable
Headers show
Series Make Qualcomm QMP PHY dtbs_check warning free | expand

Commit Message

Shawn Guo Sept. 29, 2021, 3:42 a.m. UTC
The qmp-phy driver suggests that 'vdda-phy-supply' and 'vdda-pll-supply'
are not required for IPQ6018 and IPQ8074 QMP PCIe PHY.  Update the
bindings to reflect it.

While at it, also correct the clock properies for IPQ8074 QMP PCIe PHY.
And as the result, 'qcom,ipq8074-qmp-pcie-phy' and
'qcom,ipq6018-qmp-pcie-phy' share the same clock, reset and supply
bindings.

Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
---
 .../devicetree/bindings/phy/qcom,qmp-phy.yaml | 52 ++++++++++---------
 1 file changed, 28 insertions(+), 24 deletions(-)

Comments

Rob Herring (Arm) Oct. 4, 2021, 6:43 p.m. UTC | #1
On Wed, 29 Sep 2021 11:42:45 +0800, Shawn Guo wrote:
> The qmp-phy driver suggests that 'vdda-phy-supply' and 'vdda-pll-supply'
> are not required for IPQ6018 and IPQ8074 QMP PCIe PHY.  Update the
> bindings to reflect it.
> 
> While at it, also correct the clock properies for IPQ8074 QMP PCIe PHY.
> And as the result, 'qcom,ipq8074-qmp-pcie-phy' and
> 'qcom,ipq6018-qmp-pcie-phy' share the same clock, reset and supply
> bindings.
> 
> Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
> ---
>  .../devicetree/bindings/phy/qcom,qmp-phy.yaml | 52 ++++++++++---------
>  1 file changed, 28 insertions(+), 24 deletions(-)
> 

Reviewed-by: Rob Herring <robh@kernel.org>
Vinod Koul Oct. 5, 2021, 6:34 a.m. UTC | #2
On 29-09-21, 11:42, Shawn Guo wrote:
> The qmp-phy driver suggests that 'vdda-phy-supply' and 'vdda-pll-supply'
> are not required for IPQ6018 and IPQ8074 QMP PCIe PHY.  Update the
> bindings to reflect it.
> 
> While at it, also correct the clock properies for IPQ8074 QMP PCIe PHY.
> And as the result, 'qcom,ipq8074-qmp-pcie-phy' and
> 'qcom,ipq6018-qmp-pcie-phy' share the same clock, reset and supply
> bindings.

Acked-By: Vinod Koul <vkoul@kernel.org>
Bjorn Andersson Oct. 5, 2021, 3:47 p.m. UTC | #3
On Mon 04 Oct 23:34 PDT 2021, Vinod Koul wrote:

> On 29-09-21, 11:42, Shawn Guo wrote:
> > The qmp-phy driver suggests that 'vdda-phy-supply' and 'vdda-pll-supply'
> > are not required for IPQ6018 and IPQ8074 QMP PCIe PHY.  Update the
> > bindings to reflect it.
> > 
> > While at it, also correct the clock properies for IPQ8074 QMP PCIe PHY.
> > And as the result, 'qcom,ipq8074-qmp-pcie-phy' and
> > 'qcom,ipq6018-qmp-pcie-phy' share the same clock, reset and supply
> > bindings.
> 
> Acked-By: Vinod Koul <vkoul@kernel.org>
> 

I think it's better if you take the two dt-bindings through your tree,
so we avoid any potential merge conflicts related to possible other
changes.

Regards,
Bjorn
Vinod Koul Oct. 7, 2021, 8:56 a.m. UTC | #4
On 05-10-21, 08:47, Bjorn Andersson wrote:
> On Mon 04 Oct 23:34 PDT 2021, Vinod Koul wrote:
> 
> > On 29-09-21, 11:42, Shawn Guo wrote:
> > > The qmp-phy driver suggests that 'vdda-phy-supply' and 'vdda-pll-supply'
> > > are not required for IPQ6018 and IPQ8074 QMP PCIe PHY.  Update the
> > > bindings to reflect it.
> > > 
> > > While at it, also correct the clock properies for IPQ8074 QMP PCIe PHY.
> > > And as the result, 'qcom,ipq8074-qmp-pcie-phy' and
> > > 'qcom,ipq6018-qmp-pcie-phy' share the same clock, reset and supply
> > > bindings.
> > 
> > Acked-By: Vinod Koul <vkoul@kernel.org>
> > 
> 
> I think it's better if you take the two dt-bindings through your tree,
> so we avoid any potential merge conflicts related to possible other
> changes.

Okay picked up the binding patches
Vinod Koul Oct. 19, 2021, 6:07 p.m. UTC | #5
Hi Shawn,

On 07-10-21, 14:26, Vinod Koul wrote:
> On 05-10-21, 08:47, Bjorn Andersson wrote:
> > On Mon 04 Oct 23:34 PDT 2021, Vinod Koul wrote:
> > 
> > > On 29-09-21, 11:42, Shawn Guo wrote:
> > > > The qmp-phy driver suggests that 'vdda-phy-supply' and 'vdda-pll-supply'
> > > > are not required for IPQ6018 and IPQ8074 QMP PCIe PHY.  Update the
> > > > bindings to reflect it.
> > > > 
> > > > While at it, also correct the clock properies for IPQ8074 QMP PCIe PHY.
> > > > And as the result, 'qcom,ipq8074-qmp-pcie-phy' and
> > > > 'qcom,ipq6018-qmp-pcie-phy' share the same clock, reset and supply
> > > > bindings.
> > > 
> > > Acked-By: Vinod Koul <vkoul@kernel.org>
> > > 
> > 
> > I think it's better if you take the two dt-bindings through your tree,
> > so we avoid any potential merge conflicts related to possible other
> > changes.
> 
> Okay picked up the binding patches

This failed to apply for me, can you please rebase and send

Thanks
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
index 604435e46623..ed62dde5f97d 100644
--- a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
@@ -112,8 +112,6 @@  required:
   - clock-names
   - resets
   - reset-names
-  - vdda-phy-supply
-  - vdda-pll-supply
 
 additionalProperties: false
 
@@ -146,6 +144,9 @@  allOf:
           items:
             - const: phy
             - const: common
+      required:
+        - vdda-phy-supply
+        - vdda-pll-supply
   - if:
       properties:
         compatible:
@@ -172,6 +173,9 @@  allOf:
           items:
             - const: phy
             - const: common
+      required:
+        - vdda-phy-supply
+        - vdda-pll-supply
   - if:
       properties:
         compatible:
@@ -200,6 +204,9 @@  allOf:
             - const: phy
             - const: common
             - const: cfg
+      required:
+        - vdda-phy-supply
+        - vdda-pll-supply
   - if:
       properties:
         compatible:
@@ -229,6 +236,9 @@  allOf:
           items:
             - const: phy
             - const: common
+      required:
+        - vdda-phy-supply
+        - vdda-pll-supply
   - if:
       properties:
         compatible:
@@ -249,6 +259,9 @@  allOf:
         reset-names:
           items:
             - const: ufsphy
+      required:
+        - vdda-phy-supply
+        - vdda-pll-supply
   - if:
       properties:
         compatible:
@@ -274,34 +287,16 @@  allOf:
         reset-names:
           items:
             - const: ufsphy
-  - if:
-      properties:
-        compatible:
-          contains:
-            enum:
-              - qcom,ipq8074-qmp-pcie-phy
-    then:
-      properties:
-        clocks:
-          items:
-            - description: pipe clk.
-        clock-names:
-          items:
-            - const: pipe_clk
-        resets:
-          items:
-            - description: reset of phy block.
-            - description: phy common block reset.
-        reset-names:
-          items:
-            - const: phy
-            - const: common
+      required:
+        - vdda-phy-supply
+        - vdda-pll-supply
   - if:
       properties:
         compatible:
           contains:
             enum:
               - qcom,ipq6018-qmp-pcie-phy
+              - qcom,ipq8074-qmp-pcie-phy
     then:
       properties:
         clocks:
@@ -352,6 +347,9 @@  allOf:
         reset-names:
           items:
             - const: phy
+      required:
+        - vdda-phy-supply
+        - vdda-pll-supply
   - if:
       properties:
         compatible:
@@ -383,6 +381,9 @@  allOf:
           items:
             - const: phy
             - const: common
+      required:
+        - vdda-phy-supply
+        - vdda-pll-supply
   - if:
       properties:
         compatible:
@@ -410,6 +411,9 @@  allOf:
           items:
             - const: phy
             - const: common
+      required:
+        - vdda-phy-supply
+        - vdda-pll-supply
 
 examples:
   - |