Message ID | 20211028184242.22105-7-kabel@kernel.org |
---|---|
State | Superseded |
Headers | show |
Series | Armada 3720 comphy native implementation | expand |
Hi Marek, kabel@kernel.org wrote on Thu, 28 Oct 2021 20:42:42 +0200: > From: Pali Rohár <pali@kernel.org> > > This reverts commit b0c6ae0f8948a2be6bf4e8b4bbab9ca1343289b6. > > Armada 3720 phy driver (phy-mvebu-a3700-comphy.c) does not return > -EOPNOTSUPP from phy_power_on() callback anymore. > > So remove dead code which handles -EOPNOTSUPP return value. > > Signed-off-by: Pali Rohár <pali@kernel.org> > Signed-off-by: Marek Behún <kabel@kernel.org> > --- If commit 2/6 is applied: Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com> Thanks, Miquèl
diff --git a/drivers/pci/controller/pci-aardvark.c b/drivers/pci/controller/pci-aardvark.c index 596ebcfcc82d..b32fc1efd633 100644 --- a/drivers/pci/controller/pci-aardvark.c +++ b/drivers/pci/controller/pci-aardvark.c @@ -1349,9 +1349,7 @@ static int advk_pcie_enable_phy(struct advk_pcie *pcie) } ret = phy_power_on(pcie->phy); - if (ret == -EOPNOTSUPP) { - dev_warn(&pcie->pdev->dev, "PHY unsupported by firmware\n"); - } else if (ret) { + if (ret) { phy_exit(pcie->phy); return ret; }