diff mbox series

phy/cadence: Use of_device_get_match_data()

Message ID 20220214020626.1714696-1-chi.minghao@zte.com.cn
State Accepted
Commit 10c573c61338d80c271f3579da22772c483d8a7a
Headers show
Series phy/cadence: Use of_device_get_match_data() | expand

Commit Message

CGEL Feb. 14, 2022, 2:06 a.m. UTC 
From: "Minghao Chi (CGEL ZTE)" <chi.minghao@zte.com.cn>

Use of_device_get_match_data() instead of open-coding it.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Minghao Chi (CGEL ZTE) <chi.minghao@zte.com.cn>
---
 drivers/phy/cadence/phy-cadence-salvo.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

Comments

Vinod Koul Feb. 25, 2022, 8:28 a.m. UTC | #1 
On 14-02-22, 02:06, cgel.zte@gmail.com wrote:
> From: "Minghao Chi (CGEL ZTE)" <chi.minghao@zte.com.cn>
> 
> Use of_device_get_match_data() instead of open-coding it.

Applied, thanks
diff mbox series

Patch

diff --git a/drivers/phy/cadence/phy-cadence-salvo.c b/drivers/phy/cadence/phy-cadence-salvo.c
index 51c0b98f5fd7..e569f5f67578 100644
--- a/drivers/phy/cadence/phy-cadence-salvo.c
+++ b/drivers/phy/cadence/phy-cadence-salvo.c
@@ -263,14 +263,9 @@  static int cdns_salvo_phy_probe(struct platform_device *pdev)
 	struct phy_provider *phy_provider;
 	struct device *dev = &pdev->dev;
 	struct cdns_salvo_phy *salvo_phy;
-	const struct of_device_id *match;
 	struct cdns_salvo_data *data;
 
-	match = of_match_device(cdns_salvo_phy_of_match, dev);
-	if (!match)
-		return -EINVAL;
-
-	data = (struct cdns_salvo_data *)match->data;
+	data = (struct cdns_salvo_data *)of_device_get_match_data(dev);
 	salvo_phy = devm_kzalloc(dev, sizeof(*salvo_phy), GFP_KERNEL);
 	if (!salvo_phy)
 		return -ENOMEM;