| Message ID | 20220316024155.23464-1-linmq006@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | phy: ti: omap-usb2: Fix error handling in omap_usb2_enable_clocks | expand |
On Wed, Mar 16, 2022 at 02:41:53AM +0000, Miaoqian Lin wrote: > The corresponding API for clk_prepare_enable is clk_disable_unprepare, > other than clk_disable_unprepare. > > Fix this by changing clk_disable to clk_disable_unprepare. There seems to be a typo in the first sentence of the commit message. Maybe something like this would do: The corresponding API for clk_prepare_enable is clk_disable_unprepare. Make sure that the clock is unprepared on exit by changing clk_disable to clk_disable_unprepare. > > Fixes: ed31ee7cf1fe ("phy: ti: usb2: Fix logic on -EPROBE_DEFER") > Signed-off-by: Miaoqian Lin <linmq006@gmail.com> Other than that, Reviewed-by: Liam Beguin <liambeguin@gmail.com> > --- > drivers/phy/ti/phy-omap-usb2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/phy/ti/phy-omap-usb2.c b/drivers/phy/ti/phy-omap-usb2.c > index 3a505fe5715a..31a775877f6e 100644 > --- a/drivers/phy/ti/phy-omap-usb2.c > +++ b/drivers/phy/ti/phy-omap-usb2.c > @@ -215,7 +215,7 @@ static int omap_usb2_enable_clocks(struct omap_usb *phy) > return 0; > > err1: > - clk_disable(phy->wkupclk); > + clk_disable_unprepare(phy->wkupclk); > > err0: > return ret; > -- > 2.17.1 >
diff --git a/drivers/phy/ti/phy-omap-usb2.c b/drivers/phy/ti/phy-omap-usb2.c index 3a505fe5715a..31a775877f6e 100644 --- a/drivers/phy/ti/phy-omap-usb2.c +++ b/drivers/phy/ti/phy-omap-usb2.c @@ -215,7 +215,7 @@ static int omap_usb2_enable_clocks(struct omap_usb *phy) return 0; err1: - clk_disable(phy->wkupclk); + clk_disable_unprepare(phy->wkupclk); err0: return ret;
The corresponding API for clk_prepare_enable is clk_disable_unprepare, other than clk_disable_unprepare. Fix this by changing clk_disable to clk_disable_unprepare. Fixes: ed31ee7cf1fe ("phy: ti: usb2: Fix logic on -EPROBE_DEFER") Signed-off-by: Miaoqian Lin <linmq006@gmail.com> --- drivers/phy/ti/phy-omap-usb2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)