[RFC,v2,02/34] phy: qcom-qmp: add QMP PCIe PHY driver

Message ID	20220525235841.852301-3-dmitry.baryshkov@linaro.org
State	Superseded
Headers	show Return-Path: <linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org> From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> To: Andy Gross <agross@kernel.org>, Bjorn Andersson <bjorn.andersson@linaro.org>, Vinod Koul <vkoul@kernel.org>, Kishon Vijay Abraham I <kishon@ti.com> Cc: Philipp Zabel <p.zabel@pengutronix.de>, linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org Subject: [RFC PATCH v2 02/34] phy: qcom-qmp: add QMP PCIe PHY driver Date: Thu, 26 May 2022 02:58:09 +0300 Message-Id: <20220525235841.852301-3-dmitry.baryshkov@linaro.org> In-Reply-To: <20220525235841.852301-1-dmitry.baryshkov@linaro.org> References: <20220525235841.852301-1-dmitry.baryshkov@linaro.org> MIME-Version: 1.0 Precedence: list Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" <linux-phy-bounces@lists.infradead.org> Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org
Series	phy: qcom-qmp: split the QMP PHY driver \| expand [RFC,v2,00/34] phy: qcom-qmp: split the QMP PHY driver [RFC,v2,01/34] phy: qcom-qmp: add library source code [RFC,v2,02/34] phy: qcom-qmp: add QMP PCIe PHY driver [RFC,v2,03/34] phy: qcom-qmp: move MSM8996 PCIe PHY to new QMP driver [RFC,v2,04/34] phy: qcom-qmp: move MSM8998 PCIe PHY to new QMP driver [RFC,v2,05/34] phy: qcom-qmp: move SDM845 PCIe PHY to new QMP driver [RFC,v2,06/34] phy: qcom-qmp: move SM8250 PCIe PHY to new QMP driver [RFC,v2,07/34] phy: qcom-qmp: move IPQ6018 PCIe PHY to new QMP driver [RFC,v2,08/34] phy: qcom-qmp: move IPQ8074 PCIe PHY to new QMP driver [RFC,v2,09/34] phy: qcom-qmp: move SC8180x PCIe PHY to new QMP driver [RFC,v2,10/34] phy: qcom-qmp: move SDX55 PCIe PHY to new QMP driver [RFC,v2,11/34] phy: qcom-qmp: move SM8450 PCIe PHY to new QMP driver [RFC,v2,12/34] phy: qcom-qmp: add QMP UFS PHY driver [RFC,v2,13/34] phy: qcom-qmp: move MSM8996 UFS PHY to new QMP driver [RFC,v2,14/34] phy: qcom-qmp: move MSM8998, SDM845 and SM6350 UFS PHY to new QMP driver [RFC,v2,15/34] phy: qcom-qmp: move SC8180x, SM8150 and SM8250 UFS PHY to new QMP driver [RFC,v2,16/34] phy: qcom-qmp: move SM6116 UFS PHY to new QMP driver [RFC,v2,17/34] phy: qcom-qmp: move SC8280xp, SM8350 and SM8450 UFS PHY to new QMP driver [RFC,v2,18/34] phy: qcom-qmp: add QMP USB PHY driver [RFC,v2,19/34] phy: qcom-qmp: move MSM8996 USB PHY to new QMP driver [RFC,v2,20/34] phy: qcom-qmp: move IPQ6018, IPQ8074 USB PHY to new QMP driver [RFC,v2,21/34] phy: qcom-qmp: move MSM8998 USB PHY to new QMP driver [RFC,v2,22/34] phy: qcom-qmp: move SDM845 USB PHY to new QMP driver [RFC,v2,23/34] phy: qcom-qmp: move SC7180 USB PHY to new QMP driver [RFC,v2,24/34] phy: qcom-qmp: move SC8180x, SM8150 USB PHY to new QMP driver [RFC,v2,25/34] phy: qcom-qmp: move SM8250 USB PHY to new QMP driver [RFC,v2,26/34] phy: qcom-qmp: move SM8350, SM8450 USB PHY to new QMP driver [RFC,v2,27/34] phy: qcom-qmp: move SDX55 USB PHY to new QMP driver [RFC,v2,28/34] phy: qcom-qmp: move SDX65 USB PHY to new QMP driver [RFC,v2,29/34] phy: qcom-qmp: move QCM2290 USB PHY to new QMP driver [RFC,v2,30/34] phy: qcom-qmp: add QMP combo DP+USB PHY driver [RFC,v2,31/34] phy: qcom-qmp: move SC7180 DP PHY to new QMP driver [RFC,v2,32/34] phy: qcom-qmp: move SC8180X DP PHY to new QMP driver [RFC,v2,33/34] phy: qcom-qmp: move SM8250 DP PHY to new QMP driver [RFC,v2,34/34] phy: qcom-qmp: drop old QMP PHY driver

diff --git a/drivers/phy/qualcomm/Makefile b/drivers/phy/qualcomm/Makefile index 8de9adc943dd..5e805b7a530b 100644 --- a/drivers/phy/qualcomm/Makefile +++ b/drivers/phy/qualcomm/Makefile @@ -7,6 +7,7 @@ obj-$(CONFIG_PHY_QCOM_IPQ806X_SATA) += phy-qcom-ipq806x-sata.o obj-$(CONFIG_PHY_QCOM_PCIE2) += phy-qcom-pcie2.o obj-$(CONFIG_PHY_QCOM_QMP) += \ phy-qcom-qmp-lib.o \ + phy-qcom-qmp-pcie.o \ phy-qcom-qmp.o obj-$(CONFIG_PHY_QCOM_QUSB2) += phy-qcom-qusb2.o diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c b/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c new file mode 100644 index 000000000000..e81b8c69664b --- /dev/null +++ b/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c @@ -0,0 +1,460 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Copyright (c) 2017, The Linux Foundation. All rights reserved. + */ + +#include <linux/clk.h> +#include <linux/err.h> +#include <linux/iopoll.h> +#include <linux/kernel.h> +#include <linux/module.h> +#include <linux/of_device.h> +#include <linux/phy/phy.h> +#include <linux/platform_device.h> +#include <linux/reset.h> + +#include <dt-bindings/phy/phy.h> + +#include "phy-qcom-qmp.h" +#include "phy-qcom-qmp-lib.h" + +struct qmp_pcie_phy; + +/* struct qmp_phy_pcie_cfg - per-PHY initialization config */ +struct qmp_phy_pcie_cfg { + struct qmp_phy_cfg base; + + /* true, if PHY needs delay after POWER_DOWN */ + bool has_pwrdn_delay; + /* power_down delay in usec */ + int pwrdn_delay_min; + int pwrdn_delay_max; + + /* true, if PHY has a separate PHY_COM control block */ + bool has_phy_com_ctrl; + unsigned int mask_com_pcs_ready; + + /* true, if PHY has a reset for individual lanes */ + bool has_lane_rst; + + const struct qmp_phy_init_tbl *serdes_tbl_sec; + int serdes_tbl_num_sec; + const struct qmp_phy_init_tbl *tx_tbl_sec; + int tx_tbl_num_sec; + const struct qmp_phy_init_tbl *rx_tbl_sec; + int rx_tbl_num_sec; + const struct qmp_phy_init_tbl *pcs_tbl_sec; + int pcs_tbl_num_sec; + const struct qmp_phy_init_tbl *pcs_misc_tbl; + int pcs_misc_tbl_num; + const struct qmp_phy_init_tbl *pcs_misc_tbl_sec; + int pcs_misc_tbl_num_sec; +}; + +/** + * struct qmp_pcie_phy - per-lane phy descriptor + * + * @base: base qmp_phy data + * @cfg: phy specific configuration + * @pipe_clk: pipe clock + * @lane_rst: lane's reset controller + */ +struct qmp_pcie_phy { + struct qmp_phy base; + const struct qmp_phy_pcie_cfg *cfg; + struct clk *pipe_clk; + struct reset_control *lane_rst; +}; + +#define to_qmp_pcie_phy(qphy) container_of(qphy, struct qmp_pcie_phy, base) + +static int qcom_qmp_phy_com_ctrl_init(struct qmp_pcie_phy *qphy_pcie) +{ + struct qcom_qmp *qmp = qphy_pcie->base.qmp; + const struct qmp_phy_pcie_cfg *cfg = qphy_pcie->cfg; + void __iomem *serdes = qphy_pcie->base.serdes; + int ret; + + if (cfg->has_phy_com_ctrl) { + void __iomem *status; + unsigned int mask, val; + + qphy_clrbits(serdes, cfg->base.regs[QPHY_COM_SW_RESET], SW_RESET); + qphy_setbits(serdes, cfg->base.regs[QPHY_COM_START_CONTROL], + SERDES_START | PCS_START); + + status = serdes + cfg->base.regs[QPHY_COM_PCS_READY_STATUS]; + mask = cfg->mask_com_pcs_ready; + + ret = readl_poll_timeout(status, val, (val & mask), 10, + PHY_INIT_COMPLETE_TIMEOUT); + if (ret) { + dev_err(qmp->dev, + "phy common block init timed-out\n"); + return ret; + } + } + + return 0; +} + +static int qcom_qmp_phy_com_init(struct qmp_pcie_phy *qphy_pcie) +{ + struct qcom_qmp *qmp = qphy_pcie->base.qmp; + const struct qmp_phy_pcie_cfg *cfg = qphy_pcie->cfg; + int ret; + + dev_vdbg(qmp->dev, "Initializing QMP phy\n"); + + mutex_lock(&qmp->phy_mutex); + if (qmp->init_count++) { + mutex_unlock(&qmp->phy_mutex); + return 0; + } + + ret = qcom_qmp_phy_common_init(&qphy_pcie->base, &cfg->base); + if (ret) + goto err_unlock; + + if (cfg->has_phy_com_ctrl) { + void __iomem *serdes = qphy_pcie->base.serdes; + + qphy_setbits(serdes, cfg->base.regs[QPHY_COM_POWER_DOWN_CONTROL], + SW_PWRDN); + } else { + qcom_qmp_phy_pwrup(&qphy_pcie->base, &cfg->base); + } + + mutex_unlock(&qmp->phy_mutex); + + return 0; + +err_unlock: + mutex_unlock(&qmp->phy_mutex); + + return ret; +} + +static int qcom_qmp_phy_com_exit(struct qmp_pcie_phy *qphy_pcie) +{ + struct qcom_qmp *qmp = qphy_pcie->base.qmp; + const struct qmp_phy_pcie_cfg *cfg = qphy_pcie->cfg; + + mutex_lock(&qmp->phy_mutex); + if (--qmp->init_count) { + mutex_unlock(&qmp->phy_mutex); + return 0; + } + + if (cfg->has_phy_com_ctrl) { + void __iomem *serdes = qphy_pcie->base.serdes; + + qphy_setbits(serdes, cfg->base.regs[QPHY_COM_START_CONTROL], + SERDES_START | PCS_START); + qphy_clrbits(serdes, cfg->base.regs[QPHY_COM_SW_RESET], + SW_RESET); + qphy_setbits(serdes, cfg->base.regs[QPHY_COM_POWER_DOWN_CONTROL], + SW_PWRDN); + } + + qcom_qmp_phy_common_exit(&qphy_pcie->base, &cfg->base); + + mutex_unlock(&qmp->phy_mutex); + + return 0; +} + +static int qcom_qmp_phy_pcie_power_on(struct phy *phy) +{ + struct qmp_phy *qphy = phy_get_drvdata(phy); + struct qmp_pcie_phy *qphy_pcie = to_qmp_pcie_phy(qphy); + struct qcom_qmp *qmp = qphy_pcie->base.qmp; + const struct qmp_phy_pcie_cfg *cfg = qphy_pcie->cfg; + void __iomem *serdes = qphy_pcie->base.serdes; + void __iomem *tx = qphy_pcie->base.tx; + void __iomem *rx = qphy_pcie->base.rx; + void __iomem *pcs = qphy_pcie->base.pcs; + void __iomem *pcs_misc = qphy_pcie->base.pcs_misc; + int ret; + + qcom_qmp_phy_configure(serdes, cfg->base.regs, cfg->base.serdes_tbl, cfg->base.serdes_tbl_num); + qcom_qmp_phy_configure(serdes, cfg->base.regs, cfg->serdes_tbl_sec, + cfg->serdes_tbl_num_sec); + qcom_qmp_phy_com_ctrl_init(qphy_pcie); + + if (cfg->has_lane_rst) { + ret = reset_control_deassert(qphy_pcie->lane_rst); + if (ret) { + dev_err(qmp->dev, "lane%d reset deassert failed\n", + qphy_pcie->base.index); + return ret; + } + } + + ret = clk_prepare_enable(qphy_pcie->pipe_clk); + if (ret) { + dev_err(qmp->dev, "pipe_clk enable failed err=%d\n", ret); + goto err_reset_lane; + } + + /* Tx, Rx, and PCS configurations */ + qcom_qmp_phy_configure_lane(tx, cfg->base.regs, + cfg->base.tx_tbl, cfg->base.tx_tbl_num, 1); + qcom_qmp_phy_configure_lane(tx, cfg->base.regs, cfg->tx_tbl_sec, + cfg->tx_tbl_num_sec, 1); + + /* Configuration for other LANE for USB-DP combo PHY */ + if (cfg->base.is_dual_lane_phy) { + qcom_qmp_phy_configure_lane(qphy_pcie->base.tx2, cfg->base.regs, + cfg->base.tx_tbl, cfg->base.tx_tbl_num, 2); + qcom_qmp_phy_configure_lane(qphy_pcie->base.tx2, cfg->base.regs, + cfg->tx_tbl_sec, + cfg->tx_tbl_num_sec, 2); + } + + qcom_qmp_phy_configure_lane(rx, cfg->base.regs, + cfg->base.rx_tbl, cfg->base.rx_tbl_num, 1); + qcom_qmp_phy_configure_lane(rx, cfg->base.regs, + cfg->rx_tbl_sec, cfg->rx_tbl_num_sec, 1); + + if (cfg->base.is_dual_lane_phy) + qcom_qmp_phy_configure_lane(qphy_pcie->base.rx2, cfg->base.regs, + cfg->base.rx_tbl, cfg->base.rx_tbl_num, 2); + if (cfg->base.is_dual_lane_phy) + qcom_qmp_phy_configure_lane(qphy_pcie->base.rx2, cfg->base.regs, + cfg->rx_tbl_sec, + cfg->rx_tbl_num_sec, 2); + + qcom_qmp_phy_configure(pcs, cfg->base.regs, cfg->base.pcs_tbl, cfg->base.pcs_tbl_num); + qcom_qmp_phy_configure(pcs, cfg->base.regs, cfg->pcs_tbl_sec, + cfg->pcs_tbl_num_sec); + + qcom_qmp_phy_configure(pcs_misc, cfg->base.regs, cfg->pcs_misc_tbl, + cfg->pcs_misc_tbl_num); + qcom_qmp_phy_configure(pcs_misc, cfg->base.regs, cfg->pcs_misc_tbl_sec, + cfg->pcs_misc_tbl_num_sec); + + /* + * Pull out PHY from POWER DOWN state. + * This is active low enable signal to power-down PHY. + */ + qphy_setbits(pcs, QPHY_POWER_DOWN_CONTROL, cfg->base.pwrdn_ctrl); + + if (cfg->has_pwrdn_delay) + usleep_range(cfg->pwrdn_delay_min, cfg->pwrdn_delay_max); + + ret = qcom_qmp_phy_power_on(qphy, &cfg->base, true); + if (ret) + goto err_disable_pipe_clk; + + return 0; + +err_disable_pipe_clk: + clk_disable_unprepare(qphy_pcie->pipe_clk); +err_reset_lane: + if (cfg->has_lane_rst) + reset_control_assert(qphy_pcie->lane_rst); + + return ret; +} + +static int qcom_qmp_phy_pcie_power_off(struct phy *phy) +{ + struct qmp_phy *qphy = phy_get_drvdata(phy); + struct qmp_pcie_phy *qphy_pcie = to_qmp_pcie_phy(qphy); + const struct qmp_phy_pcie_cfg *cfg = qphy_pcie->cfg; + + clk_disable_unprepare(qphy_pcie->pipe_clk); + + qcom_qmp_phy_power_off(qphy, &cfg->base, true); + + return 0; +} + +static int qcom_qmp_phy_pcie_exit(struct phy *phy) +{ + struct qmp_phy *qphy = phy_get_drvdata(phy); + struct qmp_pcie_phy *qphy_pcie = to_qmp_pcie_phy(qphy); + const struct qmp_phy_pcie_cfg *cfg = qphy_pcie->cfg; + + if (cfg->has_lane_rst) + reset_control_assert(qphy_pcie->lane_rst); + + qcom_qmp_phy_com_exit(qphy_pcie); + + return 0; +} + +static int qcom_qmp_phy_pcie_enable(struct phy *phy) +{ + struct qmp_phy *qphy = phy_get_drvdata(phy); + struct qmp_pcie_phy *qphy_pcie = to_qmp_pcie_phy(qphy); + int ret; + + ret = qcom_qmp_phy_com_init(qphy_pcie); + if (ret) + return ret; + + ret = qcom_qmp_phy_pcie_power_on(phy); + if (ret) + qcom_qmp_phy_pcie_exit(phy); + + return ret; +} + +static int qcom_qmp_phy_pcie_disable(struct phy *phy) +{ + int ret; + + ret = qcom_qmp_phy_pcie_power_off(phy); + if (ret) + return ret; + return qcom_qmp_phy_pcie_exit(phy); +} + +static const struct phy_ops qcom_qmp_pcie_ops = { + .power_on = qcom_qmp_phy_pcie_enable, + .power_off = qcom_qmp_phy_pcie_disable, + .set_mode = qcom_qmp_phy_set_mode, + .owner = THIS_MODULE, +}; + +static void qcom_qmp_reset_control_put(void *data) +{ + reset_control_put(data); +} + +static +int qcom_qmp_phy_pcie_create(struct device *dev, struct device_node *np, int id, + void __iomem *serdes, const struct qmp_phy_pcie_cfg *cfg) +{ + struct qcom_qmp *qmp = dev_get_drvdata(dev); + struct qmp_pcie_phy *qphy_pcie; + char prop_name[MAX_PROP_NAME]; + int ret; + + qphy_pcie = devm_kzalloc(dev, sizeof(*qphy_pcie), GFP_KERNEL); + if (!qphy_pcie) + return -ENOMEM; + + qphy_pcie->cfg = cfg; + + ret = qcom_qmp_phy_init(dev, np, &qphy_pcie->base, serdes, &cfg->base); + if (ret) + return ret; + + /* + * Get PHY's Pipe clock, if any. USB3 and PCIe are PIPE3 + * based phys, so they essentially have pipe clock. So, + * we return error in case phy is USB3 or PIPE type. + * Otherwise, we initialize pipe clock to NULL for + * all phys that don't need this. + */ + snprintf(prop_name, sizeof(prop_name), "pipe%d", id); + qphy_pcie->pipe_clk = devm_get_clk_from_child(dev, np, prop_name); + if (IS_ERR(qphy_pcie->pipe_clk)) + return dev_err_probe(dev, PTR_ERR(qphy_pcie->pipe_clk), + "failed to get lane%d pipe_clk\n", + id); + + /* Get lane reset, if any */ + if (cfg->has_lane_rst) { + snprintf(prop_name, sizeof(prop_name), "lane%d", id); + qphy_pcie->lane_rst = of_reset_control_get_exclusive(np, prop_name); + if (IS_ERR(qphy_pcie->lane_rst)) { + dev_err(dev, "failed to get lane%d reset\n", id); + return PTR_ERR(qphy_pcie->lane_rst); + } + ret = devm_add_action_or_reset(dev, qcom_qmp_reset_control_put, + qphy_pcie->lane_rst); + if (ret) + return ret; + } + + ret = qcom_qmp_phy_setup(dev, np, id, &qphy_pcie->base, &qcom_qmp_pcie_ops); + if (ret) + return ret; + + /* + * Register the pipe clock provided by phy. + * See function description to see details of this pipe clock. + */ + ret = qcom_qmp_phy_pipe_clk_register(qmp, np); + if (ret) { + dev_err(qmp->dev, + "failed to register pipe clock source\n"); + return ret; + } + + return 0; +} + +static const struct of_device_id qcom_qmp_phy_pcie_of_match_table[] = { + { }, +}; +MODULE_DEVICE_TABLE(of, qcom_qmp_phy_pcie_of_match_table); + +static int qcom_qmp_phy_pcie_probe(struct platform_device *pdev) +{ + struct device *dev = &pdev->dev; + struct device_node *child; + struct phy_provider *phy_provider; + void __iomem *serdes; + const struct qmp_phy_pcie_cfg *cfg; + int id; + int ret; + + /* Get the specific init parameters of QMP phy */ + cfg = of_device_get_match_data(dev); + if (!cfg) + return -EINVAL; + + /* per PHY serdes; usually located at base address */ + serdes = devm_platform_ioremap_resource(pdev, 0); + if (IS_ERR(serdes)) + return PTR_ERR(serdes); + + ret = qcom_qmp_phy_common_probe(pdev, &cfg->base, cfg->base.nlanes); + if (ret) + return ret; + + id = 0; + for_each_available_child_of_node(dev->of_node, child) { + /* Create per-lane phy */ + ret = qcom_qmp_phy_pcie_create(dev, child, id, serdes, cfg); + if (ret) { + dev_err(dev, "failed to create lane%d phy, %d\n", + id, ret); + goto err_node_put; + } + + id++; + } + + phy_provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate); + if (!IS_ERR(phy_provider)) + dev_info(dev, "Registered Qcom-QMP phy\n"); + else + pm_runtime_disable(dev); + + return PTR_ERR_OR_ZERO(phy_provider); + +err_node_put: + pm_runtime_disable(dev); + of_node_put(child); + return ret; +} + +static struct platform_driver qcom_qmp_phy_pcie_driver = { + .probe = qcom_qmp_phy_pcie_probe, + .driver = { + .name = "qcom-qmp-phy-pcie", + .of_match_table = qcom_qmp_phy_pcie_of_match_table, + }, +}; + +module_platform_driver(qcom_qmp_phy_pcie_driver); + +MODULE_AUTHOR("Vivek Gautam <vivek.gautam@codeaurora.org>"); +MODULE_DESCRIPTION("Qualcomm QMP PCIe PHY driver"); +MODULE_LICENSE("GPL v2");

[RFC,v2,02/34] phy: qcom-qmp: add QMP PCIe PHY driver

Commit Message

Patch