| Message ID | 20220812075603.59375-5-samuel@sholland.org |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | phy: allwinner: phy-sun6i-mipi-dphy: Add the A100 DPHY | expand |
On 12/08/2022 10:55, Samuel Holland wrote: > A100 features an updated DPHY, which moves PLL control inside the DPHY > register space. (Previously PLL-MIPI was controlled from the CCU. This > does not affect the "clocks" property because the link between PLL-MIPI > and the DPHY was never represented in the devicetree.) It also requires Misplaced '.'. With above: Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
Hi Samuel, On Fri 12 Aug 22, 02:55, Samuel Holland wrote: > A100 features an updated DPHY, which moves PLL control inside the DPHY > register space. (Previously PLL-MIPI was controlled from the CCU. This > does not affect the "clocks" property because the link between PLL-MIPI > and the DPHY was never represented in the devicetree.) It also requires > a modified analog power-on sequence. Finally, the new DPHY adds support > for operating as an LVDS PHY. D1 uses this same variant. Do you have some pointers about that? I'd be surprised that this PHY is now used for "traditional" LVDS display output, which is usually done with a simpler LVDS phy attached to the display controller. However I've seen that some new Allwinner SoCs come with sub-LVDS camera input, which typically requires a more complex PHY due to the high number of lanes. Anyway for now this is: Reviewed-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com> Cheers, Paul > Signed-off-by: Samuel Holland <samuel@sholland.org> > --- > > .../bindings/phy/allwinner,sun6i-a31-mipi-dphy.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/phy/allwinner,sun6i-a31-mipi-dphy.yaml b/Documentation/devicetree/bindings/phy/allwinner,sun6i-a31-mipi-dphy.yaml > index cf49bd99b3e2..b88c4b52af7d 100644 > --- a/Documentation/devicetree/bindings/phy/allwinner,sun6i-a31-mipi-dphy.yaml > +++ b/Documentation/devicetree/bindings/phy/allwinner,sun6i-a31-mipi-dphy.yaml > @@ -17,9 +17,13 @@ properties: > compatible: > oneOf: > - const: allwinner,sun6i-a31-mipi-dphy > + - const: allwinner,sun50i-a100-mipi-dphy > - items: > - const: allwinner,sun50i-a64-mipi-dphy > - const: allwinner,sun6i-a31-mipi-dphy > + - items: > + - const: allwinner,sun20i-d1-mipi-dphy > + - const: allwinner,sun50i-a100-mipi-dphy > > reg: > maxItems: 1 > -- > 2.35.1 >
On 8/25/22 5:41 AM, Paul Kocialkowski wrote: > Hi Samuel, > > On Fri 12 Aug 22, 02:55, Samuel Holland wrote: >> A100 features an updated DPHY, which moves PLL control inside the DPHY >> register space. (Previously PLL-MIPI was controlled from the CCU. This >> does not affect the "clocks" property because the link between PLL-MIPI >> and the DPHY was never represented in the devicetree.) It also requires >> a modified analog power-on sequence. Finally, the new DPHY adds support >> for operating as an LVDS PHY. D1 uses this same variant. > > Do you have some pointers about that? I'd be surprised that this PHY is now > used for "traditional" LVDS display output, which is usually done with a simpler > LVDS phy attached to the display controller. Yes, this is documented in the A133 User Manual. As for the BSP code, see: https://github.com/Tina-Linux/tina-d1x-linux-5.4/blob/master/drivers/video/fbdev/sunxi/disp2/disp/de/lowlevel_v2x/de_dsi.c#L773 https://github.com/Tina-Linux/tina-d1x-linux-5.4/blob/master/drivers/video/fbdev/sunxi/disp2/disp/de/lowlevel_v2x/de_lcd_sun50iw10.c#L390 https://github.com/Tina-Linux/tina-d1x-linux-5.4/blob/master/drivers/video/fbdev/sunxi/disp2/disp/de/disp_lcd.c#L786 Regards, Samuel > However I've seen that some new Allwinner SoCs come with sub-LVDS camera input, > which typically requires a more complex PHY due to the high number of lanes. > > Anyway for now this is: > Reviewed-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com> > > Cheers, > > Paul > >> Signed-off-by: Samuel Holland <samuel@sholland.org> >> --- >> >> .../bindings/phy/allwinner,sun6i-a31-mipi-dphy.yaml | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/phy/allwinner,sun6i-a31-mipi-dphy.yaml b/Documentation/devicetree/bindings/phy/allwinner,sun6i-a31-mipi-dphy.yaml >> index cf49bd99b3e2..b88c4b52af7d 100644 >> --- a/Documentation/devicetree/bindings/phy/allwinner,sun6i-a31-mipi-dphy.yaml >> +++ b/Documentation/devicetree/bindings/phy/allwinner,sun6i-a31-mipi-dphy.yaml >> @@ -17,9 +17,13 @@ properties: >> compatible: >> oneOf: >> - const: allwinner,sun6i-a31-mipi-dphy >> + - const: allwinner,sun50i-a100-mipi-dphy >> - items: >> - const: allwinner,sun50i-a64-mipi-dphy >> - const: allwinner,sun6i-a31-mipi-dphy >> + - items: >> + - const: allwinner,sun20i-d1-mipi-dphy >> + - const: allwinner,sun50i-a100-mipi-dphy >> >> reg: >> maxItems: 1 >> -- >> 2.35.1 >> >
diff --git a/Documentation/devicetree/bindings/phy/allwinner,sun6i-a31-mipi-dphy.yaml b/Documentation/devicetree/bindings/phy/allwinner,sun6i-a31-mipi-dphy.yaml index cf49bd99b3e2..b88c4b52af7d 100644 --- a/Documentation/devicetree/bindings/phy/allwinner,sun6i-a31-mipi-dphy.yaml +++ b/Documentation/devicetree/bindings/phy/allwinner,sun6i-a31-mipi-dphy.yaml @@ -17,9 +17,13 @@ properties: compatible: oneOf: - const: allwinner,sun6i-a31-mipi-dphy + - const: allwinner,sun50i-a100-mipi-dphy - items: - const: allwinner,sun50i-a64-mipi-dphy - const: allwinner,sun6i-a31-mipi-dphy + - items: + - const: allwinner,sun20i-d1-mipi-dphy + - const: allwinner,sun50i-a100-mipi-dphy reg: maxItems: 1
A100 features an updated DPHY, which moves PLL control inside the DPHY register space. (Previously PLL-MIPI was controlled from the CCU. This does not affect the "clocks" property because the link between PLL-MIPI and the DPHY was never represented in the devicetree.) It also requires a modified analog power-on sequence. Finally, the new DPHY adds support for operating as an LVDS PHY. D1 uses this same variant. Signed-off-by: Samuel Holland <samuel@sholland.org> --- .../bindings/phy/allwinner,sun6i-a31-mipi-dphy.yaml | 4 ++++ 1 file changed, 4 insertions(+)