From patchwork Tue Aug 30 11:29:22 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 12959141 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9EA78C0502C for ; Tue, 30 Aug 2022 11:30:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hQmoAfofRp9RCrCdiF6kjaY/UNZeY0EwDts6yiHJ474=; b=HBH+xKCzweGoEA Y/gKzo9b0XoGw4qt9+6u8jEXyAZV/F73zxAB7bYLbCFbq8puBZdrfDqyjl/6mFFm7RIwMsNr8Pvkh NVWIubogNkfhPpq8ScvhY6C6K+3gNUv0swGhfltR+tlsN5DgIMLEci302mpd4oMkFt68MpJX0DmvX lYDVWl3vlN9dBAj9/YXU5V2xPWuT9Jit3nkQFSD/DWNlDykFo9llF7qPwcCp7ABdP+vVGBK+GGORL FEMl4LRv8DJkp7uHM1ONOr+vepmuutPaqEE8oZU61IRAmP2SJELSwM/X1Ki1SK74NKs/bsaU7Z+3S cvcAYObkCa5qLcxvB+1Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oSzRo-00GZl1-Ud; Tue, 30 Aug 2022 11:30:24 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oSzRW-00GZWv-I2 for linux-phy@lists.infradead.org; Tue, 30 Aug 2022 11:30:10 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BFD1C61586; Tue, 30 Aug 2022 11:30:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A3824C4347C; Tue, 30 Aug 2022 11:30:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1661859001; bh=ik9HtwhDAeYEiLoS39U3DGxmuHrw4bv1UDZj63E1omk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gf8uBIbwLamMrT3CU6hmdqylMIZTwCz6n11AT2ds+tCwJoEPIgmBHq48yTsbJeGWF vTkfgttp1pe1Y4HcedXXrUBZW5e6nHbAKcXHRHQH0rvLKV61a0WSMTRACPXvZVvPYv 0Z25hikFY3X8CyRViqCxag9lIq/3eSRljpWgYUbYWwTjPWwKUibHMWgTz+Lutl19CK 677SXIcjBX7gekeNE8x4lWPmsn84rPaGAp0E8Y/iMcaJh5+CBKGbH7fliv1Njs8wh8 53KCEMFC5iw1Sq6aqtNxYIP2S9A7XFuAvASZPJ/uAa4hhlpmQxZvfPK1WzjEUX40+m q1hiORMA9SEyA== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1oSzRP-00011D-DR; Tue, 30 Aug 2022 13:29:59 +0200 From: Johan Hovold To: Vinod Koul , Rob Herring , Krzysztof Kozlowski Cc: Andy Gross , Bjorn Andersson , Konrad Dybcio , Kishon Vijay Abraham I , Dmitry Baryshkov , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , Krzysztof Kozlowski Subject: [PATCH v4 29/30] phy: qcom-qmp-pcie-msm8996: drop reset lane suffix Date: Tue, 30 Aug 2022 13:29:22 +0200 Message-Id: <20220830112923.3725-30-johan+linaro@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220830112923.3725-1-johan+linaro@kernel.org> References: <20220830112923.3725-1-johan+linaro@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220830_043006_673681_84B2FEC4 X-CRM114-Status: GOOD ( 12.93 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org The lane reset is defined in the "lane" node so there's no need to keep adding a redundant lane-number suffix to the reset name. Update driver to support the new binding where the "lane" reset name has been deprecated by instead requesting the reset by index. Reviewed-by: Krzysztof Kozlowski Reviewed-by: Dmitry Baryshkov Signed-off-by: Johan Hovold --- drivers/phy/qualcomm/phy-qcom-qmp-pcie-msm8996.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-pcie-msm8996.c b/drivers/phy/qualcomm/phy-qcom-qmp-pcie-msm8996.c index 7b893c66cf75..a4ff15b289cd 100644 --- a/drivers/phy/qualcomm/phy-qcom-qmp-pcie-msm8996.c +++ b/drivers/phy/qualcomm/phy-qcom-qmp-pcie-msm8996.c @@ -860,7 +860,6 @@ int qcom_qmp_phy_pcie_msm8996_create(struct device *dev, struct device_node *np, struct qcom_qmp *qmp = dev_get_drvdata(dev); struct phy *generic_phy; struct qmp_phy *qphy; - char prop_name[MAX_PROP_NAME]; int ret; qphy = devm_kzalloc(dev, sizeof(*qphy), GFP_KERNEL); @@ -898,9 +897,7 @@ int qcom_qmp_phy_pcie_msm8996_create(struct device *dev, struct device_node *np, "failed to get lane%d pipe clock\n", id); } - /* Get lane reset, if any */ - snprintf(prop_name, sizeof(prop_name), "lane%d", id); - qphy->lane_rst = of_reset_control_get_exclusive(np, prop_name); + qphy->lane_rst = of_reset_control_get_exclusive_by_index(np, 0); if (IS_ERR(qphy->lane_rst)) { dev_err(dev, "failed to get lane%d reset\n", id); return PTR_ERR(qphy->lane_rst);