| Message ID | 20220919-v1-6-4844816c9808@baylibre.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add MT8195 HDMI support | expand |
Il 19/09/22 18:56, Guillaume Ranquet ha scritto: > In order to share register with a dedicated ddc driver, set the hdmi > compatible to syscon. > > Signed-off-by: Guillaume Ranquet <granquet@baylibre.com> > > diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,hdmi.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,hdmi.yaml > index abb231a0694b..86297b7eb7f7 100644 > --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,hdmi.yaml > +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,hdmi.yaml > @@ -16,12 +16,14 @@ description: | > > properties: > compatible: > - enum: > - - mediatek,mt2701-hdmi > - - mediatek,mt7623-hdmi > - - mediatek,mt8167-hdmi > - - mediatek,mt8173-hdmi > - - mediatek,mt8195-hdmi > + items: > + - enum: > + - mediatek,mt2701-hdmi > + - mediatek,mt7623-hdmi > + - mediatek,mt8167-hdmi > + - mediatek,mt8173-hdmi > + - const: syscon > + This is an ABI breakage, you can't do that. Regards, Angelo
On 19/09/2022 18:56, Guillaume Ranquet wrote: > In order to share register with a dedicated ddc driver, set the hdmi > compatible to syscon. > > Signed-off-by: Guillaume Ranquet <granquet@baylibre.com> > > diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,hdmi.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,hdmi.yaml > index abb231a0694b..86297b7eb7f7 100644 > --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,hdmi.yaml > +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,hdmi.yaml > @@ -16,12 +16,14 @@ description: | > > properties: > compatible: > - enum: > - - mediatek,mt2701-hdmi > - - mediatek,mt7623-hdmi > - - mediatek,mt8167-hdmi > - - mediatek,mt8173-hdmi > - - mediatek,mt8195-hdmi > + items: > + - enum: > + - mediatek,mt2701-hdmi > + - mediatek,mt7623-hdmi > + - mediatek,mt8167-hdmi > + - mediatek,mt8173-hdmi > + - const: syscon So you just broke all DTS and I do not see patches fixing them... Best regards, Krzysztof
On Thu, 22 Sep 2022 09:19, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: >On 19/09/2022 18:56, Guillaume Ranquet wrote: >> In order to share register with a dedicated ddc driver, set the hdmi >> compatible to syscon. >> >> Signed-off-by: Guillaume Ranquet <granquet@baylibre.com> >> >> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,hdmi.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,hdmi.yaml >> index abb231a0694b..86297b7eb7f7 100644 >> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,hdmi.yaml >> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,hdmi.yaml >> @@ -16,12 +16,14 @@ description: | >> >> properties: >> compatible: >> - enum: >> - - mediatek,mt2701-hdmi >> - - mediatek,mt7623-hdmi >> - - mediatek,mt8167-hdmi >> - - mediatek,mt8173-hdmi >> - - mediatek,mt8195-hdmi >> + items: >> + - enum: >> + - mediatek,mt2701-hdmi >> + - mediatek,mt7623-hdmi >> + - mediatek,mt8167-hdmi >> + - mediatek,mt8173-hdmi >> + - const: syscon > >So you just broke all DTS and I do not see patches fixing them... > >Best regards, >Krzysztof > I'll drop this patch for V2, as suggested by Angelo I'll do things differently in the driver to drop this requirement. Thx, Guillaume.
diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,hdmi.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,hdmi.yaml index abb231a0694b..86297b7eb7f7 100644 --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,hdmi.yaml +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,hdmi.yaml @@ -16,12 +16,14 @@ description: | properties: compatible: - enum: - - mediatek,mt2701-hdmi - - mediatek,mt7623-hdmi - - mediatek,mt8167-hdmi - - mediatek,mt8173-hdmi - - mediatek,mt8195-hdmi + items: + - enum: + - mediatek,mt2701-hdmi + - mediatek,mt7623-hdmi + - mediatek,mt8167-hdmi + - mediatek,mt8173-hdmi + - const: syscon + clocks: true clock-names: true @@ -142,7 +144,7 @@ examples: #include <dt-bindings/interrupt-controller/arm-gic.h> #include <dt-bindings/interrupt-controller/irq.h> hdmi0: hdmi@14025000 { - compatible = "mediatek,mt8173-hdmi"; + compatible = "mediatek,mt8173-hdmi", "syscon"; reg = <0x14025000 0x400>; interrupts = <GIC_SPI 206 IRQ_TYPE_LEVEL_LOW>; clocks = <&mmsys CLK_MM_HDMI_PIXEL>, diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi index 7640b5158ff9..3e7a0f406631 100644 --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi @@ -1306,7 +1306,7 @@ od@14023000 { }; hdmi0: hdmi@14025000 { - compatible = "mediatek,mt8173-hdmi"; + compatible = "mediatek,mt8173-hdmi", "syscon"; reg = <0 0x14025000 0 0x400>; interrupts = <GIC_SPI 206 IRQ_TYPE_LEVEL_LOW>; clocks = <&mmsys CLK_MM_HDMI_PIXEL>,
In order to share register with a dedicated ddc driver, set the hdmi compatible to syscon. Signed-off-by: Guillaume Ranquet <granquet@baylibre.com>