| Message ID | 20220919095700.2228-1-johan+linaro@kernel.org |
|---|---|
| State | Accepted |
| Commit | f5d6b5d613e9135e78cd91632a6ed4d04c4e5e49 |
| Headers | show |
| Series | phy: qcom-qmp-combo: fix sc8280xp PCS_USB offset | expand |
On 19-09-22, 11:57, Johan Hovold wrote: > The PCS_USB register block lives at an offset of 0x300 from the PCS > region on SC8280XP so add the missing offset to avoid corrupting > unrelated registers on runtime suspend. Applied, thanks
diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c index d200cd5ca4fa..ed196d00815b 100644 --- a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c +++ b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c @@ -1261,6 +1261,7 @@ static const struct qmp_phy_cfg sc8280xp_usb43dp_usb_cfg = { .vreg_list = qmp_phy_vreg_l, .num_vregs = ARRAY_SIZE(qmp_phy_vreg_l), .regs = qmp_v4_usb3phy_regs_layout, + .pcs_usb_offset = 0x300, .start_ctrl = SERDES_START | PCS_START, .pwrdn_ctrl = SW_PWRDN,
The PCS_USB register block lives at an offset of 0x300 from the PCS region on SC8280XP so add the missing offset to avoid corrupting unrelated registers on runtime suspend. Note that this region should probably be described separately in the binding. Fixes: a2e927b0e50d ("phy: qcom-qmp-combo: Add sc8280xp USB/DP combo phys") Signed-off-by: Johan Hovold <johan+linaro@kernel.org> --- drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 1 + 1 file changed, 1 insertion(+) The corresponding DT fix is here: https://lore.kernel.org/all/20220919094454.1574-4-johan+linaro@kernel.org/ Johan