| Message ID | 20221012055602.1544944-10-uwu@icenowy.me |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | SUNIV USB and PopStick support (and updating mailmap) | expand |
On 12/10/2022 01:56, Icenowy Zheng wrote: > SourceParts PopStick is a F1C200s-based stick-shaped SBC. > > Add a compatible string list for its v1.1 version (the first public > one). > > Signed-off-by: Icenowy Zheng <uwu@icenowy.me> > --- > New patch introduced in v2. > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Wed, 12 Oct 2022 13:56:01 +0800 Icenowy Zheng <uwu@icenowy.me> wrote: Hi Icenowy, > SourceParts PopStick is a F1C200s-based stick-shaped SBC. > > Add a compatible string list for its v1.1 version (the first public > one). If v1.0 (or anything prior) never made it to the outside world, I don't think we need to mention that in the public bindings. In general Linux seems to discourage support for unreleased hardware, so I think you can just drop the "sourceparts,popstick-v1.1" name. Cheers, Andre > Signed-off-by: Icenowy Zheng <uwu@icenowy.me> > --- > New patch introduced in v2. > > Documentation/devicetree/bindings/arm/sunxi.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml b/Documentation/devicetree/bindings/arm/sunxi.yaml > index 3ad1cd50e3fe..c6e0ad7f461d 100644 > --- a/Documentation/devicetree/bindings/arm/sunxi.yaml > +++ b/Documentation/devicetree/bindings/arm/sunxi.yaml > @@ -807,6 +807,13 @@ properties: > - const: sinlinx,sina33 > - const: allwinner,sun8i-a33 > > + - description: SourceParts PopStick v1.1 > + items: > + - const: sourceparts,popstick-v1.1 > + - const: sourceparts,popstick > + - const: allwinner,suniv-f1c200s > + - const: allwinner,suniv-f1c100s > + > - description: SL631 Action Camera with IMX179 > items: > - const: allwinner,sl631-imx179
在 2022-10-24星期一的 15:17 +0100，Andre Przywara写道： > On Wed, 12 Oct 2022 13:56:01 +0800 > Icenowy Zheng <uwu@icenowy.me> wrote: > > Hi Icenowy, > > > SourceParts PopStick is a F1C200s-based stick-shaped SBC. > > > > Add a compatible string list for its v1.1 version (the first public > > one). > > If v1.0 (or anything prior) never made it to the outside world, I > don't > think we need to mention that in the public bindings. > In general Linux seems to discourage support for unreleased hardware, > so I > think you can just drop the "sourceparts,popstick-v1.1" name. There's going to be v2.0, which is quite different to v1.1. > > Cheers, > Andre > > > Signed-off-by: Icenowy Zheng <uwu@icenowy.me> > > --- > > New patch introduced in v2. > > > > Documentation/devicetree/bindings/arm/sunxi.yaml | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml > > b/Documentation/devicetree/bindings/arm/sunxi.yaml > > index 3ad1cd50e3fe..c6e0ad7f461d 100644 > > --- a/Documentation/devicetree/bindings/arm/sunxi.yaml > > +++ b/Documentation/devicetree/bindings/arm/sunxi.yaml > > @@ -807,6 +807,13 @@ properties: > > - const: sinlinx,sina33 > > - const: allwinner,sun8i-a33 > > > > + - description: SourceParts PopStick v1.1 > > + items: > > + - const: sourceparts,popstick-v1.1 > > + - const: sourceparts,popstick > > + - const: allwinner,suniv-f1c200s > > + - const: allwinner,suniv-f1c100s > > + > > - description: SL631 Action Camera with IMX179 > > items: > > - const: allwinner,sl631-imx179 >
diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml b/Documentation/devicetree/bindings/arm/sunxi.yaml index 3ad1cd50e3fe..c6e0ad7f461d 100644 --- a/Documentation/devicetree/bindings/arm/sunxi.yaml +++ b/Documentation/devicetree/bindings/arm/sunxi.yaml @@ -807,6 +807,13 @@ properties: - const: sinlinx,sina33 - const: allwinner,sun8i-a33 + - description: SourceParts PopStick v1.1 + items: + - const: sourceparts,popstick-v1.1 + - const: sourceparts,popstick + - const: allwinner,suniv-f1c200s + - const: allwinner,suniv-f1c100s + - description: SL631 Action Camera with IMX179 items: - const: allwinner,sl631-imx179
SourceParts PopStick is a F1C200s-based stick-shaped SBC. Add a compatible string list for its v1.1 version (the first public one). Signed-off-by: Icenowy Zheng <uwu@icenowy.me> --- New patch introduced in v2. Documentation/devicetree/bindings/arm/sunxi.yaml | 7 +++++++ 1 file changed, 7 insertions(+)