From patchwork Wed Oct 12 08:49:44 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 13004826 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C1467C47088 for ; Wed, 12 Oct 2022 08:50:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zsWWo8jhw35YS0Om+uUsF2hTPL+cgJdX0T0Ol+rRv+Q=; b=o5ZYyLi5klgKb7 9M4zVZ5ZX+IcSDbkIFowroIKpBTgJ2t+pAzy2xLQ/MqUuDbPQ/EnK9dDYIAGvJVF11ysfJNHUKESX dlvHJofdt8jsXuwI87jBVMHDs+CMgdyGCATaaS2F30Z+kTfn/+PBK/+LvWWw3nxf62L6u2rj02mwP h9aAp2kyLgLLmka2pWLBTe4gdbLZkXUmGwmDrPYCu4h532eeIJ7gUpR/NZvYr0wBqdwBeNoqMDKfZ 219xAnZ2ntSsP+nOe9OwrZID7temA45esRuVTai1oV0ssLHOc/jOHuKieEs8rnynX9F74IHedK+Dp 2bqfecchadrbtwz0hJDw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oiXS5-007QCD-4h; Wed, 12 Oct 2022 08:50:57 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oiXRr-007Q41-9m for linux-phy@lists.infradead.org; Wed, 12 Oct 2022 08:50:46 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1069B61483; Wed, 12 Oct 2022 08:50:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B5E81C4FEE2; Wed, 12 Oct 2022 08:50:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1665564639; bh=G8AJGMxl9/KJWXhq+yWOTNR/z95QK5IJBTDIbrH6Oy8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=chsbgIEvK92Vm3QZmlw0lfBeXVjxDUVqVo/a+ljetslZzSEpkQnXTYNc0M3A75HaP OV2alpHoQlNcHe6GrAiX0E3cZpRWXcdtkt2UO/cNOiUYluR2eRE6UkDtzCRu+X6AM6 570Y2utcKFSGqwJNyCzftIT7RzwYX1svh/zvtenz8eBkEya5ocCIiVW/2XJZdqNAZ/ btWV26ztkZOvcI0x4HZQDXuCgVxo/141369K/XAKookjXNcpSKE/mPQqnYkvUDKM3l 33ba2WBlVwLfIAjQl66oqpZ3KXNxcTa4WWpBXBXmLwUO7FyE8QvFIz8CWqprwCVXqd CYe56YwlasjdA== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1oiXRe-0006HZ-6o; Wed, 12 Oct 2022 10:50:30 +0200 From: Johan Hovold To: Vinod Koul Cc: Andy Gross , Bjorn Andersson , Konrad Dybcio , Kishon Vijay Abraham I , Dmitry Baryshkov , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 02/20] phy: qcom-qmp-pcie: fix ipq8074-gen3 initialisation Date: Wed, 12 Oct 2022 10:49:44 +0200 Message-Id: <20221012085002.24099-2-johan+linaro@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221012085002.24099-1-johan+linaro@kernel.org> References: <20221012084846.24003-1-johan+linaro@kernel.org> <20221012085002.24099-1-johan+linaro@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221012_015043_445280_9E1C0265 X-CRM114-Status: UNSURE ( 9.67 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org The phy_status mask was never set for IPQ8074 (gen3) which meant that the driver would not wait for the PHY to be initialised during power-on and would never detect PHY initialisation timeouts. Fixes: 334fad185415 ("phy: qcom-qmp-pcie: add IPQ8074 PCIe Gen3 QMP PHY support") Signed-off-by: Johan Hovold Reviewed-by: Dmitry Baryshkov --- drivers/phy/qualcomm/phy-qcom-qmp-pcie.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c b/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c index a7677b61f96e..f1e94b879d31 100644 --- a/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c +++ b/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c @@ -1519,6 +1519,7 @@ static const struct qmp_phy_cfg ipq8074_pciephy_gen3_cfg = { .start_ctrl = SERDES_START | PCS_START, .pwrdn_ctrl = SW_PWRDN | REFCLK_DRV_DSBL, + .phy_status = PHYSTATUS, .pipe_clock_rate = 250000000, };