| Message ID | 20221027044920.23194-2-hayashi.kunihiko@socionext.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | dt-bindings: phy: Fix UniPhier controller node names | expand |
On Thu, Oct 27, 2022 at 01:49:19PM +0900, Kunihiko Hayashi wrote: > The word "glue" is ambiguous for the controller node name. Should put > "usb-controller" instead of "usb-glue" on the controller node. > > Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com> > --- > .../devicetree/bindings/phy/socionext,uniphier-usb3hs-phy.yaml | 2 +- > .../devicetree/bindings/phy/socionext,uniphier-usb3ss-phy.yaml | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) Acked-by: Rob Herring <robh@kernel.org> > > diff --git a/Documentation/devicetree/bindings/phy/socionext,uniphier-usb3hs-phy.yaml b/Documentation/devicetree/bindings/phy/socionext,uniphier-usb3hs-phy.yaml > index 21e4414eea60..8ce57898fb96 100644 > --- a/Documentation/devicetree/bindings/phy/socionext,uniphier-usb3hs-phy.yaml > +++ b/Documentation/devicetree/bindings/phy/socionext,uniphier-usb3hs-phy.yaml > @@ -146,7 +146,7 @@ additionalProperties: false > > examples: > - | > - usb-glue@65b00000 { > + usb-controller@65b00000 { > compatible = "socionext,uniphier-ld20-dwc3-glue", "simple-mfd"; > #address-cells = <1>; > #size-cells = <1>; > diff --git a/Documentation/devicetree/bindings/phy/socionext,uniphier-usb3ss-phy.yaml b/Documentation/devicetree/bindings/phy/socionext,uniphier-usb3ss-phy.yaml > index 4c26d2d2303d..ba60b7add4f7 100644 > --- a/Documentation/devicetree/bindings/phy/socionext,uniphier-usb3ss-phy.yaml > +++ b/Documentation/devicetree/bindings/phy/socionext,uniphier-usb3ss-phy.yaml > @@ -131,7 +131,7 @@ additionalProperties: false > > examples: > - | > - usb-glue@65b00000 { > + usb-controller@65b00000 { > compatible = "socionext,uniphier-ld20-dwc3-glue", > "simple-mfd"; This and a bunch of other Socionext compatibles in examples throw warnings because there is not a schema for them: Documentation/devicetree/bindings/phy/socionext,uniphier-usb3ss-phy.example.dtb:0:0: /example-0/usb-controller@65b00000: failed to match any schema with compatible: ['socionext,uniphier-ld20-dwc3-glue', 'simple-mfd'] Documentation/devicetree/bindings/phy/socionext,uniphier-usb3hs-phy.example.dtb:0:0: /example-0/usb-controller@65b00000: failed to match any schema with compatible: ['socionext,uniphier-ld20-dwc3-glue', 'simple-mfd'] The remaining warnings are preventing turning the warning on by default, so fixing them would be nice. Rob
diff --git a/Documentation/devicetree/bindings/phy/socionext,uniphier-usb3hs-phy.yaml b/Documentation/devicetree/bindings/phy/socionext,uniphier-usb3hs-phy.yaml index 21e4414eea60..8ce57898fb96 100644 --- a/Documentation/devicetree/bindings/phy/socionext,uniphier-usb3hs-phy.yaml +++ b/Documentation/devicetree/bindings/phy/socionext,uniphier-usb3hs-phy.yaml @@ -146,7 +146,7 @@ additionalProperties: false examples: - | - usb-glue@65b00000 { + usb-controller@65b00000 { compatible = "socionext,uniphier-ld20-dwc3-glue", "simple-mfd"; #address-cells = <1>; #size-cells = <1>; diff --git a/Documentation/devicetree/bindings/phy/socionext,uniphier-usb3ss-phy.yaml b/Documentation/devicetree/bindings/phy/socionext,uniphier-usb3ss-phy.yaml index 4c26d2d2303d..ba60b7add4f7 100644 --- a/Documentation/devicetree/bindings/phy/socionext,uniphier-usb3ss-phy.yaml +++ b/Documentation/devicetree/bindings/phy/socionext,uniphier-usb3ss-phy.yaml @@ -131,7 +131,7 @@ additionalProperties: false examples: - | - usb-glue@65b00000 { + usb-controller@65b00000 { compatible = "socionext,uniphier-ld20-dwc3-glue", "simple-mfd"; #address-cells = <1>;
The word "glue" is ambiguous for the controller node name. Should put "usb-controller" instead of "usb-glue" on the controller node. Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com> --- .../devicetree/bindings/phy/socionext,uniphier-usb3hs-phy.yaml | 2 +- .../devicetree/bindings/phy/socionext,uniphier-usb3ss-phy.yaml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)