From patchwork Tue Mar 7 11:58:40 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13163300 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 72E53C6FD1B for ; Tue, 7 Mar 2023 11:59:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5Ds9gd5WgB6QRcb5Ahy8nW9LRwkdNBcDE9pJeUpYLbI=; b=LM+vZvPVIpYrXO uQj8aOPjB/Xy7rajo2q6gCustYIrQcREHU6rsvD2kK8Ixdv3HPD+HANvfiHrMaaTjWd4VEpmL5bPh cOqK6YL8E7JI3Ao5xcsXnODjBZWS7Fb5wxOO1ozttlVu2+0xvyRxksfeIEKy+Ko+0q0o4rqEs0MmN sSSMDExHSNwbDXp+heZiA9RkuHd7UShijoqwse9IuILBVYweUZph7cIhyHZgrYxdX29pyZCObRmD9 34DkWPGhPDQ4t8LUfmxLh+IQCfwUo/7WkLqu2GJ2Bo3uuorNxehAMv/h5SQ+tJIgphe0XLp2kOq0s zlloiDiXRaeHQu2iyqiA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZVyo-00HZGe-SH; Tue, 07 Mar 2023 11:59:42 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZVyV-00HZ0t-9s for linux-phy@lists.infradead.org; Tue, 07 Mar 2023 11:59:27 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pZVyJ-0006WC-FR; Tue, 07 Mar 2023 12:59:11 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pZVyI-002TFV-Md; Tue, 07 Mar 2023 12:59:10 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pZVyG-002yjI-7S; Tue, 07 Mar 2023 12:59:08 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Vinod Koul , Kishon Vijay Abraham I Cc: linux-phy@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 11/31] phy: phy-lgm-usb: Convert to platform remove callback returning void Date: Tue, 7 Mar 2023 12:58:40 +0100 Message-Id: <20230307115900.2293120-12-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230307115900.2293120-1-u.kleine-koenig@pengutronix.de> References: <20230307115900.2293120-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1557; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=pz9pBMZBV8CeCewNXzK9wiRT/fJeJ9rmTO9zxWVW7zQ=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkByarj+X/Uu776QGZlALzVO3tud9bf1oGfuQEF FaqRxUUNLuJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZAcmqwAKCRDB/BR4rcrs Cej7B/9SctOCfmv7VRUNbPGQ54M49gsRuMZO8ng2w/ZGmVmrTdsUThyCXi2E1iZlsIFsBo+uDAI bjrWnp+gXnI/Yo3mULwqMM4Poc3HrwYqja35o70oYqmX1CHzbsDn+56eIWg+gKqNrIYAQCQR2gz y6Ma7hixpSXmGubgFyM4pQQDFcja9T+qM/0mV8rNNjVFYc9lmE0bWxMAqmSCIcfA+7QSZVv4bi/ 30jmp9OdJ89svTOXHz2j1B4wtBbgYvll9naTViOS3uZjTOuDVslDgkp01p95jVkHayUk2D9OOy6 sqDvmi0qgmBYy95yUXLxLBopzsoq4sycv3Ux5jqtogawBE4P X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-phy@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230307_035923_367853_2F1513C6 X-CRM114-Status: GOOD ( 15.24 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/phy/phy-lgm-usb.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/phy/phy-lgm-usb.c b/drivers/phy/phy-lgm-usb.c index 309c8f0e0724..410729c7f513 100644 --- a/drivers/phy/phy-lgm-usb.c +++ b/drivers/phy/phy-lgm-usb.c @@ -252,13 +252,11 @@ static int phy_probe(struct platform_device *pdev) return usb_add_phy_dev(phy); } -static int phy_remove(struct platform_device *pdev) +static void phy_remove(struct platform_device *pdev) { struct tca_apb *ta = platform_get_drvdata(pdev); usb_remove_phy(&ta->phy); - - return 0; } static const struct of_device_id intel_usb_phy_dt_ids[] = { @@ -273,7 +271,7 @@ static struct platform_driver lgm_phy_driver = { .of_match_table = intel_usb_phy_dt_ids, }, .probe = phy_probe, - .remove = phy_remove, + .remove_new = phy_remove, }; module_platform_driver(lgm_phy_driver);