From patchwork Tue Mar 7 11:58:46 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13163321 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3E308C6FD1F for ; Tue, 7 Mar 2023 12:01:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3nthG3JnszIFAgMPG+CQLSAbFGf1Sef0Rkiubo7aT84=; b=DSI5tUOzm4MU1c CMtkdSQ/Muu/7eE8pKwHacl5EUju9HD0Wz4z6s9mkYIUfFgKOpLSYenrBIDR5Koiucaa+pzfKfXcW wYBeeQwqySMKlWHt+d3jTuCJsPkuYWxzjOxmKP955Iwlshtu15KyLSTEgb5N3Nmq+Nw2/mnZeoNtQ 70Nq6fVh/hK6arvzhGOH0LTmaSxA9v7CWHg+WzTEfvHwKdcOA87Pi+2JwFauVSCSFnxVvuiwR4SAC I7S4UA4XQ7Osf0dr03/c+J2v8ZuuiSqCLQQGan7ImeL7MzUfR+sjVhCUz2Zg2VDXIbeNJqi3If8/p CyAg3dgWQ8N7rzsCdiwA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZW0H-00HaDQ-Fm; Tue, 07 Mar 2023 12:01:13 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZVyu-00HZKf-GQ for linux-phy@bombadil.infradead.org; Tue, 07 Mar 2023 11:59:48 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Sender:Reply-To:Content-ID:Content-Description; bh=srthGBLeA0jfYr1ModFODTAoqlugvl4dBv7nTwh9Pbs=; b=FbUVvToVKU9hpFPiUO2lECLQ/k y1azZN4+27juZSCgBzbQ8mHV/1bZJ3wMCN+ViG22uQdaCfJzvuPFK1kXyLm1hsbRCFfs4+2v/4dHy D6eQqSmeoPFJIoRzsepgPPCDYEKFYAMh7gniFY/V/4nNR5kAj+giqGt33JlPsPUyla6niEVtJ/KW1 1REoJb+GJlgXb8Kf8dqSd61Ye1f7Cbr26d5Lhkyd+pPRAePo9uo8xC0KTF6hBkJhlAVArr2rqIxsS qvhip4ygkJ0lu0A7OYC7jbBABIuPTMwfhrZ/EmG01+8LSS5FsNxi19P6G19csFM1nQw9zBF2OYizM nyCzGU/g==; Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by desiato.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pZVyZ-00H2AD-2w for linux-phy@lists.infradead.org; Tue, 07 Mar 2023 11:59:47 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pZVyJ-0006Vu-It; Tue, 07 Mar 2023 12:59:11 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pZVyI-002TFN-Ca; Tue, 07 Mar 2023 12:59:10 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pZVyH-002yjd-Ff; Tue, 07 Mar 2023 12:59:09 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Yoshihiro Shimoda , Vinod Koul , Kishon Vijay Abraham I Cc: linux-renesas-soc@vger.kernel.org, linux-phy@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 17/31] phy: renesas: phy-rcar-gen3-usb3: Convert to platform remove callback returning void Date: Tue, 7 Mar 2023 12:58:46 +0100 Message-Id: <20230307115900.2293120-18-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230307115900.2293120-1-u.kleine-koenig@pengutronix.de> References: <20230307115900.2293120-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1688; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=S8xN6/D58vDbFZKshID6jaGWz2r8GuFPoFdy8ZZjYq8=; b=owEBbAGT/pANAwAKAcH8FHityuwJAcsmYgBkBybF+TZqDPzF/qGCk4H08UpsFE6WpXIMxBick 085AWCe92GJATIEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZAcmxQAKCRDB/BR4rcrs CQDBB/iJEXB1/Ahed08wq1tOfLj5XOMp40mLot7ba+rO2H/qW1GeGuZI7ipcgxITzfQnlIfc1wj hYt11Y4Uk36rMbgrZLAB/ESF5aeYK+lrmf2z0pKkP2gbOmK1lUWVp34d5mHHTTy6MA8gndSlXLZ TZ+tjs4kqnSb5VRDkM1dZ2A35K1TkMvT2I1i/VLmsGcG1nX1IJjix8NGTIRLyEvCzhtNGKSysp5 NtvzBpC3AStrLWPUxHsrN0nvLOZNwPs88bwU+Gbdbsk8Hk2oWTW7RjdZGk67qxpIZaUkiFvhcr5 7Uf2OEAoUmekrjcuXEdQKmErTlCPdxjo/FLmSfBs6wv//tE= X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-phy@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230307_115945_363176_62DB24AA X-CRM114-Status: GOOD ( 14.76 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Reviewed-by: Geert Uytterhoeven --- drivers/phy/renesas/phy-rcar-gen3-usb3.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/phy/renesas/phy-rcar-gen3-usb3.c b/drivers/phy/renesas/phy-rcar-gen3-usb3.c index f27d6f471629..e2d630edd992 100644 --- a/drivers/phy/renesas/phy-rcar-gen3-usb3.c +++ b/drivers/phy/renesas/phy-rcar-gen3-usb3.c @@ -199,11 +199,9 @@ static int rcar_gen3_phy_usb3_probe(struct platform_device *pdev) return ret; } -static int rcar_gen3_phy_usb3_remove(struct platform_device *pdev) +static void rcar_gen3_phy_usb3_remove(struct platform_device *pdev) { pm_runtime_disable(&pdev->dev); - - return 0; }; static struct platform_driver rcar_gen3_phy_usb3_driver = { @@ -212,7 +210,7 @@ static struct platform_driver rcar_gen3_phy_usb3_driver = { .of_match_table = rcar_gen3_phy_usb3_match_table, }, .probe = rcar_gen3_phy_usb3_probe, - .remove = rcar_gen3_phy_usb3_remove, + .remove_new = rcar_gen3_phy_usb3_remove, }; module_platform_driver(rcar_gen3_phy_usb3_driver);