From patchwork Tue Mar 7 11:58:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13163307 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8395FC6FD1B for ; Tue, 7 Mar 2023 12:00:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NOeoCEmgOKqCkM9qASnXE3Z1wh+jomYj+tbAKAdI5C0=; b=MgAlg2VGOSNUCB QoiXq2iH4+OEMJeLhDi4HUOb+bV5buQz4U7phUC4kqir6cy7UFikFf4FpM0ivlmXECVdRLB/aKTQc 4C7B1YYBPB2HfuYmJZVKZJHEf6e/U8o5fv/LeP38u1mx/IrrOvRWqDq8+l2PWlUewBRVlQVxm1L3M ltO4iy5d1xycB30fEixTZupSy2zGJJYit7VcOR2MlXNCRGGOLXX71JZnfWqky1ignwTevdgnWi9W9 ePmg6yAVyTjfaBcJfZEqVm+/ZnUFUxL9znNLbfVLFK6f6ezwk76DbBvsHb8lqba3jy39AcclZMlkd MWJhWUU1DOIUgFVA46nA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZVz8-00HZSS-Rd; Tue, 07 Mar 2023 12:00:02 +0000 Received: from metis.ext.pengutronix.de ([85.220.165.71]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZVyZ-00HZ58-70 for linux-phy@lists.infradead.org; Tue, 07 Mar 2023 11:59:31 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pZVyK-0006XQ-9l; Tue, 07 Mar 2023 12:59:12 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pZVyJ-002TFm-6X; Tue, 07 Mar 2023 12:59:11 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pZVyI-002yjo-6I; Tue, 07 Mar 2023 12:59:10 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Vinod Koul , Kishon Vijay Abraham I , Heiko Stuebner Cc: linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 20/31] phy: rockchip: phy-rockchip-inno-dsidphy: Convert to platform remove callback returning void Date: Tue, 7 Mar 2023 12:58:49 +0100 Message-Id: <20230307115900.2293120-21-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230307115900.2293120-1-u.kleine-koenig@pengutronix.de> References: <20230307115900.2293120-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1745; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=lehOlgnny9s9YCry74LCGOZ0ZUh8mvbpw5s20/s1D2E=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkBybRLBReKv+70Ss8u3GHrR3lrh0qQpW+itAX6 fM01umsxBWJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZAcm0QAKCRDB/BR4rcrs Ca6RCACDNdLE05biV9TVjBa1dw1Ho9bE39CgUqssJyw3KsPPTc/ieVj9irScI+gV4ZCrnG2VA1C PnOsgncF1VGtyqrpDGJ5qody35ck8N2hwL7skAm3UhcGk0RQEVZETeKPXKmbYx0YNgHCsgRoxCY MU7pFmXtlXL545NtYaqX0UymSo1MpUCcG8ImDRxRp1rXL6jpPpYbccpJHLJZ0dkWJ7dOHIqBnts CsZeH7L1nTqVabd3DP12ZuEUcOwo0ibzhzSi2ANKyWvQpzVFKxtLWLlvWEC7ERS9Qf+DGFPs/XE B9vz6+mUnWYCreFafvt6imG75rIrQtQz7F4QI1F9066t4rJK X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-phy@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230307_035927_347646_CAF4BECF X-CRM114-Status: GOOD ( 15.55 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Reviewed-by: Heiko Stuebner --- drivers/phy/rockchip/phy-rockchip-inno-dsidphy.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/phy/rockchip/phy-rockchip-inno-dsidphy.c b/drivers/phy/rockchip/phy-rockchip-inno-dsidphy.c index 2c5847faff63..726928ff1273 100644 --- a/drivers/phy/rockchip/phy-rockchip-inno-dsidphy.c +++ b/drivers/phy/rockchip/phy-rockchip-inno-dsidphy.c @@ -755,13 +755,11 @@ static int inno_dsidphy_probe(struct platform_device *pdev) return 0; } -static int inno_dsidphy_remove(struct platform_device *pdev) +static void inno_dsidphy_remove(struct platform_device *pdev) { struct inno_dsidphy *inno = platform_get_drvdata(pdev); pm_runtime_disable(inno->dev); - - return 0; } static const struct of_device_id inno_dsidphy_of_match[] = { @@ -788,7 +786,7 @@ static struct platform_driver inno_dsidphy_driver = { .of_match_table = of_match_ptr(inno_dsidphy_of_match), }, .probe = inno_dsidphy_probe, - .remove = inno_dsidphy_remove, + .remove_new = inno_dsidphy_remove, }; module_platform_driver(inno_dsidphy_driver);