From patchwork Tue Mar 7 11:58:52 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13163305 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5C7FDC678D4 for ; Tue, 7 Mar 2023 11:59:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+cw3PD/w3yIDREUOzgkXqoSxRGcUz0UtgnuBp0EcBE4=; b=rqJQqdGbg9bo02 YBhzuyNSE/XoiYFLuyipUkI2WuFgizTAc5BMZpZGHq0+9g0JQ85+21/a7fMmZ+FduvktH7535Rj8a tCIq6mULv5S7fDFbys74jNHaR7JSbiu/jsjZUoxqGp82uqhkigBkq2+bCfOeLuILyxbo4bc3pWxEM i5z6mKJ2AeceYZwxW2QN1MpZrcYcz7ecZ4JHjmoSKeaYeuxKyRjigelzQHZEm+ZjssSFG6QYTa27p 33Fboe23Qkj4s+FrPZS13z9JbePCwQKDJ1DFO4ZXmfKXRHfJP/nEP2+2KKe3VtBvUWmA0TafsdsO6 88fRlvYGPJFdBphC1IFA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZVyz-00HZNK-PN; Tue, 07 Mar 2023 11:59:53 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZVyY-00HZ5o-E8 for linux-phy@lists.infradead.org; Tue, 07 Mar 2023 11:59:29 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pZVyL-0006Zh-9v; Tue, 07 Mar 2023 12:59:13 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pZVyJ-002TG9-T3; Tue, 07 Mar 2023 12:59:11 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pZVyI-002yk2-QP; Tue, 07 Mar 2023 12:59:10 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Vinod Koul , Kishon Vijay Abraham I , Maxime Coquelin , Alexandre Torgue , Amelie Delaunay , Dan Carpenter , Fabrice Gasnier Cc: linux-phy@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 23/31] phy: st: phy-stm32-usbphyc: Convert to platform remove callback returning void Date: Tue, 7 Mar 2023 12:58:52 +0100 Message-Id: <20230307115900.2293120-24-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230307115900.2293120-1-u.kleine-koenig@pengutronix.de> References: <20230307115900.2293120-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1863; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=nLjrzhFMDWv8vjI/TpGtzSepyHgqVbB8jO7N9V2rgSw=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkBybdOJzEP8Mob8O1vUcByQ02bBPElIp2nyn3N cOH8KuWARqJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZAcm3QAKCRDB/BR4rcrs CSImB/0QNjaVQMfaMmv9zoXO2BF5RJ3RtN4ps6lvW09LJnzFzRScIA1pFNDkn2wLqVhrjPTw4IG 7C7uLxIgU1BMy6fWqpkzjRR8ztgrR/+4885Xngv6Yin0x4mAZcI51zgj7mUz4WvI0FNOvWtyg2i 8aMlJ9VIVEL+R8V3GSGZtTvp3V2IWr5peSxD5iYBlnO0MKww2BjLi3PJqyhIZatKMRZH1sZkM1i KAIku6iysvLYWW5wmdt7fwol1ypU9gWEljfdc8u4tsMtvxB0Rz53bLPNf1Vx/3QIv66bVlx8m39 lehCOOGjr+SF1YsUORJO+CwfDq04HMMLZFKVw/sPPBT96XgM X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-phy@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230307_035926_520026_71096FE8 X-CRM114-Status: GOOD ( 15.27 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/phy/st/phy-stm32-usbphyc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/phy/st/phy-stm32-usbphyc.c b/drivers/phy/st/phy-stm32-usbphyc.c index 5bb9647b078f..1add3b75f92f 100644 --- a/drivers/phy/st/phy-stm32-usbphyc.c +++ b/drivers/phy/st/phy-stm32-usbphyc.c @@ -766,7 +766,7 @@ static int stm32_usbphyc_probe(struct platform_device *pdev) return ret; } -static int stm32_usbphyc_remove(struct platform_device *pdev) +static void stm32_usbphyc_remove(struct platform_device *pdev) { struct stm32_usbphyc *usbphyc = dev_get_drvdata(&pdev->dev); int port; @@ -779,8 +779,6 @@ static int stm32_usbphyc_remove(struct platform_device *pdev) stm32_usbphyc_clk48_unregister(usbphyc); clk_disable_unprepare(usbphyc->clk); - - return 0; } static int __maybe_unused stm32_usbphyc_resume(struct device *dev) @@ -810,7 +808,7 @@ MODULE_DEVICE_TABLE(of, stm32_usbphyc_of_match); static struct platform_driver stm32_usbphyc_driver = { .probe = stm32_usbphyc_probe, - .remove = stm32_usbphyc_remove, + .remove_new = stm32_usbphyc_remove, .driver = { .of_match_table = stm32_usbphyc_of_match, .name = "stm32-usbphyc",