From patchwork Tue Mar 7 11:58:56 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13163310 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 79744C678D5 for ; Tue, 7 Mar 2023 12:00:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8jY2sO9uPkU4XsXZITqtAuWwpGc+lf5qhQr6c/+S1MI=; b=1ZEbaKapJVuaje VnpAcPTObmRTbiRxsZF/5stxf0Ju8nAEX+dMwLV34l8ADylGMb34scCTTlpWKm0TKeK4n2Hur+TRW ORbp6KA8Q+zQDNQS9kRpCjJBQxgdgVJUkllnWDI7PLO5SnpurB7MzyENqbalbnp063YrDbPUOLdfd qaR9aHLHeNDTvYcKtxBxKIzxZ65zs4ZttGcjuHoO9vM11zZZ1OatMUqqeUDNI4dnJFeZRZEO2A3hi P3ku9iSIHs1zRtl8n/4tAVYDm9iKtr2H52VsA08z8eOzSKnsSV6ZcRgONr4F9Vk6T43JeLaVekQTE jBd9kIA+WVETtzoMV+mQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZVzM-00HZbJ-PI; Tue, 07 Mar 2023 12:00:16 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZVye-00HZAw-Ho for linux-phy@bombadil.infradead.org; Tue, 07 Mar 2023 11:59:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Sender:Reply-To:Content-ID:Content-Description; bh=6O1WdzPj6Ft5B5O9E9+sInpxHghYZ0PyneOQ4Hoxwk4=; b=U+BOk/KmxfWX0geZquC4mn9NBZ m141rLUhC3nAPGppWLvfjBuF6riXbrULsRb+gDNYRSW+9OfuTDCPFzsEom9mQO8G6N5ybq8hpCvU/ L09lGfLQKECY7k6piXnTRiRELL2ZVUAXLdXqViwQaPCWP/h0Ef54A+bVm1xNB8KXoa6JAKNrN2+vc Hg00Etvvru+lAfByeG39DojdmWRTof4lSJeOFmHLLQdJcumhmNSFVjF5UTpJFhJgpoy2vB3S2lr6v XxZ1PcKXvTupX/822pyFS1kqhZhMUH/opKaLnZdKD118msNbpU/485ThbzepaOTy0GNkx0pvXyXhE Sw7RUrUg==; Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by desiato.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pZVyZ-00H2AE-2w for linux-phy@lists.infradead.org; Tue, 07 Mar 2023 11:59:30 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pZVyM-0006eh-9t; Tue, 07 Mar 2023 12:59:14 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pZVyK-002TGg-QJ; Tue, 07 Mar 2023 12:59:12 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pZVyJ-002ykL-Je; Tue, 07 Mar 2023 12:59:11 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Vinod Koul , Kishon Vijay Abraham I , Thomas Gleixner , Greg Kroah-Hartman , Allison Randal Cc: linux-phy@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 27/31] phy: ti: phy-dm816x-usb: Convert to platform remove callback returning void Date: Tue, 7 Mar 2023 12:58:56 +0100 Message-Id: <20230307115900.2293120-28-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230307115900.2293120-1-u.kleine-koenig@pengutronix.de> References: <20230307115900.2293120-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1619; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=rP419vYQFNJjNg4XeVQc/ig2aLrWTQ9D4XEUzDiLPYE=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkBybtu5/SV/UYPdf3doTL0pzQgOVwUxCIUJMF8 WnACfsz1tiJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZAcm7QAKCRDB/BR4rcrs CSclCACS+rPau3qlP7ZyiF5BDytx4ghlo6eu9OVqlbBeXllJGfXUXDRFBM2GKEfihYvx4BOcjuW 3E/dqwlLK7oSJxVEVjUlAKbVLIsgWfPR1Y+lAAuidrjT2Rkz59uVGSlakJukumYLyUq4oo9z9bc TXDU9c+vrRGk4l3Ke4gN/QJJjYzscqUo14Kv1x5joegZ7oFV/uwSvewr86WjDie5BvhfsJ746s9 6MZR/UD3tto7av0lOs4/t0Q7c7MhUR4pEpay7QIy+Qfmk7gZeEIga1dhTiDYOMHXV3ZsjZYCshR GKx3/Hlag4Ed7BrA5Ir0ru+2nc0RV7iFewhQOLy+WtPJ0d5g X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-phy@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230307_115928_135159_5FF4D636 X-CRM114-Status: GOOD ( 15.68 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/phy/ti/phy-dm816x-usb.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/phy/ti/phy-dm816x-usb.c b/drivers/phy/ti/phy-dm816x-usb.c index fb619908f912..db153a55f4e1 100644 --- a/drivers/phy/ti/phy-dm816x-usb.c +++ b/drivers/phy/ti/phy-dm816x-usb.c @@ -257,20 +257,18 @@ static int dm816x_usb_phy_probe(struct platform_device *pdev) return error; } -static int dm816x_usb_phy_remove(struct platform_device *pdev) +static void dm816x_usb_phy_remove(struct platform_device *pdev) { struct dm816x_usb_phy *phy = platform_get_drvdata(pdev); usb_remove_phy(&phy->phy); pm_runtime_disable(phy->dev); clk_unprepare(phy->refclk); - - return 0; } static struct platform_driver dm816x_usb_phy_driver = { .probe = dm816x_usb_phy_probe, - .remove = dm816x_usb_phy_remove, + .remove_new = dm816x_usb_phy_remove, .driver = { .name = "dm816x-usb-phy", .pm = &dm816x_usb_phy_pm_ops,