From patchwork Tue Mar 7 11:58:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13163295 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 42AF0C6FD1B for ; Tue, 7 Mar 2023 11:59:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IvtdQ3FlJ+xxS/Mkd9TnQGmqWDtjLlSwL7mBsz+xnc0=; b=Np5rHJEz2xnQD6 pd1qtuQmjfxQggQaHvZZShxBwzpgq4uAx02AEKcBE/m7Jd9S+TrwGOHx4XLB8rDbxHNSA/6IXSIs6 HDjo0k/glbjjKkqtpNDtk2v8O2TD8IHscl1kcEwLNq4z7VOyqtgMn1H08xeHPkagfVXS8yZ4lXHFP gvJU3551fcpPq8UKrR6hXWs9L6sQXt2lwsVKhkbUu85t4X+WC0F/6JHeVObw25exKveAyhRxKFR0g 1TdeMRXqvPCbOoENr9Dmk7ELqUX7fRM924HmT5WS2jfsAZdoWDdoTsE5z4kYbNhv/HPDTWrrUaxCz c5OT1+hOFb5NM/ywl20Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZVyl-00HZEb-ID; Tue, 07 Mar 2023 11:59:39 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZVyU-00HZ0K-7R for linux-phy@lists.infradead.org; Tue, 07 Mar 2023 11:59:25 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pZVyG-0006T6-PV; Tue, 07 Mar 2023 12:59:08 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pZVyF-002TEY-8e; Tue, 07 Mar 2023 12:59:07 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pZVyE-002yim-I7; Tue, 07 Mar 2023 12:59:06 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Justin Chen , Al Cooper , Vinod Koul , Kishon Vijay Abraham I Cc: Broadcom internal kernel review list , kernel@pengutronix.de, linux-phy@lists.infradead.org Subject: [PATCH 02/31] phy: broadcom: phy-brcm-usb: Convert to platform remove callback returning void Date: Tue, 7 Mar 2023 12:58:31 +0100 Message-Id: <20230307115900.2293120-3-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230307115900.2293120-1-u.kleine-koenig@pengutronix.de> References: <20230307115900.2293120-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1754; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=kRxw18bZDrPn1WjJek/wHs7gpvIV/Aep2Uaun+CRMAU=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkByaDyoUwhQtR8WuVn9jBLZGn9XA2UlgCx0ctl 6fdsAfPkN6JATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZAcmgwAKCRDB/BR4rcrs CWSbCACSS+oNu81C92z1NwJwGo41SEDJl/F1715d177nYoOY0l9hROREfmoUtYB9VCFLzF0iVRU mUdsBYDmE/hw6ePJz/ghEigBrhTmBEjd9iLiKPf4eFRfGHO2rt7lOR+bqCuIjlrNRMnjvhyp8Bc Uh9tn0mLtoADJ2602wikKCDE9l9/qf1lO9ToWJn7b8kYyGfxWWW9TqRddcNArqADTMeIQ+dZ6Sp Mb0M50aEVWkYvYYct6RIclrmLiMgEdZpDzs6aHdVUNwjfgJWuSsKnrRfwa4GxlKPE84Q2Nw67jH utl2Y+DkVMoCOBqE4IzF7nFgTjElkyUCMtI/6qHbnHpyWhKk X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-phy@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230307_035922_308924_254E0B6E X-CRM114-Status: GOOD ( 15.20 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Reviewed-by: Florian Fainelli Reviewed-by: Justin Chen --- drivers/phy/broadcom/phy-brcm-usb.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/phy/broadcom/phy-brcm-usb.c b/drivers/phy/broadcom/phy-brcm-usb.c index 4de39999f43d..a4cfb777dd83 100644 --- a/drivers/phy/broadcom/phy-brcm-usb.c +++ b/drivers/phy/broadcom/phy-brcm-usb.c @@ -572,14 +572,12 @@ static int brcm_usb_phy_probe(struct platform_device *pdev) return PTR_ERR_OR_ZERO(phy_provider); } -static int brcm_usb_phy_remove(struct platform_device *pdev) +static void brcm_usb_phy_remove(struct platform_device *pdev) { struct brcm_usb_phy_data *priv = dev_get_drvdata(&pdev->dev); sysfs_remove_group(&pdev->dev.kobj, &brcm_usb_phy_group); unregister_pm_notifier(&priv->pm_notifier); - - return 0; } #ifdef CONFIG_PM_SLEEP @@ -670,7 +668,7 @@ MODULE_DEVICE_TABLE(of, brcm_usb_dt_ids); static struct platform_driver brcm_usb_driver = { .probe = brcm_usb_phy_probe, - .remove = brcm_usb_phy_remove, + .remove_new = brcm_usb_phy_remove, .driver = { .name = "brcmstb-usb-phy", .pm = &brcm_usb_phy_pm_ops,