From patchwork Tue Mar 7 11:59:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13163296 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 46F41C6FA99 for ; Tue, 7 Mar 2023 11:59:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Fh8w53Ls6J2ltnoIoy2RLjNxKj4g2He96/s6COR+YRg=; b=sPMbnucXTCKq8B 5vJ7bknBX0ODF9DO2HCevyarcIo7rIxdwaE7B8BJMlu0tj1ArQWrQnHkdAV/rdtDRYirYQectl60/ WdV6+bFtgZDvx7R/qlgV8NbLcdJ8+zFMW3p1AAincTqEkT5yWAcE8ym3WsCCWC+iGoIAZH1CMU6D4 j41Ns6yHueGzkqEqELxpetygCI2BaWewqU0Wg9U8iR3UqrIqc864f4i2C6PnuDbJ4xB0T1xFk+UPn 55sHW6Or5hHFCgCXSGgMrZwe81G42tv9WtOwwQ8QtXKG/PztoXp1D+pCtFB7GHuBr8I6AqG3fL/2z T5mjEG9vTSxP0MFiOh6w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZVyl-00HZEO-Ee; Tue, 07 Mar 2023 11:59:39 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZVyU-00HZ0V-21 for linux-phy@lists.infradead.org; Tue, 07 Mar 2023 11:59:25 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pZVyM-0006ib-M6; Tue, 07 Mar 2023 12:59:14 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pZVyL-002TGs-Fs; Tue, 07 Mar 2023 12:59:13 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pZVyK-002ykb-E8; Tue, 07 Mar 2023 12:59:12 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Vinod Koul , Kishon Vijay Abraham I Cc: linux-phy@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 31/31] phy: ti: phy-twl4030-usb: Convert to platform remove callback returning void Date: Tue, 7 Mar 2023 12:59:00 +0100 Message-Id: <20230307115900.2293120-32-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230307115900.2293120-1-u.kleine-koenig@pengutronix.de> References: <20230307115900.2293120-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1778; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=x76+uAh/aCN0r+XL8kn2KmvnQxCd4vTYcPtI3jbitnc=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkByb9luHNrS2UNsryvX2ZXGp51qdHA3H20lfAy Ojaht0Z1YqJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZAcm/QAKCRDB/BR4rcrs CUpFB/9mCQhPFCAw9X/M6gd8sTYoU24P4tgxBpJs/ohEt5tCsjaEaqINRHrEs7zgD6SURfU9AL3 GgVTs6z1yNrL1RGFzzFgqeMSgZ8xZLdV1jqa51lB/j6WXQvxNgS27WdpUbfcQwPMwe3yNkZfEKp gFTbi6wxrk5nVsRoU9IZtqosO3f2JKWBTs4r0QgdtcuSDdYbRU1j4A5rORaqNAiBoe5lFAOj6ei lFsgRsyiXgptOHXElooSEHAMPQaxIaSSZETtpe3F8T4sqO32/GPgAkZS+z7S4GsEmBHSfQiEtiU 3vs9Y9TYM5v+LzyAXyNibFwwu5RzZQMKV+MbKu9gqZEVr6YS X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-phy@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230307_035922_183706_F366CBA6 X-CRM114-Status: GOOD ( 15.38 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/phy/ti/phy-twl4030-usb.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/phy/ti/phy-twl4030-usb.c b/drivers/phy/ti/phy-twl4030-usb.c index ac71017a0bc1..da50732625d1 100644 --- a/drivers/phy/ti/phy-twl4030-usb.c +++ b/drivers/phy/ti/phy-twl4030-usb.c @@ -787,7 +787,7 @@ static int twl4030_usb_probe(struct platform_device *pdev) return 0; } -static int twl4030_usb_remove(struct platform_device *pdev) +static void twl4030_usb_remove(struct platform_device *pdev) { struct twl4030_usb *twl = platform_get_drvdata(pdev); int val; @@ -821,8 +821,6 @@ static int twl4030_usb_remove(struct platform_device *pdev) /* disable complete OTG block */ twl4030_usb_clear_bits(twl, POWER_CTRL, POWER_CTRL_OTG_ENAB); - - return 0; } #ifdef CONFIG_OF @@ -835,7 +833,7 @@ MODULE_DEVICE_TABLE(of, twl4030_usb_id_table); static struct platform_driver twl4030_usb_driver = { .probe = twl4030_usb_probe, - .remove = twl4030_usb_remove, + .remove_new = twl4030_usb_remove, .driver = { .name = "twl4030_usb", .pm = &twl4030_usb_pm_ops,